[Problem] InitializeUIValues always calls itself -> fix DriveLetterComboBoxSelectionChanged #620

New Issue

Open

opened 2026-01-29 16:19:31 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:19:31 +00:00

Owner

Copy Link

Originally created by @Deterous on GitHub (Oct 10, 2023).

Originally assigned to: @mnadareski on GitHub.

Every time InitializeUIValues is called (except perhaps during init), the function calls itself.
This is a side effect of InitializeUIValues calling PopulateDrives, which in turn runs: a8e783235c/MPF.Core/UI/ViewModels/MainViewModel.cs (L621)

By creating the list of drives, the Drive Letter Combo Box changes, which triggers DriveLetterComboBoxSelectionChanged, which in turn calls InitializeUIValues again: a8e783235c/MPF.UI.Core/Windows/MainWindow.xaml.cs (L339)

This is an obvious unintended code execution, and also causes the log to mention that there are no valid drives, because DriveLetterComboBoxSelectionChanged runs InitializeUIValues without any drives. Fortunately, rescanDrives is set to false, or else this would be recursive :)

Potential solution: DriveLetterComboBoxSelectionChanged logic can somehow be improved to ensure it is only called when the user changes the combo box, not the program itself?

Originally created by @Deterous on GitHub (Oct 10, 2023). Originally assigned to: @mnadareski on GitHub. Every time `InitializeUIValues` is called (except perhaps during init), the function calls itself. This is a side effect of `InitializeUIValues` calling `PopulateDrives`, which in turn runs: https://github.com/SabreTools/MPF/blob/a8e783235c7a6d654cf431c669697ae19fc7c51f/MPF.Core/UI/ViewModels/MainViewModel.cs#L621 By creating the list of drives, the Drive Letter Combo Box changes, which triggers `DriveLetterComboBoxSelectionChanged`, which in turn calls `InitializeUIValues` again: https://github.com/SabreTools/MPF/blob/a8e783235c7a6d654cf431c669697ae19fc7c51f/MPF.UI.Core/Windows/MainWindow.xaml.cs#L339 This is an obvious unintended code execution, and also causes the log to mention that there are no valid drives, because `DriveLetterComboBoxSelectionChanged` runs `InitializeUIValues` without any drives. Fortunately, rescanDrives is set to false, or else this would be recursive :) Potential solution: `DriveLetterComboBoxSelectionChanged` logic can somehow be improved to ensure it is only called when the user changes the combo box, not the program itself?

claunia added the bug label 2026-01-29 16:19:31 +00:00

claunia referenced this issue 2026-01-29 16:25:10 +00:00

[PR #620] [MERGED] Support ringcode and PIC for triple/quad-layer #1063

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label bug

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#620