[PR #634] [MERGED] Normalize Disc Title in Submission Info #1074

New Issue

Closed

opened 2026-01-29 16:25:14 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:25:14 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/634
Author: @Deterous
Created: 1/19/2024
Status: ✅ Merged
Merged: 1/19/2024
Merged by: @mnadareski

Base: master ← Head: det-patch-A

---

📝 Commits (2)

• 1b736dd NormalizeDiscTitle for SubmissionInfo
• e2f1cd4 Update changelog

📊 Changes

3 files changed (+16 additions, -9 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.Core/InfoTool.cs (+11 -7)
📝 MPF.Core/UI/ViewModels/DiscInformationViewModel.cs (+4 -2)

📄 Description

Applies NormalizeDiscTitle to the main title field during SubmissionInfo generation.
Does not operate on Foreign Title as that field does not need alphabetization?

Implements the work done to fix #365 (I assume this is the desired output?)
Probably needs more testing

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/634 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 1/19/2024 **Status:** ✅ Merged **Merged:** 1/19/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `det-patch-A` --- ### 📝 Commits (2) - [`1b736dd`](https://github.com/SabreTools/MPF/commit/1b736ddb469b9167282b9e90875744bcac080843) NormalizeDiscTitle for SubmissionInfo - [`e2f1cd4`](https://github.com/SabreTools/MPF/commit/e2f1cd4472029ddce67f6e5aee65154cf182ebda) Update changelog ### 📊 Changes **3 files changed** (+16 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.Core/InfoTool.cs` (+11 -7) 📝 `MPF.Core/UI/ViewModels/DiscInformationViewModel.cs` (+4 -2) </details> ### 📄 Description Applies NormalizeDiscTitle to the main title field during SubmissionInfo generation. Does not operate on Foreign Title as that field does not need alphabetization? Implements the work done to fix #365 (I assume this is the desired output?) Probably needs more testing --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:25:14 +00:00

claunia closed this issue 2026-01-29 16:25:14 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1074