SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-08 21:31:47 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #780] [MERGED] Better deal with volume labels #1156

New Issue
Closed
opened 2026-01-29 16:25:45 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:25:45 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/780
Author: @Deterous
Created: 12/13/2024
Status: ✅ Merged
Merged: 12/15/2024
Merged by: @mnadareski

Base: master ← Head: master

📝 Commits (8)

📊 Changes

4 files changed (+77 additions, -11 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.Frontend/Tools/FrontendTool.cs (+18 -7)
📝 MPF.Frontend/Tools/SubmissionGenerator.cs (+56 -2)
📝 MPF.Processors/DiscImageCreator.cs (+2 -2)

📄 Description

Trying to do a minimal effort solution to #744
No testing done yet.
Also removed Joliet parsing for DIC, it seems to be broken at the moment.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/780 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 12/13/2024 **Status:** ✅ Merged **Merged:** 12/15/2024 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (8) - [`ad99931`](https://github.com/SabreTools/MPF/commit/ad9993190679bdca9e2ec3dc2e4d78c215cdf071) Better deal with volume labels - [`0a963af`](https://github.com/SabreTools/MPF/commit/0a963afed0b0ef9a65be5f22bb856c3f37f63231) Add missing using - [`d3b5979`](https://github.com/SabreTools/MPF/commit/d3b59792fe7d865506271f07d849a3dfda5166cc) use nullable string - [`61b48f5`](https://github.com/SabreTools/MPF/commit/61b48f500b25b5e302db146c49d50a611f797cb0) Deal with review comments - [`0dc3638`](https://github.com/SabreTools/MPF/commit/0dc3638a9d5ad2a84f08749cba7fbfb05ebe6013) Fix issues - [`ed7a09e`](https://github.com/SabreTools/MPF/commit/ed7a09e64587ae9229a5b4b2484dd80c58fe63ba) Better deal with Xbox/Xbox360 labels - [`ffa08ab`](https://github.com/SabreTools/MPF/commit/ffa08abc9ba377a8f0be3e2ef9ac74e2eec3e3f3) Use FirstOrDefault - [`43331ac`](https://github.com/SabreTools/MPF/commit/43331acb861771b0afa00cd7d8fad28bfaa92a00) Add todo ### 📊 Changes **4 files changed** (+77 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.Frontend/Tools/FrontendTool.cs` (+18 -7) 📝 `MPF.Frontend/Tools/SubmissionGenerator.cs` (+56 -2) 📝 `MPF.Processors/DiscImageCreator.cs` (+2 -2) </details> ### 📄 Description Trying to do a minimal effort solution to #744 No testing done yet. Also removed Joliet parsing for DIC, it seems to be broken at the moment. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:25:45 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#1156
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?