SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-04 05:35:52 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Request] Parse all DIC write offsets #744

New Issue
Open
opened 2026-01-29 16:21:36 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:21:36 +00:00
Owner
Copy Link

Originally created by @Deterous on GitHub (Oct 8, 2024).

Originally assigned to: @mnadareski on GitHub.

DIC can output more than one write offset. MPF currently just parses the first one in the log, however this loses the information about any other offsets.

Example log fragment:

========== Offset (Drive offset refers to http://www.accuraterip.com) ==========
     Combined Offset(Byte)  13120, (Samples)  3280
    -   Drive Offset(Byte)    120, (Samples)    30
    ----------------------------------------------
           CD Offset(Byte)  13000, (Samples)  3250
    Overread sector: 6
========== Offset (Drive offset refers to http://www.accuraterip.com) ==========
     Combined Offset(Byte)   1640, (Samples)   410
    -   Drive Offset(Byte)    120, (Samples)    30
    ----------------------------------------------
           CD Offset(Byte)   1520, (Samples)   380
    Overread sector: 1

Current MPF output: +3250
Requested MPF output: +3250, +380

Originally created by @Deterous on GitHub (Oct 8, 2024). Originally assigned to: @mnadareski on GitHub. DIC can output more than one write offset. MPF currently just parses the first one in the log, however this loses the information about any other offsets. Example log fragment: ``` ========== Offset (Drive offset refers to http://www.accuraterip.com) ========== Combined Offset(Byte) 13120, (Samples) 3280 - Drive Offset(Byte) 120, (Samples) 30 ---------------------------------------------- CD Offset(Byte) 13000, (Samples) 3250 Overread sector: 6 ========== Offset (Drive offset refers to http://www.accuraterip.com) ========== Combined Offset(Byte) 1640, (Samples) 410 - Drive Offset(Byte) 120, (Samples) 30 ---------------------------------------------- CD Offset(Byte) 1520, (Samples) 380 Overread sector: 1 ``` Current MPF output: `+3250` Requested MPF output: `+3250, +380`
claunia added the enhancement label 2026-01-29 16:21:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#744
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?