[PR #836] [MERGED] Quality of life fixes #1184

New Issue

Open

opened 2026-01-29 16:25:53 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:25:53 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/836
Author: @Deterous
Created: 4/17/2025
Status: ✅ Merged
Merged: 4/17/2025
Merged by: @mnadareski

Base: master ← Head: master

---

📝 Commits (8)

• 5d2b034 Account for N-type discs in Redumper processor
• 82ca1a2 MediaType prefix
• a0afbc6 Delete after zipping, ask before closing during dump
• 19f4789 Proper closing function
• bac0ab0 proper using
• 6636ad6 nullable object
• 54fada5 YesNoCancel isn't a thing for CustomMessageBox
• f07e772 Ctrl-Z

📊 Changes

5 files changed (+43 additions, -6 deletions)

View changed files

📝 MPF.ExecutionContexts.Test/RedumperTests.cs (+1 -1)
📝 MPF.Frontend/ViewModels/MainViewModel.cs (+23 -3)
📝 MPF.Processors/Redumper.cs (+4 -1)
📝 MPF.UI/Windows/MainWindow.xaml.cs (+15 -0)
📝 MPF.UI/Windows/WindowBase.cs (+0 -1)

📄 Description

Fixes #808 by switching to Yes/No message box, turns out CustomMessageBox.Show doesn't do YesNoCancel type boxes
Fixes #821 by allowing Redumper Processor to process N-type discs
Fixes #830 by asking user to confirm they want to quit if a dump is still being processed

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/836 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 4/17/2025 **Status:** ✅ Merged **Merged:** 4/17/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (8) - [`5d2b034`](https://github.com/SabreTools/MPF/commit/5d2b034c02d915153f31897d48338458359811c6) Account for N-type discs in Redumper processor - [`82ca1a2`](https://github.com/SabreTools/MPF/commit/82ca1a2cbfef8a036b59bff42782de41a6c0652a) MediaType prefix - [`a0afbc6`](https://github.com/SabreTools/MPF/commit/a0afbc6b41e0458b63851bc33e75f2fdf9f1ad29) Delete after zipping, ask before closing during dump - [`19f4789`](https://github.com/SabreTools/MPF/commit/19f47893b1149e7be65f06eaa6a0ab6054e72fdf) Proper closing function - [`bac0ab0`](https://github.com/SabreTools/MPF/commit/bac0ab066741da4468bd53704e0e6356b062873e) proper using - [`6636ad6`](https://github.com/SabreTools/MPF/commit/6636ad6e3db9670938787cd105890c3190bebeaf) nullable object - [`54fada5`](https://github.com/SabreTools/MPF/commit/54fada54e66f48c18caca8bb9d82ea98aff599ae) YesNoCancel isn't a thing for CustomMessageBox - [`f07e772`](https://github.com/SabreTools/MPF/commit/f07e772ce9a592248318cc5a506508b15ca03dc2) Ctrl-Z ### 📊 Changes **5 files changed** (+43 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `MPF.ExecutionContexts.Test/RedumperTests.cs` (+1 -1) 📝 `MPF.Frontend/ViewModels/MainViewModel.cs` (+23 -3) 📝 `MPF.Processors/Redumper.cs` (+4 -1) 📝 `MPF.UI/Windows/MainWindow.xaml.cs` (+15 -0) 📝 `MPF.UI/Windows/WindowBase.cs` (+0 -1) </details> ### 📄 Description Fixes #808 by switching to Yes/No message box, turns out CustomMessageBox.Show doesn't do YesNoCancel type boxes Fixes #821 by allowing Redumper Processor to process N-type discs Fixes #830 by asking user to confirm they want to quit if a dump is still being processed --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:25:53 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1184