SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #885] [MERGED] Fix UIC processing logic #1211

New Issue
Closed
opened 2026-01-29 16:26:04 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:26:04 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/885
Author: @Deterous
Created: 9/4/2025
Status: ✅ Merged
Merged: 9/4/2025
Merged by: @mnadareski

Base: master ← Head: master

📝 Commits (6)

📊 Changes

7 files changed (+33 additions, -21 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.Processors.Test/ProcessingToolTests.cs (+3 -6)
📝 MPF.Processors.Test/TestData/UmdImageCreator/UMD-zip/test_logs.zip (+0 -0)
📝 MPF.Processors.Test/TestData/UmdImageCreator/UMD/test_disc.txt (+20 -6)
📝 MPF.Processors.Test/UmdImageCreatorTests.cs (+4 -4)
📝 MPF.Processors/ProcessingTool.cs (+3 -3)
📝 MPF.Processors/UmdImageCreator.cs (+2 -2)

📄 Description

Currently UmdImageCreator processor takes only 1st element after splitting by space character. If a title contains a space, it discards all other words in the title. This fix retains the full title (still discarding the 0th TITLE: component).

Also, the 'category' field logic is fixed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/885 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 9/4/2025 **Status:** ✅ Merged **Merged:** 9/4/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (6) - [`b43f614`](https://github.com/SabreTools/MPF/commit/b43f614489b6e1336691bb441a0acafd21bf2e01) Fix UIC title field - [`89c8eac`](https://github.com/SabreTools/MPF/commit/89c8eac1729cd87923d86385b8dd51a5eac2a70b) the sabre approved way - [`f10e955`](https://github.com/SabreTools/MPF/commit/f10e9554a7bb8ebb2b5fbd7ebdb65383c85120b7) Better UIC test_disc.txt - [`d51c581`](https://github.com/SabreTools/MPF/commit/d51c581af0f4f92060392d5656603c314cf0d923) Fix UIC category logic - [`77d5d52`](https://github.com/SabreTools/MPF/commit/77d5d52c2ffb530a89fc4e50b71621b43be274aa) Fix GetUMDCategoryTest - [`2b10831`](https://github.com/SabreTools/MPF/commit/2b10831eb8be5de5449c88c75af77a78f39fbaaa) Final test tweak ### 📊 Changes **7 files changed** (+33 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.Processors.Test/ProcessingToolTests.cs` (+3 -6) 📝 `MPF.Processors.Test/TestData/UmdImageCreator/UMD-zip/test_logs.zip` (+0 -0) 📝 `MPF.Processors.Test/TestData/UmdImageCreator/UMD/test_disc.txt` (+20 -6) 📝 `MPF.Processors.Test/UmdImageCreatorTests.cs` (+4 -4) 📝 `MPF.Processors/ProcessingTool.cs` (+3 -3) 📝 `MPF.Processors/UmdImageCreator.cs` (+2 -2) </details> ### 📄 Description Currently UmdImageCreator processor takes only 1st element after splitting by space character. If a title contains a space, it discards all other words in the title. This fix retains the full title (still discarding the 0th `TITLE:` component). Also, the 'category' field logic is fixed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:26:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#1211
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?