[PR #895] [MERGED] Remove SkipMediaTypeDetection option, cleanup options window #1217

New Issue

claunia · 2026-01-29T16:26:06Z

claunia commented

2026-01-29 16:26:06 +00:00

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/895
Author: @Deterous
Created: 9/26/2025
Status: ✅ Merged
Merged: 9/26/2025
Merged by: @mnadareski

Base: master ← Head: master

📝 Commits (3)

a96f76f Remove SkipMediaTypeDetection option, cleanup options window
28418cd Shrink detection section in options
6d692a2 always try to guess media type

📊 Changes

4 files changed (+13 additions, -35 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.Frontend/Options.cs (+0 -9)
📝 MPF.Frontend/ViewModels/MainViewModel.cs (+2 -9)
📝 MPF.UI/Windows/OptionsWindow.xaml (+10 -17)

📄 Description

SkipMediaTypeDetection option is now mostly obsolete, so this PR removes it.
Unlike long ago, MPF no longer uses the old third party library (no chance of freezing the UI so there is no essential need for the option).
And as of recently, only DIC execution context cares about the media type, so I have replaced the option with a check against Internal Program. Media type detection now runs only when DIC is selected.

Additionally, a couple of minor UI fixes have been made in the Options window.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/895 **Author:** [@Deterous](https://github.com/Deterous) **Created:** 9/26/2025 **Status:** ✅ Merged **Merged:** 9/26/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`a96f76f`](https://github.com/SabreTools/MPF/commit/a96f76fb0828ca5e8f02dcbc2c5420fe02684eae) Remove SkipMediaTypeDetection option, cleanup options window - [`28418cd`](https://github.com/SabreTools/MPF/commit/28418cd16684cbd4b03fa26c871ad9cb8527d236) Shrink detection section in options - [`6d692a2`](https://github.com/SabreTools/MPF/commit/6d692a21e2a517407c742b151aec5204d81c2a7d) always try to guess media type ### 📊 Changes **4 files changed** (+13 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.Frontend/Options.cs` (+0 -9) 📝 `MPF.Frontend/ViewModels/MainViewModel.cs` (+2 -9) 📝 `MPF.UI/Windows/OptionsWindow.xaml` (+10 -17) </details> ### 📄 Description `SkipMediaTypeDetection` option is now mostly obsolete, so this PR removes it. Unlike long ago, MPF no longer uses the old third party library (no chance of freezing the UI so there is no essential need for the option). And as of recently, only DIC execution context cares about the media type, so I have replaced the option with a check against Internal Program. Media type detection now runs only when DIC is selected. Additionally, a couple of minor UI fixes have been made in the Options window. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:26:06 +00:00

claunia closed this issue

2026-01-29 16:26:07 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#1217