SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-08 13:49:48 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #2] [MERGED] Bring list to parity with Redump known types #895

New Issue
Closed
opened 2026-01-29 16:24:09 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:09 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/2
Author: @mnadareski
Created: 5/14/2018
Status: ✅ Merged
Merged: 5/14/2018
Merged by: @undefined

Base: master ← Head: master

📝 Commits (3)

  • ea82e42 Bring list to parity with Redump known types
  • e305ea1 Enable building on all machines
  • 3ed267d Merge branch 'master' into master

📊 Changes

3 files changed (+158 additions, -51 deletions)

View changed files

📝 DICUI.csproj (+2 -1)
📝 MainWindow.xaml (+12 -7)
📝 MainWindow.xaml.cs (+144 -43)

📄 Description

This change adds all remaining consoles and disc-based devices that are currently listed in Redump as valid devices. This also does some minor renames and splits that bring this to parity as well. One minor TODO note was added possibly for future ease-of-use for dumping IBM PC software.

The second commit disables application signing because no certificate is in the repository and nobody but the original author would be able to build this from source otherwise.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/2 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 5/14/2018 **Status:** ✅ Merged **Merged:** 5/14/2018 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`ea82e42`](https://github.com/SabreTools/MPF/commit/ea82e42601bbc30a2d408fc14f96081102c18f16) Bring list to parity with Redump known types - [`e305ea1`](https://github.com/SabreTools/MPF/commit/e305ea1fdb192b3dc1bb4067e11754488ad8dba8) Enable building on all machines - [`3ed267d`](https://github.com/SabreTools/MPF/commit/3ed267d7517cd7c15662e2c82efe3a5f7e9d27f4) Merge branch 'master' into master ### 📊 Changes **3 files changed** (+158 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `DICUI.csproj` (+2 -1) 📝 `MainWindow.xaml` (+12 -7) 📝 `MainWindow.xaml.cs` (+144 -43) </details> ### 📄 Description This change adds all remaining consoles and disc-based devices that are currently listed in Redump as valid devices. This also does some minor renames and splits that bring this to parity as well. One minor TODO note was added possibly for future ease-of-use for dumping IBM PC software. The second commit disables application signing because no certificate is in the repository and nobody but the original author would be able to build this from source otherwise. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#895
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?