SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-08 05:37:45 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] UI dies while scanning PS1 discs for anti-mod strings #276

New Issue
Closed
opened 2026-01-29 16:13:29 +00:00 by claunia · 6 comments
claunia commented 2026-01-29 16:13:29 +00:00
Owner
Copy Link

Originally created by @Kreeblah on GitHub (Mar 20, 2021).

Originally assigned to: @mnadareski on GitHub.

Before You Submit

  • Remember to try the latest WIP build to see if the issue has already been addressed.
  • Is it copy protection related? If so, report the issue here instead.
  • .NET Core 3.1 and .NET 5.0 have known issues, please try using another build to reproduce the error
  • Check multiple discs to help narrow down the issue
  • Check the Options to see if changing any of those affects your issue.

If all of those fail, then continue...

Version
What version are you using?

  • Stable release (version here)
  • WIP release bfbae5cf5c

Build
What runtime version are you using?

  • .NET Framework 4.7.2 running on (Operating System)
  • .NET Framework 4.8 running on Windows 10
  • .NET Core 3.1 running on (Operating System)

Describe the issue
I've only tried this with two PS1 discs (Descent and Descent Maximum) so far, but it's happened with both. While scanning for anti-mod strings, the UI suddenly quits. There is still a DiscImageCreator.exe process which continues running, and locks the files in the output directory, but I'm not really sure what it's doing.

This seems to happen around the 65000-75000 sector range, and it happens every time I try to read one of these discs.

To Reproduce
Steps to reproduce the behavior:

  1. Configure the app to use the CLI programs from the 1.18 bundle (in case it makes a difference)
  2. Insert either Descent for PS1 or Descent Maximum for PS1 (or possibly other PS1 discs)
  3. Make sure it was detected as a Sony Playstation disc
  4. Begin dumping
  5. Make sure it starts scanning for anti-mod strings
  6. Wait for the UI to quit

Expected behavior
I'd expect the UI to not quit.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
I haven't seen anything in the output files that looks super relevant here, but I might have missed something.

Originally created by @Kreeblah on GitHub (Mar 20, 2021). Originally assigned to: @mnadareski on GitHub. **Before You Submit** - Remember to try the [latest WIP build](https://ci.appveyor.com/project/mnadareski/mpf/build/artifacts) to see if the issue has already been addressed. - Is it copy protection related? If so, report the issue [here](https://github.com/mnadareski/BurnOutSharp/issues) instead. - .NET Core 3.1 and .NET 5.0 have known issues, please try using another build to reproduce the error - Check multiple discs to help narrow down the issue - Check the Options to see if changing any of those affects your issue. If all of those fail, then continue... **Version** What version are you using? - [ ] Stable release (version here) - [x] WIP release https://github.com/SabreTools/MPF/commit/bfbae5cf5c9d1d406eac77fcb162c8acd8dfd355 **Build** What runtime version are you using? - [ ] .NET Framework 4.7.2 running on (Operating System) - [x] .NET Framework 4.8 running on Windows 10 - [ ] .NET Core 3.1 running on (Operating System) **Describe the issue** I've only tried this with two PS1 discs (Descent and Descent Maximum) so far, but it's happened with both. While scanning for anti-mod strings, the UI suddenly quits. There is still a DiscImageCreator.exe process which continues running, and locks the files in the output directory, but I'm not really sure what it's doing. This seems to happen around the 65000-75000 sector range, and it happens every time I try to read one of these discs. **To Reproduce** Steps to reproduce the behavior: 1. Configure the app to use the CLI programs from the 1.18 bundle (in case it makes a difference) 2. Insert either Descent for PS1 or Descent Maximum for PS1 (or possibly other PS1 discs) 3. Make sure it was detected as a Sony Playstation disc 4. Begin dumping 5. Make sure it starts scanning for anti-mod strings 6. Wait for the UI to quit **Expected behavior** I'd expect the UI to not quit. **Screenshots** If applicable, add screenshots to help explain your problem. **Additional context** I haven't seen anything in the output files that looks super relevant here, but I might have missed something.
claunia added the bug label 2026-01-29 16:13:29 +00:00
claunia commented 2026-01-29 16:13:31 +00:00
Author
Owner
Copy Link

@Kreeblah commented on GitHub (Mar 20, 2021):

Oh, I'm also not sure whether it's related to BurnOutSharp or not. If it is, I can report the issue there instead.

@Kreeblah commented on GitHub (Mar 20, 2021): Oh, I'm also not sure whether it's related to BurnOutSharp or not. If it is, I can report the issue there instead.
claunia commented 2026-01-29 16:13:32 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Mar 20, 2021):

Since it's happening before the dump as a part of DIC, it's something about DIC's outputs at that point that is causing the issue. I'm assuming that DIC's outputs are going to the Log output instead of a separate window in your case?

@mnadareski commented on GitHub (Mar 20, 2021): Since it's happening before the dump as a part of DIC, it's something about DIC's outputs at that point that is causing the issue. I'm assuming that DIC's outputs are going to the Log output instead of a separate window in your case?
claunia commented 2026-01-29 16:13:32 +00:00
Author
Owner
Copy Link

@Kreeblah commented on GitHub (Mar 20, 2021):

They are, yeah.

@Kreeblah commented on GitHub (Mar 20, 2021): They are, yeah.
claunia commented 2026-01-29 16:13:33 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Mar 26, 2021):

Okay, I did try to reproduce this locally to no avail. I then added 4842bdd38b to ensure that if there's a logging error (like during processing of DIC outputs) it will just log the error and continue.

Even with that (and an additional change to process the anti-mod search 2d19d51bc7) I still haven't been able to observe the same results.

@mnadareski commented on GitHub (Mar 26, 2021): Okay, I did try to reproduce this locally to no avail. I then added https://github.com/SabreTools/MPF/commit/4842bdd38b93bfc69ba810e7dbce7c78e8bf77b4 to ensure that if there's a logging error (like during processing of DIC outputs) it will just log the error and continue. Even with that (and an additional change to process the anti-mod search https://github.com/SabreTools/MPF/commit/2d19d51bc7a14a33560148369c0bae86f858d4df) I still haven't been able to observe the same results.
claunia commented 2026-01-29 16:13:33 +00:00
Author
Owner
Copy Link

@Kreeblah commented on GitHub (Mar 26, 2021):

Well, I just tried 2d19d51bc7 and I can't reproduce the issue at all. With bfbae5cf5c it happened 100% of the time, but I can't get it to happen with this commit. So, I think it's good.

I did notice one cosmetic thing, though, with the anti-mod progress bar. It says "anit-mod" instead of "anti-mod". Anyway, I think this can probably be closed. Thanks for taking a look at it!

@Kreeblah commented on GitHub (Mar 26, 2021): Well, I just tried https://github.com/SabreTools/MPF/commit/2d19d51bc7a14a33560148369c0bae86f858d4df and I can't reproduce the issue at all. With https://github.com/SabreTools/MPF/commit/bfbae5cf5c9d1d406eac77fcb162c8acd8dfd355 it happened 100% of the time, but I can't get it to happen with this commit. So, I think it's good. I did notice one cosmetic thing, though, with the anti-mod progress bar. It says "anit-mod" instead of "anti-mod". Anyway, I think this can probably be closed. Thanks for taking a look at it!
claunia commented 2026-01-29 16:13:33 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Mar 26, 2021):

Oops, typo'd that one. I'll fix that and close this right after. Hopefully the extra guard around logging will prevent something like that to happen in the future. Honestly, still no idea why it would have done that before.

@mnadareski commented on GitHub (Mar 26, 2021): Oops, typo'd that one. I'll fix that and close this right after. Hopefully the extra guard around logging will prevent something like that to happen in the future. Honestly, still no idea why it would have done that before.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#276
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?