SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-08 13:49:48 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #276] [MERGED] Parametrics #990

New Issue
Open
opened 2026-01-29 16:24:42 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:42 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/276
Author: @mnadareski
Created: 4/25/2021
Status: ✅ Merged
Merged: 4/25/2021
Merged by: @mnadareski

Base: master ← Head: re-param

📝 Commits (6)

  • 0e71653 Begin reducing complexity of parameters classes
  • 0ff4898 Make the method virtual, not the field
  • 3e8e31f Consolidate helper methods
  • 88f0d41 Fix "empty" commands; Fix DD generation
  • c34fa7b Handle all sorts of numerical values
  • 4c09f46 Rip out remaining unneeded enum

📊 Changes

19 files changed (+2393 additions, -3141 deletions)

View changed files

📝 MPF.Library/Aaru/Constants.cs (+2 -0)
📝 MPF.Library/Aaru/Converters.cs (+0 -402)
➖ MPF.Library/Aaru/Enumerations.cs (+0 -149)
📝 MPF.Library/Aaru/Parameters.cs (+876 -858)
📝 MPF.Library/CleanRIp/Parameters.cs (+0 -1)
📝 MPF.Library/DD/Constants.cs (+1 -0)
📝 MPF.Library/DD/Converters.cs (+0 -82)
➖ MPF.Library/DD/Enumerations.cs (+0 -34)
📝 MPF.Library/DD/Parameters.cs (+90 -306)
📝 MPF.Library/Data/BaseParameters.cs (+642 -10)
📝 MPF.Library/Data/DumpEnvironment.cs (+2 -2)
📝 MPF.Library/DiscImageCreator/Constants.cs (+1 -0)
📝 MPF.Library/DiscImageCreator/Converters.cs (+32 -249)
➖ MPF.Library/DiscImageCreator/Enumerations.cs (+0 -75)
📝 MPF.Library/DiscImageCreator/Parameters.cs (+690 -915)
📝 MPF.Library/UmdImageCreator/Parameters.cs (+0 -1)
📝 MPF.Test/Utilities/ConvertersTest.cs (+36 -36)
📝 MPF.Test/Utilities/ParametersTest.cs (+20 -20)
📝 MPF/Windows/MainWindow.xaml.cs (+1 -1)

📄 Description

This PR is focused around making each of the parameter classes share more in common. This is not currently either and ideal nor complete solution.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/276 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 4/25/2021 **Status:** ✅ Merged **Merged:** 4/25/2021 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `re-param` --- ### 📝 Commits (6) - [`0e71653`](https://github.com/SabreTools/MPF/commit/0e71653ca2db22de0a5c87ae495bd66d4c7379ab) Begin reducing complexity of parameters classes - [`0ff4898`](https://github.com/SabreTools/MPF/commit/0ff48986dc73950bc6997fe191199e7d185777a5) Make the method virtual, not the field - [`3e8e31f`](https://github.com/SabreTools/MPF/commit/3e8e31fcd4835c6f8e1ecd372d196b2a48d3b0f2) Consolidate helper methods - [`88f0d41`](https://github.com/SabreTools/MPF/commit/88f0d41ebdd32466b9c23bb51b5dccbd0932fb73) Fix "empty" commands; Fix DD generation - [`c34fa7b`](https://github.com/SabreTools/MPF/commit/c34fa7b7edf3d3bd47a8830829e450f8b5e577be) Handle all sorts of numerical values - [`4c09f46`](https://github.com/SabreTools/MPF/commit/4c09f46aa5597bcd5fc33c36921d999a5e9f59fc) Rip out remaining unneeded enum ### 📊 Changes **19 files changed** (+2393 additions, -3141 deletions) <details> <summary>View changed files</summary> 📝 `MPF.Library/Aaru/Constants.cs` (+2 -0) 📝 `MPF.Library/Aaru/Converters.cs` (+0 -402) ➖ `MPF.Library/Aaru/Enumerations.cs` (+0 -149) 📝 `MPF.Library/Aaru/Parameters.cs` (+876 -858) 📝 `MPF.Library/CleanRIp/Parameters.cs` (+0 -1) 📝 `MPF.Library/DD/Constants.cs` (+1 -0) 📝 `MPF.Library/DD/Converters.cs` (+0 -82) ➖ `MPF.Library/DD/Enumerations.cs` (+0 -34) 📝 `MPF.Library/DD/Parameters.cs` (+90 -306) 📝 `MPF.Library/Data/BaseParameters.cs` (+642 -10) 📝 `MPF.Library/Data/DumpEnvironment.cs` (+2 -2) 📝 `MPF.Library/DiscImageCreator/Constants.cs` (+1 -0) 📝 `MPF.Library/DiscImageCreator/Converters.cs` (+32 -249) ➖ `MPF.Library/DiscImageCreator/Enumerations.cs` (+0 -75) 📝 `MPF.Library/DiscImageCreator/Parameters.cs` (+690 -915) 📝 `MPF.Library/UmdImageCreator/Parameters.cs` (+0 -1) 📝 `MPF.Test/Utilities/ConvertersTest.cs` (+36 -36) 📝 `MPF.Test/Utilities/ParametersTest.cs` (+20 -20) 📝 `MPF/Windows/MainWindow.xaml.cs` (+1 -1) </details> ### 📄 Description This PR is focused around making each of the parameter classes share more in common. This is not currently either and ideal nor complete solution. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:42 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#990
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?