[PR #75] [MERGED] Remove Redundant Calls and PSX Automation #948

New Issue

claunia · 2026-01-29T16:24:27Z

claunia commented

2026-01-29 16:24:27 +00:00

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/75
Author: @mnadareski
Created: 6/25/2018
Status: ✅ Merged
Merged: 6/26/2018
Merged by: @mnadareski

Base: master ← Head: redundant-red

📝 Commits (10+)

883b135 Work with callbacks to increase perf
1f21563 Make EDC field for PSX automatic
f540fab Make AntiMod field for PSX automatic
b3435a7 Make LibCrypt field for PSX automatic
7f1b610 Remove psxt001z
baa556b We need the subIntention data for LibCrypt
b10aeb3 Let's avoid null for now
fe1eba8 Set default speed in case of error
e7a7dfa Check the layerbreak better
ecec32f Remove extraneous header checking

📊 Changes

9 files changed (+194 additions, -152 deletions)

View changed files

📝 App.config (+0 -1)
📝 Data/Constants.cs (+4 -4)
📝 MainWindow.xaml.cs (+22 -60)
📝 Options.cs (+0 -2)
📝 OptionsWindow.xaml (+6 -11)
📝 OptionsWindow.xaml.cs (+1 -12)
📝 Utilities/Converters.cs (+1 -0)
📝 Utilities/DumpInformation.cs (+124 -62)
➕ appveyor.yml (+36 -0)

📄 Description

The current code can have >=3 calls to some functions in a row due to a misunderstanding on how the setting of an index triggers the change events. This PR should remove the worst offenders for duplicate calls, presumably making startup and some item changes a lot smoother.

For the PSX automation, there are the following changes:

EDC check becomes automatic, due to similarities in how the error count and EDC are checked
Anti-modchip string check becomes automatic thanks to the /am flag (Thanks to TonyLizard for helping find this)
LibCrypt check becomes automatic thanks to the /nl flag and the existence of the _subIntention.txt file, similar to SecuROM for PC discs (Thanks to TonyLizard for helping find this)

Because of that last item, psxt001z is no longer needed, and has been removed with this PR.

Unintentionally , this PR also addresses some issues that have been persistent due to some assumptions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/75 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 6/25/2018 **Status:** ✅ Merged **Merged:** 6/26/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `redundant-red` --- ### 📝 Commits (10+) - [`883b135`](https://github.com/SabreTools/MPF/commit/883b1357486ba90f6ab93d9cefa1f0ce5e05623e) Work with callbacks to increase perf - [`1f21563`](https://github.com/SabreTools/MPF/commit/1f215631150f404b7c9904e842c1d848ffba1ede) Make EDC field for PSX automatic - [`f540fab`](https://github.com/SabreTools/MPF/commit/f540fab6735491d85ee57a6bd554d3e90da356c7) Make AntiMod field for PSX automatic - [`b3435a7`](https://github.com/SabreTools/MPF/commit/b3435a7dfd22759f305e2343e581be0cc7eb6838) Make LibCrypt field for PSX automatic - [`7f1b610`](https://github.com/SabreTools/MPF/commit/7f1b6103fe109f2a6e7f6f52300981e5bf588189) Remove psxt001z - [`baa556b`](https://github.com/SabreTools/MPF/commit/baa556b1e2e35ac9e5010e256cb93aa933a2ebc0) We need the subIntention data for LibCrypt - [`b10aeb3`](https://github.com/SabreTools/MPF/commit/b10aeb3910fbc2b321000f358df1cfe287622760) Let's avoid null for now - [`fe1eba8`](https://github.com/SabreTools/MPF/commit/fe1eba8955dab2b988601ba49eecdaf5f381a83a) Set default speed in case of error - [`e7a7dfa`](https://github.com/SabreTools/MPF/commit/e7a7dfa96a7787d5c9e7b410a75848d6d57b78d0) Check the layerbreak better - [`ecec32f`](https://github.com/SabreTools/MPF/commit/ecec32fc244621b0a895c6b88947e74bdf9fceee) Remove extraneous header checking ### 📊 Changes **9 files changed** (+194 additions, -152 deletions) <details> <summary>View changed files</summary> 📝 `App.config` (+0 -1) 📝 `Data/Constants.cs` (+4 -4) 📝 `MainWindow.xaml.cs` (+22 -60) 📝 `Options.cs` (+0 -2) 📝 `OptionsWindow.xaml` (+6 -11) 📝 `OptionsWindow.xaml.cs` (+1 -12) 📝 `Utilities/Converters.cs` (+1 -0) 📝 `Utilities/DumpInformation.cs` (+124 -62) ➕ `appveyor.yml` (+36 -0) </details> ### 📄 Description The current code can have >=3 calls to some functions in a row due to a misunderstanding on how the setting of an index triggers the change events. This PR should remove the worst offenders for duplicate calls, presumably making startup and some item changes a lot smoother. For the PSX automation, there are the following changes: - EDC check becomes automatic, due to similarities in how the error count and EDC are checked - Anti-modchip string check becomes automatic thanks to the `/am` flag (Thanks to TonyLizard for helping find this) - LibCrypt check becomes automatic thanks to the `/nl` flag and the existence of the `_subIntention.txt` file, similar to SecuROM for PC discs (Thanks to TonyLizard for helping find this) Because of that last item, psxt001z is no longer needed, and has been removed with this PR. Unintentionally , this PR also addresses some issues that have been persistent due to some assumptions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:24:27 +00:00

claunia closed this issue

2026-01-29 16:24:27 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#948