SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-08 05:37:45 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #102] [MERGED] Unblock and Update #973

New Issue
Closed
opened 2026-01-29 16:24:36 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:36 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/102
Author: @mnadareski
Created: 7/19/2018
Status: ✅ Merged
Merged: 7/19/2018
Merged by: @mnadareski

Base: master ← Head: r15

📝 Commits (6)

📊 Changes

7 files changed (+32 additions, -26 deletions)

View changed files

📝 DICUI/DICUI.csproj (+4 -4)
📝 DICUI/Data/Enumerations.cs (+1 -0)
📝 DICUI/MainWindow.xaml.cs (+2 -14)
📝 DICUI/Utilities/Converters.cs (+2 -0)
📝 DICUI/Utilities/DumpEnvironment.cs (+18 -6)
📝 DICUI/Utilities/Validators.cs (+3 -0)
📝 DICUI/packages.config (+2 -2)

📄 Description

This PR has two major items:

  • Update external packages (BurnOutSharp and Unshield)
  • Make it so that external tools and submission info creation don't block the main thread

This PR also includes a couple of minor things:

  • Added "Rainbow Disc" as a valid output option for the whole, like, 1 disc that falls in that category
  • Added more formats to the same output fields as IBM and Macintosh
  • Fixed automatic filling of output paths (this one was somehow really broken the old way, often reverting to just "disc". No idea why, but the cleaner code has not run into this issue)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/102 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 7/19/2018 **Status:** ✅ Merged **Merged:** 7/19/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `r15` --- ### 📝 Commits (6) - [`d4fce1a`](https://github.com/SabreTools/MPF/commit/d4fce1a7028725fd8cfa577825d7ef148471c8ac) RAINBOW - [`00086b4`](https://github.com/SabreTools/MPF/commit/00086b402ed67c5006a04559766315bacc59be93) Add to FormatOutputData - [`d2f0d6b`](https://github.com/SabreTools/MPF/commit/d2f0d6be416102120aaf35303a7f4bc318d48f54) Update BurnOutSharp - [`c81c589`](https://github.com/SabreTools/MPF/commit/c81c5899c5db335924b6a15c1b3c2d0794057513) Fix parameter creation - [`f5f779e`](https://github.com/SabreTools/MPF/commit/f5f779e9786efc0c004ca92b301c6c7a6b1cbf57) Minor improvements - [`3d940f8`](https://github.com/SabreTools/MPF/commit/3d940f860c28bc1d013f471d10757709ce6481f1) Update package versions ### 📊 Changes **7 files changed** (+32 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `DICUI/DICUI.csproj` (+4 -4) 📝 `DICUI/Data/Enumerations.cs` (+1 -0) 📝 `DICUI/MainWindow.xaml.cs` (+2 -14) 📝 `DICUI/Utilities/Converters.cs` (+2 -0) 📝 `DICUI/Utilities/DumpEnvironment.cs` (+18 -6) 📝 `DICUI/Utilities/Validators.cs` (+3 -0) 📝 `DICUI/packages.config` (+2 -2) </details> ### 📄 Description This PR has two major items: - Update external packages (BurnOutSharp and Unshield) - Make it so that external tools and submission info creation don't block the main thread This PR also includes a couple of minor things: - Added "Rainbow Disc" as a valid output option for the whole, like, 1 disc that falls in that category - Added more formats to the same output fields as IBM and Macintosh - Fixed automatic filling of output paths (this one was somehow really broken the old way, often reverting to just "disc". No idea why, but the cleaner code has not run into this issue) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#973
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?