SabreTools/SabreTools.RedumpLib
1
0
Fork 0
mirror of https://github.com/SabreTools/SabreTools.RedumpLib.git synced 2026-07-08 18:16:25 +00:00
Code Issues 14 Packages Projects Releases 21 Wiki Activity

Update ToDiscType and add tests

Browse Source
This commit is contained in:
Matt Nadareski
2024-12-01 22:31:19 -05:00
parent 70e3e074cc
commit ffa8f2b16e
2 changed files with 68 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
SabreTools.RedumpLib.Test/Data/ExtensionsTests.cs
View File

@@ -226,7 +226,34 @@ namespace SabreTools.RedumpLib.Test.Data
Assert.NotNull(actual);
}
// TODO: Add ToDiscType test
/// <summary>
/// Check that every DiscType can be mapped from a string
/// </summary>
/// <param name="discType">DiscType value to check</param>
/// <param name="expectNull">True to expect a null value, false otherwise</param>
[Theory]
[MemberData(nameof(GenerateDiscTypeTestData))]
public void DiscType_ToDiscType(DiscType? discType, bool expectNull)
{
string? longName = discType.LongName();
string? longNameSpaceless = longName?
.Replace(" ", string.Empty)
.Replace("-", string.Empty);
var actualNormal = longName.ToDiscType();
var actualSpaceless = longNameSpaceless.ToDiscType();
if (expectNull)
{
Assert.Null(actualNormal);
Assert.Null(actualSpaceless);
}
else
{
Assert.Equal(discType, actualNormal);
Assert.Equal(discType, actualSpaceless);
}
}
/// <summary>
/// Generate a test set of DiscType values

81
SabreTools.RedumpLib/Data/Extensions.cs
View File

@@ -824,6 +824,14 @@ namespace SabreTools.RedumpLib.Data
#region Disc Type
/// <summary>
/// Get the Redump longnames for each known disc type
/// </summary>
/// <param name="discType"></param>
/// <returns></returns>
public static string? LongName(this DiscType discType)
=> ((DiscType?)discType).LongName();
/// <summary>
/// Get the Redump longnames for each known disc type
/// </summary>
@@ -837,52 +845,43 @@ namespace SabreTools.RedumpLib.Data
/// </summary>
/// <param name="discType">String value to convert</param>
/// <returns>DiscType represented by the string, if possible</returns>
public static DiscType? ToDiscType(string discType)
public static DiscType? ToDiscType(this string? discType)
{
// No value means no match
if (discType == null || discType.Length == 0)
return null;
discType = discType.ToLowerInvariant();
var discTypes = (DiscType[])Enum.GetValues(typeof(DiscType));
// Check long names
int index = Array.FindIndex(discTypes, s => discType == s.LongName()?.ToLowerInvariant()
|| discType == s.LongName()?.Replace(" ", string.Empty)?.ToLowerInvariant()
|| discType == s.LongName()?.Replace("-", string.Empty)?.ToLowerInvariant()
|| discType == s.LongName()?
.Replace(" ", string.Empty)?
.Replace("-", string.Empty)?
.ToLowerInvariant());
if (index > -1)
return discTypes[index];
// Special cases
return (discType?.ToLowerInvariant()) switch
{
"bd25"
or "bd-25" => DiscType.BD25,
"bd33"
or "bd-33" => DiscType.BD33,
"bd50"
or "bd-50" => DiscType.BD50,
"bd66"
or "bd-66" => DiscType.BD66,
"bd100"
or "bd-100" => DiscType.BD100,
"bd128"
or "bd-128" => DiscType.BD128,
"cd"
or "cdrom"
"bd"
or "bdrom"
or "bd-rom"
or "bluray"
or "blu-ray" => DiscType.BD25,
"cdrom"
or "cd-rom" => DiscType.CD,
"dvd5"
or "dvd-5" => DiscType.DVD5,
"dvd9"
or "dvd-9" => DiscType.DVD9,
"gd"
or "gdrom"
or "gd-rom" => DiscType.GDROM,
"dvd"
or "dvd-rom" => DiscType.DVD5,
"gd" => DiscType.GDROM,
"hddvd"
or "hddvdsl"
or "hd-dvd sl" => DiscType.HDDVDSL,
"hddvddl"
or "hd-dvd dl" => DiscType.HDDVDDL,
"milcd"
or "mil-cd" => DiscType.MILCD,
"nintendogamecubegamedisc"
or "nintendo game cube game disc" => DiscType.NintendoGameCubeGameDisc,
"nintendowiiopticaldiscsl"
or "nintendo wii optical disc sl" => DiscType.NintendoWiiOpticalDiscSL,
"nintendowiiopticaldiscdl"
or "nintendo wii optical disc dl" => DiscType.NintendoWiiOpticalDiscDL,
"nintendowiiuopticaldiscsl"
or "nintendo wii u optical disc sl" => DiscType.NintendoWiiUOpticalDiscSL,
"umd"
or "umdsl"
or "umd sl" => DiscType.UMDSL,
"umddl"
or "umd dl" => DiscType.UMDDL,
or "hd-dvd" => DiscType.HDDVDSL,
"umd" => DiscType.UMDSL,
_ => null,
};
}