SabreTools/SabreTools.Serialization
1
0
Fork 0
mirror of https://github.com/SabreTools/SabreTools.Serialization.git synced 2026-09-23 07:14:57 +00:00
Code Issues 56 Packages Projects Releases 20 Wiki Activity

Better file descriptor method

Browse Source
This commit is contained in:
Matt Nadareski
2025-07-31 13:23:45 -04:00
parent e94e27910e
commit 013d18a426
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
SabreTools.Serialization/Wrappers/InstallShieldCabinet.cs
View File

@@ -361,13 +361,13 @@ namespace SabreTools.Serialization.Wrappers
/// Get the file descriptor at a given index, if possible
/// </summary>
/// <remarks>Verifies the file descriptor flags before returning</remarks>
public FileDescriptor? GetFileDescriptorWithVerification(int index, out string? error)
public bool TryGetFileDescriptor(int index, out FileDescriptor? fileDescriptor)
{
var fileDescriptor = GetFileDescriptor(index);
fileDescriptor = GetFileDescriptor(index);
if (fileDescriptor == null)
{
error = $"Failed to get file descriptor for file {index}";
return null;
Console.Error.WriteLine($"Failed to get file descriptor for file {index}");
return false;
}
#if NET20 || NET35
@@ -376,12 +376,11 @@ namespace SabreTools.Serialization.Wrappers
if (fileDescriptor.Flags.HasFlag(FileFlags.FILE_INVALID) || fileDescriptor.DataOffset == 0)
#endif
{
error = $"File at {index} is marked as invalid";
return null;
Console.Error.WriteLine($"File at {index} is marked as invalid");
return false;
}
error = null;
return fileDescriptor;
return true;
}
/// <summary>