SabreTools/SabreTools.Serialization
1
0
Fork 0
mirror of https://github.com/SabreTools/SabreTools.Serialization.git synced 2026-04-06 06:11:45 +00:00
Code Issues 56 Packages Projects Releases 20 Wiki Activity

Default sort is never done, so CompareTo is useless

Browse Source
This commit is contained in:
Matt Nadareski
2026-04-05 01:59:34 -04:00
parent 337d4c0fed
commit 0eb5da5fd4
3 changed files with 2 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
SabreTools.Metadata.DatItems.Test/DatItemTests.cs
View File

@@ -194,66 +194,6 @@ namespace SabreTools.Metadata.DatItems.Test
#endregion
#region CompareTo
[Fact]
public void CompareTo_NullOther_Returns1()
{
DatItem self = new Rom();
DatItem? other = null;
int actual = self.CompareTo(other);
Assert.Equal(1, actual);
}
[Fact]
public void CompareTo_DifferentOther_Returns1()
{
DatItem self = new Rom { Name = "name" };
DatItem? other = new Disk { Name = "name" };
int actual = self.CompareTo(other);
Assert.Equal(1, actual);
}
[Fact]
public void CompareTo_Empty_Returns1()
{
DatItem self = new Rom();
DatItem? other = new Rom();
int actual = self.CompareTo(other);
Assert.Equal(1, actual);
}
[Theory]
[InlineData(null, null, 0)]
[InlineData("name", null, 1)]
[InlineData("name", "other", -1)]
[InlineData(null, "name", -1)]
[InlineData("other", "name", 1)]
[InlineData("name", "name", 0)]
public void CompareTo_NamesOnly(string? selfName, string? otherName, int expected)
{
DatItem self = new Rom
{
Name = selfName,
CRC = "DEADBEEF"
};
DatItem? other = new Rom
{
Name = otherName,
CRC = "DEADBEEF"
};
int actual = self.CompareTo(other);
Assert.Equal(expected, actual);
}
#endregion
#region Equals
[Fact]

22
SabreTools.Metadata.DatItems/DatItem.cs
View File

@@ -52,7 +52,7 @@ namespace SabreTools.Metadata.DatItems
[XmlInclude(typeof(SoftwareList))]
[XmlInclude(typeof(Sound))]
[XmlInclude(typeof(SourceDetails))]
public abstract class DatItem : ICloneable, IComparable<DatItem>, IEquatable<DatItem>
public abstract class DatItem : ICloneable, IEquatable<DatItem>
{
#region Properties
@@ -137,26 +137,6 @@ namespace SabreTools.Metadata.DatItems
#region Comparision Methods
/// <inheritdoc/>
public int CompareTo(DatItem? other)
{
// If the other item doesn't exist
if (other is null)
return 1;
// Get the names to avoid changing values
string? selfName = GetName();
string? otherName = other.GetName();
// If the names are equal
if (selfName == otherName)
return Equals(other) ? 0 : 1;
// If `otherName` is null, Compare will return > 0
// If `selfName` is null, Compare will return < 0
return string.Compare(selfName, otherName, StringComparison.Ordinal);
}
/// <summary>
/// Determine if an item is a duplicate using partial matching logic
/// </summary>

22
SabreTools.Metadata.DatItems/DatItemT.cs
View File

@@ -6,7 +6,7 @@ namespace SabreTools.Metadata.DatItems
/// <summary>
/// Base class for all items included in a set that are backed by an internal model
/// </summary>
public abstract class DatItem<T> : DatItem, IEquatable<DatItem<T>>, IComparable<DatItem<T>>, ICloneable
public abstract class DatItem<T> : DatItem, ICloneable, IEquatable<DatItem<T>>
where T : Data.Models.Metadata.DatItem, new()
{
#region Private Fields
@@ -54,26 +54,6 @@ namespace SabreTools.Metadata.DatItems
#region Comparision Methods
/// <inheritdoc/>
public int CompareTo(DatItem<T>? other)
{
// If the other item doesn't exist
if (other is null)
return 1;
// Get the names to avoid changing values
string? selfName = GetName();
string? otherName = other.GetName();
// If the names are equal
if (selfName == otherName)
return Equals(other) ? 0 : 1;
// If `otherName` is null, Compare will return > 0
// If `selfName` is null, Compare will return < 0
return string.Compare(selfName, otherName, StringComparison.Ordinal);
}
/// <summary>
/// Determine if an item is a duplicate using partial matching logic
/// </summary>