SabreTools/SabreTools.Serialization
1
0
Fork 0
mirror of https://github.com/SabreTools/SabreTools.Serialization.git synced 2026-09-24 07:45:06 +00:00
Code Issues 56 Packages Projects Releases 20 Wiki Activity

Add header length safeguards to PortableExecutable wrapper (#9)

Browse Source
This commit is contained in:
TheRogueArchivist
2024-06-05 20:19:35 -06:00
committed by GitHub
parent 73ec66e627
commit 1b412c3027
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
SabreTools.Serialization/Wrappers/PortableExecutable.cs
View File

@@ -45,7 +45,12 @@ namespace SabreTools.Serialization.Wrappers
.OrderBy(s => s)
.First();
int headerLength = (int)(firstSectionAddress - headerStartAddress);
_headerPaddingData = ReadFromDataSource((int)headerStartAddress, headerLength);
// Check if the header length is more than 0 before reading data
if (headerLength <= 0)
_headerPaddingData = [];
else
_headerPaddingData = ReadFromDataSource((int)headerStartAddress, headerLength);
// Cache and return the header padding data, even if null
return _headerPaddingData;
@@ -80,7 +85,12 @@ namespace SabreTools.Serialization.Wrappers
.OrderBy(s => s)
.First();
int headerLength = (int)(firstSectionAddress - headerStartAddress);
_headerPaddingStrings = ReadStringsFromDataSource((int)headerStartAddress, headerLength, charLimit: 3);
// Check if the header length is more than 0 before reading strings
if (headerLength <= 0)
_headerPaddingStrings = [];
else
_headerPaddingStrings = ReadStringsFromDataSource((int)headerStartAddress, headerLength, charLimit: 3);
// Cache and return the header padding data, even if null
return _headerPaddingStrings;