SabreTools/SabreTools.Serialization
1
0
Fork 0
mirror of https://github.com/SabreTools/SabreTools.Serialization.git synced 2026-09-22 06:45:11 +00:00
Code Issues 56 Packages Projects Releases 20 Wiki Activity

Do not access dictionary with index

Browse Source
This commit is contained in:
Matt Nadareski
2026-04-17 09:14:39 -04:00
parent ecd4e7d1df
commit 25ab9acb57
1 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
SabreTools.Metadata.DatFiles/ItemDatabase.cs
View File

@@ -238,18 +238,6 @@ namespace SabreTools.Metadata.DatFiles
return default;
}
/// <summary>
/// Remove a value from the table, returning success
/// </summary>
public bool Remove(long index)
{
#if NET40_OR_GREATER || NETCOREAPP || NETSTANDARD2_0_OR_GREATER
return _table.TryRemove(index, out var _);
#else
return _table.Remove(index);
#endif
}
/// <summary>
/// Remove all values that match a function
/// </summary>
@@ -261,8 +249,16 @@ namespace SabreTools.Metadata.DatFiles
for (int i = 0; i < Indexes.Length; i++)
#endif
{
if (func(_table[i]))
Remove(i);
var value = Get(i);
if (value is null)
#if NET40_OR_GREATER || NETCOREAPP || NETSTANDARD2_0_OR_GREATER
return;
#else
continue;
#endif
if (func(value))
TryRemove(i, out _);
#if NET40_OR_GREATER || NETCOREAPP || NETSTANDARD2_0_OR_GREATER
});
#else