Remove now-redundant Equals methods

This commit is contained in:
Matt Nadareski
2026-04-05 02:24:05 -04:00
parent 3caf65822f
commit 742c991deb
44 changed files with 1 additions and 657 deletions

View File

@@ -75,21 +75,6 @@ namespace SabreTools.Metadata.DatItems.Test
// Everything else fails
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<TestDatItemModel>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is TestDatItem otherTestDatItem)
return _internal.Equals(otherTestDatItem._internal);
// Everything else fails
return false;
}
}
#endregion

View File

@@ -6,7 +6,7 @@ namespace SabreTools.Metadata.DatItems
/// <summary>
/// Base class for all items included in a set that are backed by an internal model
/// </summary>
public abstract class DatItem<T> : DatItem, ICloneable, IEquatable<DatItem<T>>
public abstract class DatItem<T> : DatItem, ICloneable
where T : Data.Models.Metadata.DatItem, new()
{
#region Private Fields
@@ -52,17 +52,6 @@ namespace SabreTools.Metadata.DatItems
#endregion
#region Comparision Methods
/// <summary>
/// Determine if an item is a duplicate using partial matching logic
/// </summary>
/// <param name="other">DatItem to use as a baseline</param>
/// <returns>True if the items are duplicates, false otherwise</returns>
public abstract bool Equals(DatItem<T>? other);
#endregion
#region Manipulation
/// <inheritdoc/>

View File

@@ -98,21 +98,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Adjuster>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Adjuster otherAdjuster)
return _internal.Equals(otherAdjuster._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -75,21 +75,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Analog>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Analog otherAnalog)
return _internal.Equals(otherAnalog._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -266,21 +266,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Archive>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Archive otherArchive)
return _internal.Equals(otherArchive._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -87,21 +87,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.BiosSet>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is BiosSet otherBiosSet)
return _internal.Equals(otherBiosSet._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -69,21 +69,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Blank>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Blank otherBlank)
return _internal.Equals(otherBlank._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -105,21 +105,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Chip>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Chip otherChip)
return _internal.Equals(otherChip._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -93,21 +93,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Condition>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Condition otherCondition)
return _internal.Equals(otherCondition._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -87,21 +87,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.ConfLocation>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is ConfLocation otherConfLocation)
return _internal.Equals(otherConfLocation._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -104,21 +104,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.ConfSetting>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is ConfSetting otherConfSetting)
return _internal.Equals(otherConfSetting._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -127,21 +127,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Configuration>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Configuration otherConfiguration)
return _internal.Equals(otherConfiguration._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -141,21 +141,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Control>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Control otherControl)
return _internal.Equals(otherControl._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -111,21 +111,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.DataArea>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is DataArea otherDataArea)
return _internal.Equals(otherDataArea._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -134,21 +134,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Device>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Device otherDevice)
return _internal.Equals(otherDevice._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -75,21 +75,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.DeviceRef>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is DeviceRef otherDeviceRef)
return _internal.Equals(otherDeviceRef._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -87,21 +87,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.DipLocation>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is DipLocation otherDipLocation)
return _internal.Equals(otherDipLocation._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -157,21 +157,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.DipSwitch>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is DipSwitch otherDipSwitch)
return _internal.Equals(otherDipSwitch._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -104,21 +104,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.DipValue>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is DipValue otherDipValue)
return _internal.Equals(otherDipValue._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -188,21 +188,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Disk>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Disk otherDisk)
return _internal.PartialEquals(otherDisk._internal);
// Everything else fails
return false;
}
/// <summary>
/// Fill any missing size and hash information from another Disk
/// </summary>

View File

@@ -93,21 +93,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.DiskArea>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is DiskArea otherDiskArea)
return _internal.Equals(otherDiskArea._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -182,21 +182,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Display>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Display otherDisplay)
return _internal.Equals(otherDisplay._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -141,21 +141,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Driver>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Driver otherDriver)
return _internal.Equals(otherDriver._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -75,21 +75,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Extension>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Extension otherExtension)
return _internal.Equals(otherExtension._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -99,21 +99,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Feature>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Feature otherFeature)
return _internal.Equals(otherFeature._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -81,21 +81,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Info>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Info otherInfo)
return _internal.Equals(otherInfo._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -123,21 +123,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Input>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Input otherInput)
return _internal.Equals(otherInput._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -81,21 +81,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Instance>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Instance otherInstance)
return _internal.Equals(otherInstance._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -133,21 +133,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Media>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Media otherMedia)
return _internal.PartialEquals(otherMedia._internal);
// Everything else fails
return false;
}
/// <summary>
/// Fill any missing size and hash information from another Media
/// </summary>

View File

@@ -133,21 +133,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Part>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Part otherPart)
return _internal.Equals(otherPart._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -104,21 +104,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Feature>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is PartFeature otherPartFeature)
return _internal.Equals(otherPartFeature._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -93,21 +93,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Port>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Port otherPort)
return _internal.Equals(otherPort._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -87,21 +87,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.RamOption>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is RamOption otherRamOption)
return _internal.Equals(otherRamOption._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -99,21 +99,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Release>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Release otherRelease)
return _internal.Equals(otherRelease._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -164,21 +164,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.ReleaseDetails>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is ReleaseDetails otherReleaseDetails)
return _internal.Equals(otherReleaseDetails._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -920,21 +920,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Rom>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Rom otherRom)
return _internal.PartialEquals(otherRom._internal);
// Everything else fails
return false;
}
/// <summary>
/// Fill any missing size and hash information from another Rom
/// </summary>

View File

@@ -75,21 +75,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Sample>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Sample otherSample)
return _internal.Equals(otherSample._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -153,21 +153,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Serials>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Serials otherSerials)
return _internal.Equals(otherSerials._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -81,21 +81,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.SharedFeat>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is SharedFeat otherSharedFeat)
return _internal.Equals(otherSharedFeat._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -93,21 +93,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Slot>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Slot otherSlot)
return _internal.Equals(otherSlot._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -87,21 +87,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.SlotOption>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is SlotOption otherSlotOption)
return _internal.Equals(otherSlotOption._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -93,21 +93,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.SoftwareList>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is SoftwareList otherSoftwareList)
return _internal.Equals(otherSoftwareList._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -75,21 +75,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.Sound>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is Sound otherSound)
return _internal.Equals(otherSound._internal);
// Everything else fails
return false;
}
#endregion
}
}

View File

@@ -213,21 +213,6 @@ namespace SabreTools.Metadata.DatItems.Formats
return false;
}
/// <inheritdoc/>
public override bool Equals(DatItem<Data.Models.Metadata.SourceDetails>? other)
{
// If the other value is invalid
if (other is null)
return false;
// If the type matches
if (other is SourceDetails otherSourceDetails)
return _internal.Equals(otherSourceDetails._internal);
// Everything else fails
return false;
}
#endregion
}
}