SabreTools/SabreTools.Serialization
1
0
Fork 0
mirror of https://github.com/SabreTools/SabreTools.Serialization.git synced 2026-07-08 18:06:41 +00:00
Code Issues 56 Packages Projects Releases 20 Wiki Activity

Probably fix the MD5 bug in IS-CAB

Browse Source
This commit is contained in:
Matt Nadareski
2025-08-29 11:06:37 -04:00
parent 48765f1ae5
commit a13c837202
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
SabreTools.Serialization/Wrappers/InstallShieldCabinet.cs
View File

@@ -573,19 +573,19 @@ namespace SabreTools.Serialization.Wrappers
reader?.Dispose();
output?.Close();
// Failing the file has been disabled because for a subset of CABs the values don't seem to match
// TODO: Investigate what is causing this to fail and what data needs to be hashed
// Validate the data written, if required
if (MajorVersion >= 6)
{
string expectedMd5 = BitConverter.ToString(fileDescriptor.MD5!);
expectedMd5 = expectedMd5.ToLowerInvariant().Replace("-", string.Empty);
// // Validate the data written, if required
// if (HeaderList!.MajorVersion >= 6)
// {
// string? md5result = md5.CurrentHashString;
// if (md5result == null || md5result != BitConverter.ToString(fileDescriptor.MD5!))
// {
// Console.Error.WriteLine($"MD5 checksum failure for file {index} ({HeaderList.GetFileName(index)})");
// return false;
// }
// }
string? actualMd5 = md5.CurrentHashString;
if (actualMd5 == null || actualMd5 != expectedMd5)
{
Console.Error.WriteLine($"MD5 checksum failure for file {index} ({GetFileName(index)})");
return false;
}
}
return true;
}