Add try-catch on parsing extra zip fields, assuming it's safe to do so #23

New Issue

Closed

opened 2026-01-29 21:16:39 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:16:39 +00:00

Owner

Copy Link

Originally created by @HeroponRikiBestest on GitHub (Jan 29, 2026).

When extracting the embedded zip from within WorldwideSoccerManager2008_dd_setup_v802.exe, the PKZIP reader will throw an exception when reading the extra fields with obj.ExtraFields = ParseExtraFields(obj, extraBytes); at c15809dd72/SabreTools.Serialization/Readers/PKZIP.cs (L579) . When extracting with 7z or unzip, both of them note that there's a headers error, but continue extracting properly with no further issues. If I add an empty try-catch around the aforementioned line in the PKZIP reader, the entire zip will extract properly with no further issues in extractiontool as well. The fact that unzip and 7z both work in this case and don't bail out further leads me to believe that this is safe, but I admit that I'm not knowledgeable enough on pkzip to know that for sure.

Originally created by @HeroponRikiBestest on GitHub (Jan 29, 2026). When extracting the embedded zip from within WorldwideSoccerManager2008_dd_setup_v802.exe, the PKZIP reader will throw an exception when reading the extra fields with `obj.ExtraFields = ParseExtraFields(obj, extraBytes);` at https://github.com/SabreTools/SabreTools.Serialization/blob/c15809dd7275fce54748468c187c5258e2ac210c/SabreTools.Serialization/Readers/PKZIP.cs#L579 . When extracting with `7z` or `unzip`, both of them note that there's a headers error, but continue extracting properly with no further issues. If I add an empty try-catch around the aforementioned line in the PKZIP reader, the entire zip will extract properly with no further issues in extractiontool as well. The fact that unzip and 7z both work in this case and don't bail out further leads me to believe that this is safe, but I admit that I'm not knowledgeable enough on pkzip to know that for sure.

claunia closed this issue 2026-01-29 21:16:39 +00:00

claunia referenced this issue 2026-01-29 21:16:45 +00:00

[PR #23] [MERGED] Add Matroschka processing. #47

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

zlib-transition

rolling

2.2.1

2.2.0

2.1.0

2.0.2

2.0.1

2.0.0

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.3

1.4.2

1.4.1

1.4.0

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

Labels

Clear labels

pull-request

Mirrored from GitHub Pull Request

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#23