[PR #23] [MERGED] Add Matroschka processing. #47

New Issue

Closed

opened 2026-01-29 21:16:45 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:16:45 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/SabreTools.Serialization/pull/23
Author: @HeroponRikiBestest
Created: 9/16/2025
Status: ✅ Merged
Merged: 9/20/2025
Merged by: @mnadareski

Base: main ← Head: matroschka-changes

---

📝 Commits (10+)

• 56d8fc2 Made changes
• f651740 Temporary hack to not rely on models without significantly changing current code. Revert all of this with offset-based reading later.
• dee16a1 small fixes
• c3738a9 Store matroschka section as PE extension
• 24a24f8 Move extractor out of deserializer, remove weird hack
• cce09c9 Potential GA fix
• 254f26a More potential GA fixes.
• e4cc377 I have no idea why GA hits that error but not me
• 7bd1900 Giving up on GA for now
• 33112f9 fix locking issues

📊 Changes

5 files changed (+528 additions, -1 deletions)

View changed files

➕ SabreTools.Serialization/Deserializers/SecuROMMatroschkaPackage.cs (+149 -0)
📝 SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs (+18 -1)
📝 SabreTools.Serialization/Wrappers/PortableExecutable.cs (+117 -0)
➕ SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.Extraction.cs (+131 -0)
➕ SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.cs (+113 -0)

📄 Description

PR relies on updating models due to 978b6904db .

PR is marked as a draft for the moment until I can:

• Make and test changes to BOS
• Comb over this PR for formatting changes

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/SabreTools.Serialization/pull/23 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 9/16/2025 **Status:** ✅ Merged **Merged:** 9/20/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `main` ← **Head:** `matroschka-changes` --- ### 📝 Commits (10+) - [`56d8fc2`](https://github.com/SabreTools/SabreTools.Serialization/commit/56d8fc2ba29244e4df63e68c87df163dc6632e91) Made changes - [`f651740`](https://github.com/SabreTools/SabreTools.Serialization/commit/f651740fe1ab0c681bb90698c8e7e94b3c4832b9) Temporary hack to not rely on models without significantly changing current code. Revert all of this with offset-based reading later. - [`dee16a1`](https://github.com/SabreTools/SabreTools.Serialization/commit/dee16a1e7c62725ec9d837810723821db2472baa) small fixes - [`c3738a9`](https://github.com/SabreTools/SabreTools.Serialization/commit/c3738a9ccc2f21669f480936786508af6f53941b) Store matroschka section as PE extension - [`24a24f8`](https://github.com/SabreTools/SabreTools.Serialization/commit/24a24f8da4fd899f94d90d3f380ba27173f980e1) Move extractor out of deserializer, remove weird hack - [`cce09c9`](https://github.com/SabreTools/SabreTools.Serialization/commit/cce09c9af5ae5639b08c6932fdaeb3d6c3283844) Potential GA fix - [`254f26a`](https://github.com/SabreTools/SabreTools.Serialization/commit/254f26aebc8a7d37a60fb9dcdd6cde41cc87187f) More potential GA fixes. - [`e4cc377`](https://github.com/SabreTools/SabreTools.Serialization/commit/e4cc377d4e4f3e6f37ffcc1db54a5adb7c8ede63) I have no idea why GA hits that error but not me - [`7bd1900`](https://github.com/SabreTools/SabreTools.Serialization/commit/7bd19002b5ce33bd245aa95f66d703cfcb0fcde3) Giving up on GA for now - [`33112f9`](https://github.com/SabreTools/SabreTools.Serialization/commit/33112f90b1918e89f345c882137324edc7923551) fix locking issues ### 📊 Changes **5 files changed** (+528 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `SabreTools.Serialization/Deserializers/SecuROMMatroschkaPackage.cs` (+149 -0) 📝 `SabreTools.Serialization/Wrappers/PortableExecutable.Extraction.cs` (+18 -1) 📝 `SabreTools.Serialization/Wrappers/PortableExecutable.cs` (+117 -0) ➕ `SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.Extraction.cs` (+131 -0) ➕ `SabreTools.Serialization/Wrappers/SecuROMMatroschkaPackage.cs` (+113 -0) </details> ### 📄 Description PR relies on updating models due to https://github.com/SabreTools/SabreTools.Models/commit/978b6904db29ba750708fae524ad8e9e600bb599 . PR is marked as a draft for the moment until I can: - [ ] Make and test changes to BOS - [ ] Comb over this PR for formatting changes --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:16:45 +00:00

claunia closed this issue 2026-01-29 21:16:46 +00:00

claunia referenced this issue 2026-01-29 21:16:54 +00:00

[PR #47] [MERGED] Explicitly handle password-protected archives rather than repeatedly throwing exceptions #75

claunia referenced this issue 2026-01-29 21:16:55 +00:00

[PR #47] Explicitly handle password-protected archives rather than repeatedly throwing exceptions #80

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

zlib-transition

rolling

2.2.1

2.2.0

2.1.0

2.0.2

2.0.1

2.0.0

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.3

1.4.2

1.4.1

1.4.0

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

Labels

Clear labels

pull-request

Mirrored from GitHub Pull Request

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#47