[PR #47] [MERGED] Explicitly handle password-protected archives rather than repeatedly throwing exceptions #75

New Issue

Open

opened 2026-01-29 21:16:54 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:16:54 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/SabreTools.Serialization/pull/47
Author: @HeroponRikiBestest
Created: 12/1/2025
Status: ✅ Merged
Merged: 12/2/2025
Merged by: @mnadareski

Base: main ← Head: handle-password-protection

---

📝 Commits (4)

• a06825b Explicitly handle password-protected archives rather than repeatedly throwing exceptions
• fe6eff2 Fix logic error
• e939ee8 Continues
• 7d3cbca Remove bool

📊 Changes

3 files changed (+56 additions, -6 deletions)

View changed files

📝 SabreTools.Serialization/Wrappers/PKZIP.Extraction.cs (+8 -0)
📝 SabreTools.Serialization/Wrappers/RAR.Extraction.cs (+24 -3)
📝 SabreTools.Serialization/Wrappers/SevenZip.Extraction.cs (+24 -3)

📄 Description

At the moment, if running with debug enabled, if you attempt to use ExtractionTool (or BOS) on password-protected archives, it will repeatedly throw exceptions. This PR explicitly handles password-protected files/archives, both providing more accurate output (7z and rar would otherwise not output the actual issue at all) and also making the debug logs much cleaner.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/SabreTools.Serialization/pull/47 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 12/1/2025 **Status:** ✅ Merged **Merged:** 12/2/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `main` ← **Head:** `handle-password-protection` --- ### 📝 Commits (4) - [`a06825b`](https://github.com/SabreTools/SabreTools.Serialization/commit/a06825bd813939e4b126173284c10fd145f7fe95) Explicitly handle password-protected archives rather than repeatedly throwing exceptions - [`fe6eff2`](https://github.com/SabreTools/SabreTools.Serialization/commit/fe6eff2a01b0ca637f8b55af4cf482dfaca6f080) Fix logic error - [`e939ee8`](https://github.com/SabreTools/SabreTools.Serialization/commit/e939ee829df308c561e844946599059b2cecd339) Continues - [`7d3cbca`](https://github.com/SabreTools/SabreTools.Serialization/commit/7d3cbcae71718af4cb74f020ec1625a6dfee848d) Remove bool ### 📊 Changes **3 files changed** (+56 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `SabreTools.Serialization/Wrappers/PKZIP.Extraction.cs` (+8 -0) 📝 `SabreTools.Serialization/Wrappers/RAR.Extraction.cs` (+24 -3) 📝 `SabreTools.Serialization/Wrappers/SevenZip.Extraction.cs` (+24 -3) </details> ### 📄 Description At the moment, if running with debug enabled, if you attempt to use ExtractionTool (or BOS) on password-protected archives, it will repeatedly throw exceptions. This PR explicitly handles password-protected files/archives, both providing more accurate output (7z and rar would otherwise not output the actual issue at all) and also making the debug logs much cleaner. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:16:54 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

zlib-transition

rolling

2.2.1

2.2.0

2.1.0

2.0.2

2.0.1

2.0.0

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.3

1.4.2

1.4.1

1.4.0

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

Labels

Clear labels

pull-request

Mirrored from GitHub Pull Request

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#75