[PR #24] Temporary fix for solid archive detection until SharpCompress makes another release. #52

New Issue

Open

opened 2026-01-29 21:16:47 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:16:47 +00:00

Owner

Copy Link

Original Pull Request: https://github.com/SabreTools/SabreTools.Serialization/pull/24

State: closed
Merged: Yes

---

At present, the release of SharpCompress that Serialization uses is missing the fix for single-block solid archive detection that was pushed a month or so afterwards https://github.com/adamhathcock/sharpcompress/pull/924 . From my own observations, and the experiences of various MPF/BOS users, solid archives (especially solid 7Z archives) tend to only be one block, so this winds up being a pretty major issue, resulting in extraction more or less locking up anytime a 7z is encountered. I understand that this fix isn't the most elegant, but it doesn't actually waste that much time since it only needs to check for two file entries, and it will have a major positive impact on processing times, given the state of solid extraction without it is borderline unusable on large archives with many files.
This backports what I had done for the original commit ecd99b157d in the pull where this was first found https://github.com/SabreTools/BinaryObjectScanner/pull/375 .

**Original Pull Request:** https://github.com/SabreTools/SabreTools.Serialization/pull/24 **State:** closed **Merged:** Yes --- At present, the release of SharpCompress that Serialization uses is missing the fix for single-block solid archive detection that was pushed a month or so afterwards https://github.com/adamhathcock/sharpcompress/pull/924 . From my own observations, and the experiences of various MPF/BOS users, solid archives (especially solid 7Z archives) tend to only be one block, so this winds up being a pretty major issue, resulting in extraction more or less locking up anytime a 7z is encountered. I understand that this fix isn't the most elegant, but it doesn't actually waste that much time since it only needs to check for two file entries, and it will have a major positive impact on processing times, given the state of solid extraction without it is borderline unusable on large archives with many files. This backports what I had done for the original commit https://github.com/SabreTools/BinaryObjectScanner/pull/375/commits/ecd99b157db50c34cd0c91fa36ffde9f9c9b10e3 in the pull where this was first found https://github.com/SabreTools/BinaryObjectScanner/pull/375 .

claunia added the pull-request label 2026-01-29 21:16:47 +00:00

claunia referenced this issue 2026-01-29 21:16:56 +00:00

[PR #52] [MERGED] Fix mszip relying on exceptions #85

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

zlib-transition

rolling

2.2.1

2.2.0

2.1.0

2.0.2

2.0.1

2.0.0

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.3

1.4.2

1.4.1

1.4.0

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

Labels

Clear labels

pull-request

Mirrored from GitHub Pull Request

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#52