SabreTools/SabreTools.Serialization
1
0
Fork 0
mirror of https://github.com/SabreTools/SabreTools.Serialization.git synced 2026-02-03 21:30:35 +00:00
Code Issues 56 Packages Projects Releases 20 Wiki Activity

[PR #52] [MERGED] Fix mszip relying on exceptions #85

New Issue
Closed
opened 2026-01-29 21:16:56 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 21:16:56 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/SabreTools.Serialization/pull/52
Author: @HeroponRikiBestest
Created: 12/4/2025
Status: ✅ Merged
Merged: 1/5/2026
Merged by: @mnadareski

Base: main ← Head: bestest-mszip

📝 Commits (10+)

📊 Changes

3 files changed (+184 additions, -8 deletions)

View changed files

📝 SabreTools.Serialization/Readers/MicrosoftCabinet.cs (+4 -4)
📝 SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs (+76 -3)
📝 SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs (+104 -1)

📄 Description

Fixes https://github.com/SabreTools/SabreTools.Serialization/issues/44 with some major changes. I don't know enough about mszip to know if this is 100% safe. I also assume you'd want me to make some changes on this.

This PR also drastically reduces the amount of memory needed to perform extraction, which is still a significant issue for mszip extraction.

The memory usage is still somewhat large, but I'm unsure how to properly clear memory beyond hoping C#/dotnet does it for me. If you can provide some input there, memory usage should be able to finally be reduced to a normal size.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/SabreTools.Serialization/pull/52 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 12/4/2025 **Status:** ✅ Merged **Merged:** 1/5/2026 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `main` ← **Head:** `bestest-mszip` --- ### 📝 Commits (10+) - [`f51cfeb`](https://github.com/SabreTools/SabreTools.Serialization/commit/f51cfeb451b35a1c8dc2226090ed1681573dfae8) Better fix - [`4d2700a`](https://github.com/SabreTools/SabreTools.Serialization/commit/4d2700a137ac37ceba2f99c2fbc2d95a3334367d) initial - [`809aaca`](https://github.com/SabreTools/SabreTools.Serialization/commit/809aacacc71c996f91489d93f2067a0afb4deeca) Fixed - [`a4a5aa3`](https://github.com/SabreTools/SabreTools.Serialization/commit/a4a5aa34a16546614fdc46d566bc3773cf49ddbc) Move function to proper location, clear memory better - [`d559f73`](https://github.com/SabreTools/SabreTools.Serialization/commit/d559f735e7bb8b77cadd10ac5278a113655a5041) work so far - [`86fbfaa`](https://github.com/SabreTools/SabreTools.Serialization/commit/86fbfaa164b83bfce4163027053fa9cf7f041171) more - [`37c7cf0`](https://github.com/SabreTools/SabreTools.Serialization/commit/37c7cf04772935cc654fe870b72476f7c6ec328b) more work - [`109c746`](https://github.com/SabreTools/SabreTools.Serialization/commit/109c74677a36a7b3f346bf7e5a9027296446fab2) No more per file seeking - [`6613f82`](https://github.com/SabreTools/SabreTools.Serialization/commit/6613f82c69ef9002030dd0f7719c5445ab030fa1) Finished work for now. - [`4df3c8e`](https://github.com/SabreTools/SabreTools.Serialization/commit/4df3c8ecc69f6797849aeab1bcd0c2003b8cc468) First round of fixes. ### 📊 Changes **3 files changed** (+184 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `SabreTools.Serialization/Readers/MicrosoftCabinet.cs` (+4 -4) 📝 `SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs` (+76 -3) 📝 `SabreTools.Serialization/Wrappers/MicrosoftCabinet.cs` (+104 -1) </details> ### 📄 Description Fixes https://github.com/SabreTools/SabreTools.Serialization/issues/44 with some major changes. I don't know enough about mszip to know if this is 100% safe. I also assume you'd want me to make some changes on this. This PR also drastically reduces the amount of memory needed to perform extraction, which is still a significant issue for mszip extraction. The memory usage is still somewhat large, but I'm unsure how to properly clear memory beyond hoping C#/dotnet does it for me. If you can provide some input there, memory usage should be able to finally be reduced to a normal size. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 21:16:56 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#85
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?