[PR #48] [MERGED] Fix GCF extraction #76

New Issue

Open

opened 2026-01-29 21:16:54 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 21:16:54 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/SabreTools.Serialization/pull/48
Author: @HeroponRikiBestest
Created: 12/3/2025
Status: ✅ Merged
Merged: 12/4/2025
Merged by: @mnadareski

Base: main ← Head: fix-gcf

---

📝 Commits (1)

• ab3c4a1 Fix GCF extraction

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 SabreTools.Serialization/Readers/GCF.cs (+1 -1)

📄 Description

GCF extraction was broken with the big initialOffset change, commit cd7e6ff98d (diff-6cb108a7e2e3e65bf9d0a75be0f79619f0aff47f2a96a9828dd6f67d288057af)

GCF extraction previously read afterMapPosition = data.Position several times throughout the deserialization, to seek back to at relevant points. This commit changed some, but not all instances of afterMapPosition to initialOffset, resulting in a situation where the final offset reading went unused, and DataBlockHeader was being read from the previous offset.

Mainly detailing this since there's still a remaining inconsistency in usage of afterMapPosition vs initialOffset in the file, and initialOffset seems strange to use after, well, the initial offset.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/SabreTools.Serialization/pull/48 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 12/3/2025 **Status:** ✅ Merged **Merged:** 12/4/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `main` ← **Head:** `fix-gcf` --- ### 📝 Commits (1) - [`ab3c4a1`](https://github.com/SabreTools/SabreTools.Serialization/commit/ab3c4a17ef7f0be091a935593a994afd72c51d08) Fix GCF extraction ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `SabreTools.Serialization/Readers/GCF.cs` (+1 -1) </details> ### 📄 Description GCF extraction was broken with the big initialOffset change, commit https://github.com/SabreTools/SabreTools.Serialization/commit/cd7e6ff98d4f146e0674e8632c01ff761f95b61e#diff-6cb108a7e2e3e65bf9d0a75be0f79619f0aff47f2a96a9828dd6f67d288057af GCF extraction previously read `afterMapPosition = data.Position` several times throughout the deserialization, to seek back to at relevant points. This commit changed some, but not all instances of afterMapPosition to initialOffset, resulting in a situation where the final offset reading went unused, and DataBlockHeader was being read from the previous offset. Mainly detailing this since there's still a remaining inconsistency in usage of afterMapPosition vs initialOffset in the file, and initialOffset seems strange to use after, well, the initial offset. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 21:16:54 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

zlib-transition

rolling

2.2.1

2.2.0

2.1.0

2.0.2

2.0.1

2.0.0

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.3

1.4.2

1.4.1

1.4.0

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

Labels

Clear labels

pull-request

Mirrored from GitHub Pull Request

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#76