[PR #24] [MERGED] Temporary fix for solid archive detection until SharpCompress makes another release. #48

New Issue

claunia · 2026-01-29T21:16:46Z

claunia commented

2026-01-29 21:16:46 +00:00

📋 Pull Request Information

Original PR: https://github.com/SabreTools/SabreTools.Serialization/pull/24
Author: @HeroponRikiBestest
Created: 9/27/2025
Status: ✅ Merged
Merged: 9/27/2025
Merged by: @mnadareski

Base: main ← Head: solid-fix

📝 Commits (1)

997037d Temporary fix for solid archive detection until SharpCompress makes another release.

📊 Changes

2 files changed (+78 additions, -4 deletions)

View changed files

📝 SabreTools.Serialization/Wrappers/RAR.Extraction.cs (+39 -1)
📝 SabreTools.Serialization/Wrappers/SevenZip.Extraction.cs (+39 -3)

📄 Description

At present, the release of SharpCompress that Serialization uses is missing the fix for single-block solid archive detection that was pushed a month or so afterwards https://github.com/adamhathcock/sharpcompress/pull/924 . From my own observations, and the experiences of various MPF/BOS users, solid archives (especially solid 7Z archives) tend to only be one block, so this winds up being a pretty major issue, resulting in extraction more or less locking up anytime a 7z is encountered. I understand that this fix isn't the most elegant, but it doesn't actually waste that much time since it only needs to check for two file entries, and it will have a major positive impact on processing times, given the state of solid extraction without it is borderline unusable on large archives with many files.
This backports what I had done for the original commit ecd99b157d in the pull where this was first found https://github.com/SabreTools/BinaryObjectScanner/pull/375 .

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/SabreTools.Serialization/pull/24 **Author:** [@HeroponRikiBestest](https://github.com/HeroponRikiBestest) **Created:** 9/27/2025 **Status:** ✅ Merged **Merged:** 9/27/2025 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `main` ← **Head:** `solid-fix` --- ### 📝 Commits (1) - [`997037d`](https://github.com/SabreTools/SabreTools.Serialization/commit/997037d72c4ff8c1d68cc345a40a73787a2ddf18) Temporary fix for solid archive detection until SharpCompress makes another release. ### 📊 Changes **2 files changed** (+78 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `SabreTools.Serialization/Wrappers/RAR.Extraction.cs` (+39 -1) 📝 `SabreTools.Serialization/Wrappers/SevenZip.Extraction.cs` (+39 -3) </details> ### 📄 Description At present, the release of SharpCompress that Serialization uses is missing the fix for single-block solid archive detection that was pushed a month or so afterwards https://github.com/adamhathcock/sharpcompress/pull/924 . From my own observations, and the experiences of various MPF/BOS users, solid archives (especially solid 7Z archives) tend to only be one block, so this winds up being a pretty major issue, resulting in extraction more or less locking up anytime a 7z is encountered. I understand that this fix isn't the most elegant, but it doesn't actually waste that much time since it only needs to check for two file entries, and it will have a major positive impact on processing times, given the state of solid extraction without it is borderline unusable on large archives with many files. This backports what I had done for the original commit https://github.com/SabreTools/BinaryObjectScanner/pull/375/commits/ecd99b157db50c34cd0c91fa36ffde9f9c9b10e3 in the pull where this was first found https://github.com/SabreTools/BinaryObjectScanner/pull/375 . --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 21:16:46 +00:00

claunia referenced this issue

2026-01-29 21:16:54 +00:00

[PR #48] [MERGED] Fix GCF extraction #76

claunia referenced this issue

2026-01-29 21:16:55 +00:00

[PR #48] Fix GCF extraction #81

Sign in to join this conversation.