SabreTools/SabreTools.Serialization
1
0
Fork 0
mirror of https://github.com/SabreTools/SabreTools.Serialization.git synced 2026-02-03 21:30:35 +00:00
Code Issues 56 Packages Projects Releases 20 Wiki Activity

[PR #48] Fix GCF extraction #81

New Issue
Open
opened 2026-01-29 21:16:55 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 21:16:55 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/SabreTools/SabreTools.Serialization/pull/48

State: closed
Merged: Yes

GCF extraction was broken with the big initialOffset change, commit cd7e6ff98d (diff-6cb108a7e2e3e65bf9d0a75be0f79619f0aff47f2a96a9828dd6f67d288057af)

GCF extraction previously read afterMapPosition = data.Position several times throughout the deserialization, to seek back to at relevant points. This commit changed some, but not all instances of afterMapPosition to initialOffset, resulting in a situation where the final offset reading went unused, and DataBlockHeader was being read from the previous offset.

Mainly detailing this since there's still a remaining inconsistency in usage of afterMapPosition vs initialOffset in the file, and initialOffset seems strange to use after, well, the initial offset.

**Original Pull Request:** https://github.com/SabreTools/SabreTools.Serialization/pull/48 **State:** closed **Merged:** Yes --- GCF extraction was broken with the big initialOffset change, commit https://github.com/SabreTools/SabreTools.Serialization/commit/cd7e6ff98d4f146e0674e8632c01ff761f95b61e#diff-6cb108a7e2e3e65bf9d0a75be0f79619f0aff47f2a96a9828dd6f67d288057af GCF extraction previously read `afterMapPosition = data.Position` several times throughout the deserialization, to seek back to at relevant points. This commit changed some, but not all instances of afterMapPosition to initialOffset, resulting in a situation where the final offset reading went unused, and DataBlockHeader was being read from the previous offset. Mainly detailing this since there's still a remaining inconsistency in usage of afterMapPosition vs initialOffset in the file, and initialOffset seems strange to use after, well, the initial offset.
claunia added the pull-request label 2026-01-29 21:16:55 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/SabreTools.Serialization#81
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?