_use_idc and _use_idl have never been used in PDCurses, although the

values could be set by idlok() and idcok(). Nor do they make sense in
the PDCurses context. The only reason to consider retaining them is
compatibility -- HPUX, Solaris and Tru64 curses all have them. But
NCurses and BSD don't; and per the standard, the WINDOW struct should be
opaque, so it shouldn't matter. idlok() and idcok(), by contrast, must
be retained, although they do nothing.
This commit is contained in:
William McBrine
2006-03-25 00:30:36 +00:00
parent 842b829817
commit 723791050e
4 changed files with 4 additions and 17 deletions

View File

@@ -15,7 +15,7 @@
* See the file maintain.er for details of the current maintainer. *
************************************************************************/
/* $Id: curses.h,v 1.147 2006/03/25 00:11:47 wmcbrine Exp $ */
/* $Id: curses.h,v 1.148 2006/03/25 00:30:26 wmcbrine Exp $ */
/*----------------------------------------------------------------------*
* PDCurses *
@@ -576,8 +576,6 @@ typedef struct _win /* definition of a window */
bool _immed; /* immediate update flag */
bool _sync; /* synchronise window ancestors */
bool _use_keypad; /* flags keypad key mode active */
bool _use_idl; /* True if Ins/Del line can be used */
bool _use_idc; /* True if Ins/Del character can be used */
chtype **_y; /* pointer to line pointer array */
int *_firstch; /* first changed character in line */
int *_lastch; /* last changed character in line */

View File

@@ -31,7 +31,7 @@
#ifdef PDCDEBUG
const char *rcsid_outopts =
"$Id: outopts.c,v 1.19 2006/02/23 01:46:52 wmcbrine Exp $";
"$Id: outopts.c,v 1.20 2006/03/25 00:30:36 wmcbrine Exp $";
#endif
/*man-start**************************************************************
@@ -142,20 +142,12 @@ int idlok(WINDOW *win, bool bf)
{
PDC_LOG(("idlok() - called\n"));
if (win == (WINDOW *)NULL)
return ERR;
win->_use_idl = bf;
return OK;
}
void idcok(WINDOW *win, bool bf)
{
PDC_LOG(("idcok() - called\n"));
if (win != (WINDOW *)NULL)
win->_use_idc = bf;
}
void immedok(WINDOW *win, bool bf)

View File

@@ -24,7 +24,7 @@
#ifdef PDCDEBUG
const char *rcsid_PDCwin =
"$Id: pdcwin.c,v 1.32 2006/03/25 00:11:53 wmcbrine Exp $";
"$Id: pdcwin.c,v 1.33 2006/03/25 00:30:36 wmcbrine Exp $";
#endif
/*man-start**************************************************************
@@ -206,7 +206,6 @@ WINDOW * PDC_makenew(int num_lines, int num_columns, int begy, int begx)
win->_bkgd = ' '; /* wrs 4/10/93 -- initialize background to blank */
win->_tabsize = 8;
win->_clear = (bool) ((num_lines == LINES) && (num_columns == COLS));
win->_use_idc = TRUE;
win->_bmarg = num_lines - 1;
win->_parx = win->_pary = -1;

View File

@@ -47,7 +47,7 @@
#ifdef PDCDEBUG
const char *rcsid_window =
"$Id: window.c,v 1.25 2006/03/25 00:11:53 wmcbrine Exp $";
"$Id: window.c,v 1.26 2006/03/25 00:30:36 wmcbrine Exp $";
#endif
/*man-start**************************************************************
@@ -396,8 +396,6 @@ WINDOW *dupwin(WINDOW *win)
new->_scroll = win->_scroll;
new->_nodelay = win->_nodelay;
new->_use_keypad = win->_use_keypad;
new->_use_idl = win->_use_idl;
new->_use_idc = win->_use_idc;
new->_tmarg = win->_tmarg;
new->_bmarg = win->_bmarg;
new->_parx = win->_parx;