Annotate or remove unused elements.

Delegates.cs

@@ -30,6 +30,8 @@
 // Copyright © 2011-2023 Natalia Portillo
 // ****************************************************************************/
 
+// ReSharper disable UnusedType.Global
+
 namespace Aaru.CommonTypes;
 
 /// <summary>Initializes a progress indicator (e.g. makes a progress bar visible)</summary>

Enums/Nes.cs

@@ -1,5 +1,7 @@
 // ReSharper disable InconsistentNaming
 
+using System.Diagnostics.CodeAnalysis;
+
 namespace Aaru.CommonTypes.Enums;
 
 public enum NesConsoleType : byte
@@ -10,6 +12,7 @@ public enum NesConsoleType : byte
     Extended   = 3
 }
 
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public enum NesTimingMode : byte
 {
     RP2C02   = 0,
@@ -18,6 +21,7 @@ public enum NesTimingMode : byte
     UMC6527P = 3
 }
 
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public enum NesVsPpuType : byte
 {
     RP2C03B     = 0,
@@ -35,6 +39,7 @@ public enum NesVsPpuType : byte
     RC2C05_05   = 12
 }
 
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public enum NesVsHardwareType : byte
 {
     Normal          = 0,
@@ -46,6 +51,7 @@ public enum NesVsHardwareType : byte
     RaidOnBungeling = 6
 }
 
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public enum NesExtendedConsoleType : byte
 {
     Normal          = 0,
@@ -62,6 +68,7 @@ public enum NesExtendedConsoleType : byte
     UM6578          = 11
 }
 
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public enum NesDefaultExpansionDevice : byte
 {
     Unspecified                     = 0,

Extents/ExtentsByte.cs

@@ -38,12 +38,16 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 
 namespace Aaru.CommonTypes.Extents;
 
 /// <summary>Implements extents for <see cref="byte" /></summary>
-public class ExtentsByte
+[SuppressMessage("ReSharper", "UnusedType.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+public sealed class ExtentsByte
 {
     List<Tuple<byte, byte>> _backend;
 

Extents/ExtentsInt.cs

@@ -38,12 +38,16 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 
 namespace Aaru.CommonTypes.Extents;
 
 /// <summary>Implements extents for <see cref="int" /></summary>
-public class ExtentsInt
+[SuppressMessage("ReSharper", "UnusedType.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+public sealed class ExtentsInt
 {
     List<Tuple<int, int>> _backend;
 

Extents/ExtentsLong.cs

@@ -38,12 +38,15 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 
 namespace Aaru.CommonTypes.Extents;
 
 /// <summary>Implements extents for <see cref="long" /></summary>
-public class ExtentsLong
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
+public sealed class ExtentsLong
 {
     List<Tuple<long, long>> _backend;
 

Extents/ExtentsSByte.cs

@@ -38,12 +38,16 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 
 namespace Aaru.CommonTypes.Extents;
 
 /// <summary>Implements extents for <see cref="sbyte" /></summary>
-public class ExtentsSByte
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
+public sealed class ExtentsSByte
 {
     List<Tuple<sbyte, sbyte>> _backend;
 

Extents/ExtentsShort.cs

@@ -38,12 +38,16 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 
 namespace Aaru.CommonTypes.Extents;
 
 /// <summary>Implements extents for <see cref="short" /></summary>
-public class ExtentsShort
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
+public sealed class ExtentsShort
 {
     List<Tuple<short, short>> _backend;
 

Extents/ExtentsUInt.cs

@@ -38,12 +38,16 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 
 namespace Aaru.CommonTypes.Extents;
 
 /// <summary>Implements extents for <see cref="uint" /></summary>
-public class ExtentsUInt
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
+[SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+public sealed class ExtentsUInt
 {
     List<Tuple<uint, uint>> _backend;
 

Extents/ExtentsULong.cs

@@ -38,12 +38,16 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 
 namespace Aaru.CommonTypes.Extents;
 
 /// <summary>Implements extents for <see cref="ulong" /></summary>
-public class ExtentsULong
+[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "MemberCanBeInternal")]
+public sealed class ExtentsULong
 {
     List<Tuple<ulong, ulong>> _backend;
 

Extents/ExtentsUShort.cs

@@ -38,12 +38,16 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 
 namespace Aaru.CommonTypes.Extents;
 
 /// <summary>Implements extents for <see cref="ushort" /></summary>
-public class ExtentsUShort
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
+public sealed class ExtentsUShort
 {
     List<Tuple<ushort, ushort>> _backend;
 

Interfaces/IByteAddressableImage.cs

@@ -37,6 +37,7 @@
 // ****************************************************************************/
 
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using Aaru.CommonTypes.Enums;
 using Aaru.CommonTypes.Structs;
 
@@ -44,6 +45,11 @@ namespace Aaru.CommonTypes.Interfaces;
 
 /// <inheritdoc />
 /// <summary>Interface defining linear media (chips, game carts, etc) images</summary>
+[SuppressMessage("ReSharper", "UnusedParameter.Global")]
+[SuppressMessage("ReSharper", "UnusedMemberInSuper.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")]
+[SuppressMessage("ReSharper", "OutParameterValueIsAlwaysDiscarded.Global")]
 public interface IByteAddressableImage : IBaseWritableImage
 {
     /// <summary>Gets or sets the current position</summary>

Interfaces/IFilter.cs

@@ -37,6 +37,7 @@
 // ****************************************************************************/
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using Aaru.CommonTypes.Enums;
 
@@ -46,6 +47,9 @@ namespace Aaru.CommonTypes.Interfaces;
 ///     Defines a filter, that is, a transformation of the data from a file, like, for example, a compressor (e.g.
 ///     GZIP), or a container (e.g. AppleDouble)
 /// </summary>
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")]
+[SuppressMessage("ReSharper", "UnusedMemberInSuper.Global")]
 public interface IFilter
 {
     /// <summary>Descriptive name of the plugin</summary>

Interfaces/IFloppyImage.cs

@@ -36,6 +36,7 @@
 // Copyright © 2011-2023 Natalia Portillo
 // ****************************************************************************/
 
+using System.Diagnostics.CodeAnalysis;
 using Aaru.CommonTypes.Enums;
 using Aaru.CommonTypes.Structs;
 
@@ -48,6 +49,7 @@ namespace Aaru.CommonTypes.Interfaces;
 ///     interface is defined by <see cref="T:Aaru.CommonTypes.Interfaces.IMediaImage" />. All data returned by these
 ///     methods is already decoded from its corresponding bitstream.
 /// </summary>
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public interface IFloppyImage : IMediaImage
 {
     /// <summary>

Interfaces/IFluxImage.cs

@@ -36,12 +36,15 @@
 // Copyright © 2011-2023 Rebecca Wallander
 // ****************************************************************************/
 
+using System.Diagnostics.CodeAnalysis;
 using Aaru.CommonTypes.Enums;
 
 namespace Aaru.CommonTypes.Interfaces;
 
 /// <inheritdoc />
 /// <summary>Abstract class to implement flux reading plugins.</summary>
+[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")]
+[SuppressMessage("ReSharper", "UnusedMemberInSuper.Global")]
 public interface IFluxImage : IBaseImage
 {
     /// <summary>

Interfaces/IMediaGraph.cs

@@ -33,11 +33,14 @@
 // ****************************************************************************/
 
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 
 namespace Aaru.CommonTypes.Interfaces;
 
 /// <summary>Defines the interface to draw the dump or verification status of a media in a picture.</summary>
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedMemberInSuper.Global")]
 public interface IMediaGraph
 {
     /// <summary>Paints the specified sector in green</summary>

Interfaces/IOpticalMediaImage.cs

@@ -37,6 +37,7 @@
 // ****************************************************************************/
 
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using Aaru.CommonTypes.Enums;
 using Aaru.CommonTypes.Structs;
 
@@ -44,6 +45,9 @@ namespace Aaru.CommonTypes.Interfaces;
 
 /// <inheritdoc cref="IMediaImage" />
 /// <summary>Abstract class to implement disk image reading plugins.</summary>
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedMemberInSuper.Global")]
+[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")]
 public interface IOpticalMediaImage : IMediaImage, IPartitionableMediaImage, IVerifiableSectorsImage
 {
     /// <summary>Gets the disc track extents (start, length).</summary>

Interfaces/IPluginRegister.cs

@@ -38,10 +38,12 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 
 namespace Aaru.CommonTypes.Interfaces;
 
 /// <summary>Defines a register of all known plugins</summary>
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public interface IPluginRegister
 {
     /// <summary>Gets all checksum plugins</summary>

Interfaces/IReadOnlyFilesystem.cs

@@ -39,6 +39,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.Text;
 using Aaru.CommonTypes.AaruMetadata;
@@ -51,6 +52,9 @@ namespace Aaru.CommonTypes.Interfaces;
 
 /// <inheritdoc />
 /// <summary>Defines the interface to implement reading the contents of a filesystem</summary>
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")]
+[SuppressMessage("ReSharper", "UnusedMemberInSuper.Global")]
 public interface IReadOnlyFilesystem : IFilesystem
 {
     /// <summary>Information about the filesystem as expected by Aaru Metadata</summary>
@@ -179,6 +183,7 @@ public interface IReadOnlyFilesystem : IFilesystem
 }
 
 /// <summary>Represents an opened file from a filesystem</summary>
+[SuppressMessage("ReSharper", "UnusedMemberInSuper.Global")]
 public interface IFileNode
 {
     /// <summary>Path to the file</summary>
@@ -192,6 +197,7 @@ public interface IFileNode
 }
 
 /// <summary>Represents an opened directory from a filesystem</summary>
+[SuppressMessage("ReSharper", "UnusedMemberInSuper.Global")]
 public interface IDirNode
 {
     /// <summary>Path to the directory</summary>

Interfaces/IVerifiableSectorsImage.cs

@@ -38,10 +38,13 @@
 // ****************************************************************************/
 
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 
 namespace Aaru.CommonTypes.Interfaces;
 
 /// <summary>Defines an image that can verify the integrity of the sectors it contains</summary>
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")]
 public interface IVerifiableSectorsImage
 {
     /// <summary>Verifies a sector.</summary>

Interfaces/IWritableFloppyImage.cs

@@ -36,6 +36,7 @@
 // Copyright © 2011-2023 Natalia Portillo
 // ****************************************************************************/
 
+using System.Diagnostics.CodeAnalysis;
 using Aaru.CommonTypes.Enums;
 using Aaru.CommonTypes.Structs;
 
@@ -48,6 +49,7 @@ namespace Aaru.CommonTypes.Interfaces;
 ///     interface defined by <see cref="T:Aaru.CommonTypes.Interfaces.IMediaImage" />. All data expected by these methods
 ///     is already decoded from its corresponding bitstream.
 /// </summary>
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public interface IWritableFloppyImage : IFloppyImage, IWritableImage
 {
     /// <summary>

Interfaces/IWritableFluxImage.cs

@@ -36,12 +36,16 @@
 // Copyright © 2011-2023 Rebecca Wallander
 // ****************************************************************************/
 
+using System.Diagnostics.CodeAnalysis;
 using Aaru.CommonTypes.Enums;
 
 namespace Aaru.CommonTypes.Interfaces;
 
 /// <inheritdoc cref="IWritableImage" />
 /// <summary>Abstract class to implement flux writing plugins.</summary>
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
+[SuppressMessage("ReSharper", "UnusedParameter.Global")]
+[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")]
 public interface IWritableFluxImage : IFluxImage, IWritableImage
 {
     /// <summary>Writes a flux capture.</summary>

Interfaces/IWritableTapeImage.cs

@@ -37,12 +37,14 @@
 // Copyright © 2011-2023 Natalia Portillo
 // ****************************************************************************/
 
+using System.Diagnostics.CodeAnalysis;
 using Aaru.CommonTypes.Structs;
 
 namespace Aaru.CommonTypes.Interfaces;
 
 /// <inheritdoc cref="Aaru.CommonTypes.Interfaces.ITapeImage" />
 /// <summary>Defines an image that is writable and can store information about a streaming, digital, tape</summary>
+[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")]
 public interface IWritableTapeImage : ITapeImage, IWritableImage
 {
     /// <summary>Registers a new file in the image</summary>

Interop/DetectOS.cs

@@ -50,22 +50,13 @@ public static class DetectOS
     /// <summary>Are we running under Mono?</summary>
     public static readonly bool IsMono =
         RuntimeInformation.FrameworkDescription.StartsWith("Mono", StringComparison.Ordinal);
-    /// <summary>Are we running under .NET Framework?</summary>
-    public static readonly bool IsNetFramework =
-        RuntimeInformation.FrameworkDescription.StartsWith(".NET Framework", StringComparison.Ordinal);
     /// <summary>Are we running under .NET Core?</summary>
     public static readonly bool IsNetCore =
         RuntimeInformation.FrameworkDescription.StartsWith(".NET Core", StringComparison.Ordinal);
-    /// <summary>Are we running under .NET Native?</summary>
-    public static readonly bool IsNetNative =
-        RuntimeInformation.FrameworkDescription.StartsWith(".NET Native", StringComparison.Ordinal);
 
     /// <summary>Checks if the underlying runtime runs in 64-bit mode</summary>
     public static readonly bool Is64Bit = IntPtr.Size == 8;
 
-    /// <summary>Checks if the underlying runtime runs in 32-bit mode</summary>
-    public static readonly bool Is32Bit = IntPtr.Size == 4;
-
     /// <summary>Are we running under Windows?</summary>
     public static bool IsWindows => GetRealPlatformID() == PlatformID.Win32NT      ||
                                     GetRealPlatformID() == PlatformID.Win32S       ||

MediaTypeFromDevice/FromScsi.cs

@@ -68,7 +68,7 @@ public static partial class MediaTypeFromDevice
 
             // Sequential access device
             case 0x01:
-                return GetFromSsc(scsiPeripheralType, vendor, model, mediumType, densityCode, blocks, blockSize);
+                return GetFromSsc(vendor, model, mediumType, densityCode);
 
             // Write-once device
             case 0x04:

MediaTypeFromDevice/FromSsc.cs

@@ -40,16 +40,12 @@ namespace Aaru.CommonTypes;
 public static partial class MediaTypeFromDevice
 {
     /// <summary>Gets the media type from an SCSI Streaming Commands compliant device</summary>
-    /// <param name="scsiPeripheralType">Peripheral type</param>
     /// <param name="vendor">Vendor string</param>
     /// <param name="model">Model string</param>
     /// <param name="mediumType">Medium type from MODE SENSE</param>
     /// <param name="densityCode">Density code from MODE SENSE</param>
-    /// <param name="blocks">Number of blocks in media</param>
-    /// <param name="blockSize">Size of a block in bytes</param>
     /// <returns>Media type</returns>
-    public static MediaType GetFromSsc(byte scsiPeripheralType, string vendor, string model, byte mediumType,
-                                       byte densityCode,        ulong  blocks, uint   blockSize)
+    public static MediaType GetFromSsc(string vendor, string model, byte mediumType, byte densityCode)
     {
         switch(mediumType)
         {

Structs/Devices/SCSI/Enums.cs

@@ -35,6 +35,7 @@ using System.Diagnostics.CodeAnalysis;
 namespace Aaru.CommonTypes.Structs.Devices.SCSI;
 
 /// <summary>List of known SCSI peripheral qualifiers</summary>
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public enum PeripheralQualifiers : byte
 {
     /// <summary>Peripheral qualifier: Device is connected and supported</summary>

Structs/Devices/SCSI/Inquiry.cs

@@ -50,6 +50,7 @@ namespace Aaru.CommonTypes.Structs.Devices.SCSI;
 [SuppressMessage("ReSharper", "InconsistentNaming")]
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public struct Inquiry
 {
     const string MODULE_NAME = "SCSI INQUIRY decoder";

Structs/Devices/SCSI/Modes/2A.cs

@@ -47,6 +47,7 @@ namespace Aaru.CommonTypes.Structs.Devices.SCSI.Modes;
 [SuppressMessage("ReSharper", "MemberCanBeInternal")]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
 [SuppressMessage("ReSharper", "NotAccessedField.Global")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public class ModePage_2A
 {
     /// <summary>Write speed performance descriptors</summary>
@@ -214,6 +215,7 @@ public class ModePage_2A
     /// <summary>Database ID</summary>
     [JsonIgnore]
     [Key]
+    // ReSharper disable once UnusedMember.Global
     public int Id { get; set; }
 
     /// <summary>Decodes the page 2Ah of a MODE SENSE response</summary>

Structs/Filesystems.cs

@@ -38,6 +38,7 @@
 // ****************************************************************************/
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Runtime.InteropServices;
 using System.Text.Json.Serialization;
 
@@ -45,6 +46,7 @@ namespace Aaru.CommonTypes.Structs;
 
 /// <summary>File attributes.</summary>
 [Flags]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public enum FileAttributes : ulong
 {
     /// <summary>File has no attributes</summary>
@@ -241,6 +243,7 @@ public class FileEntryInfo
 }
 
 /// <summary>Information about a volume</summary>
+[SuppressMessage("ReSharper", "NotAccessedField.Global")]
 public class FileSystemInfo
 {
     /// <summary>Blocks for this filesystem</summary>

Structs/Images.cs

@@ -173,6 +173,7 @@ public class Track
 }
 
 /// <summary>Floppy physical characteristics structure.</summary>
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public struct FloppyInfo
 {
     /// <summary>Physical floppy type.</summary>