Annotate or remove unused elements.

Aaru.Devices/Device/AtaCommands/Ata28.cs

@@ -34,6 +34,8 @@ using System;
 using Aaru.Console;
 using Aaru.Decoders.ATA;
 
+// ReSharper disable UnusedMember.Global
+
 namespace Aaru.Devices;
 
 public partial class Device

Aaru.Devices/Device/AtaCommands/AtaCHS.cs

@@ -31,11 +31,16 @@
 // ****************************************************************************/
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 using Aaru.Console;
 using Aaru.Decoders.ATA;
 
+// ReSharper disable UnusedMember.Global
+
 namespace Aaru.Devices;
 
+[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")]
+[SuppressMessage("ReSharper", "OutParameterValueIsAlwaysDiscarded.Global")]
 public partial class Device
 {
     /// <summary>Sends the ATA IDENTIFY DEVICE command to the device, using default device timeout</summary>

Aaru.Devices/Device/AtaCommands/MCPT.cs

@@ -31,11 +31,17 @@
 // ****************************************************************************/
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 using Aaru.Console;
 using Aaru.Decoders.ATA;
 
+// ReSharper disable UnusedMember.Global
+
 namespace Aaru.Devices;
 
+[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")]
+[SuppressMessage("ReSharper", "OutParameterValueIsAlwaysDiscarded.Global")]
+[SuppressMessage("ReSharper", "MemberCanBeInternal")]
 public partial class Device
 {
     /// <summary>Enables media card pass through</summary>

Aaru.Devices/Device/MmcCommands/MMC.cs

@@ -33,6 +33,8 @@
 using System;
 using Aaru.Console;
 
+// ReSharper disable UnusedMember.Global
+
 namespace Aaru.Devices;
 
 public partial class Device

Aaru.Devices/Device/ScsiCommands/Adaptec.cs

@@ -34,6 +34,8 @@
 using System;
 using Aaru.Console;
 
+// ReSharper disable UnusedMember.Global
+
 namespace Aaru.Devices;
 
 public partial class Device

Aaru.Devices/Device/ScsiCommands/ArchiveCorp.cs

@@ -33,6 +33,8 @@
 using System;
 using Aaru.Console;
 
+// ReSharper disable UnusedMember.Global
+
 namespace Aaru.Devices;
 
 public partial class Device

Aaru.Devices/Device/ScsiCommands/HP.cs

@@ -32,6 +32,8 @@
 
 using Aaru.Console;
 
+// ReSharper disable UnusedMember.Global
+
 namespace Aaru.Devices;
 
 public partial class Device

Aaru.Devices/Device/ScsiCommands/MMC.cs

@@ -35,8 +35,11 @@ using System.Diagnostics.CodeAnalysis;
 using System.Text;
 using Aaru.Console;
 
+// ReSharper disable UnusedMember.Global
+
 namespace Aaru.Devices;
 
+[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")]
 public partial class Device
 {
     /// <summary>Sends the MMC GET CONFIGURATION command for all Features</summary>

Aaru.Devices/Device/ScsiCommands/MiniDisc.cs

@@ -35,6 +35,8 @@
 using System;
 using Aaru.Console;
 
+// ReSharper disable UnusedMember.Global
+
 namespace Aaru.Devices;
 
 public partial class Device

Aaru.Devices/Device/ScsiCommands/Plasmon.cs

@@ -32,6 +32,8 @@
 
 using Aaru.Console;
 
+// ReSharper disable UnusedMember.Global
+
 namespace Aaru.Devices;
 
 public partial class Device

Aaru.Devices/Device/ScsiCommands/SPC.cs

@@ -35,9 +35,12 @@ using System.Diagnostics.CodeAnalysis;
 using Aaru.Console;
 using PlatformID = Aaru.CommonTypes.Interop.PlatformID;
 
+// ReSharper disable UnusedMember.Global
+
 namespace Aaru.Devices;
 
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")]
 public partial class Device
 {
     /// <summary>Sends the SPC INQUIRY command to the device using default device timeout.</summary>

Aaru.Devices/Device/ScsiCommands/SSC.cs

@@ -31,10 +31,14 @@
 // ****************************************************************************/
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 using Aaru.Console;
 
+// ReSharper disable UnusedMember.Global
+
 namespace Aaru.Devices;
 
+[SuppressMessage("ReSharper", "UnusedMethodReturnValue.Global")]
 public partial class Device
 {
     /// <summary>Prepares the medium for reading</summary>

Aaru.Devices/Device/ScsiCommands/SyQuest.cs

@@ -33,6 +33,8 @@
 using System;
 using Aaru.Console;
 
+// ReSharper disable UnusedMember.Global
+
 namespace Aaru.Devices;
 
 public partial class Device

Aaru.Devices/Linux/Enums.cs

@@ -32,10 +32,12 @@
 // ****************************************************************************/
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 
 namespace Aaru.Devices.Linux;
 
 [Flags]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 enum FileFlags
 {
     /// <summary>O_RDONLY</summary>
@@ -89,6 +91,7 @@ enum ScsiIoctlDirection
     Unknown = -5
 }
 
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 enum LinuxIoctl : uint
 {
     // SCSI IOCtls
@@ -101,6 +104,7 @@ enum LinuxIoctl : uint
 }
 
 [Flags]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 enum SgInfo : uint
 {
     /// <summary>Mask to check OK</summary>
@@ -121,6 +125,7 @@ enum SgInfo : uint
 }
 
 [Flags]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 enum SgFlags : uint
 {
     DirectIo         = 1,
@@ -131,6 +136,7 @@ enum SgFlags : uint
     QAtHead          = 0x20
 }
 
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 enum SeekWhence
 {
     Begin   = 0,

Aaru.Devices/Linux/Extern.cs

@@ -43,9 +43,6 @@ static class Extern
     [DllImport("libc")]
     internal static extern int close(int fd);
 
-    [DllImport("libc", EntryPoint = "ioctl", SetLastError = true)]
-    internal static extern int ioctlInt(int fd, LinuxIoctl request, out int value);
-
     [DllImport("libc", EntryPoint = "ioctl", SetLastError = true)]
     internal static extern int ioctlSg(int fd, LinuxIoctl request, ref SgIoHdrT value);
 

Aaru.Devices/Remote/Device.cs

@@ -59,6 +59,7 @@ public sealed partial class Device : Devices.Device
     }
 
     /// <summary>Current device is remote</summary>
+    // ReSharper disable once UnusedMember.Global
     public bool IsRemote => _remote != null;
 
     /// <summary>Remote application</summary>

Aaru.Devices/Remote/Enums.cs

@@ -30,6 +30,8 @@
 // Copyright © 2011-2023 Natalia Portillo
 // ****************************************************************************/
 
+using System.Diagnostics.CodeAnalysis;
+
 namespace Aaru.Devices.Remote;
 
 /// <summary>Packet type enumeration</summary>
@@ -73,6 +75,7 @@ public enum AaruPacketType : sbyte
 }
 
 /// <summary>Reasons for non-data request or response</summary>
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 public enum AaruNopReason : byte
 {
     /// <summary>Request or response has arrived unexpectedly</summary>

Aaru.Devices/Windows/Extern.cs

@@ -32,11 +32,13 @@
 // ****************************************************************************/
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Runtime.InteropServices;
 using Microsoft.Win32.SafeHandles;
 
 namespace Aaru.Devices.Windows;
 
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 static class Extern
 {
     [DllImport("kernel32.dll", CharSet = CharSet.Auto, SetLastError = true)]

Aaru.Devices/Windows/Structs.cs

@@ -155,6 +155,7 @@ struct StoragePropertyQuery
 
 [StructLayout(LayoutKind.Sequential)]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 struct StorageDescriptorHeader
 {
     public uint Version;
@@ -206,6 +207,7 @@ struct StorageDeviceNumber
 
 [StructLayout(LayoutKind.Sequential)]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 struct DeviceInfoData
 {
     public int  cbSize;
@@ -237,6 +239,7 @@ struct UsbSetupPacket
 
 [StructLayout(LayoutKind.Sequential)]
 [SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
+[SuppressMessage("ReSharper", "UnusedType.Global")]
 struct UsbDescriptorRequest
 {
     public int ConnectionIndex;

Aaru.Devices/Windows/Usb.cs

@@ -44,6 +44,7 @@ namespace Aaru.Devices.Windows;
 /// <summary>Implements functions for getting and accessing information from the USB bus</summary>
 [SuppressMessage("ReSharper", "UnusedMember.Local")]
 [SuppressMessage("ReSharper", "UnusedType.Local")]
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 static partial class Usb
 {
     /// <summary>Return a list of USB Host Controllers</summary>

Aaru.Devices/Windows/UsbFunctions.cs

@@ -33,6 +33,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Runtime.InteropServices;
 
 namespace Aaru.Devices.Windows;
@@ -43,6 +44,7 @@ namespace Aaru.Devices.Windows;
 //
 // TODO: Even after cleaning, refactoring and xml-documenting, this code needs some love
 /// <summary>Implements functions for getting and accessing information from the USB bus</summary>
+[SuppressMessage("ReSharper", "UnusedMember.Global")]
 static partial class Usb
 {
     const          int    IOCTL_STORAGE_GET_DEVICE_NUMBER = 0x2D1080;