Annotate or remove unused elements.

This commit is contained in:
2023-10-05 01:05:23 +01:00
parent 7c9405492c
commit 9618e2c549
168 changed files with 397 additions and 216 deletions

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes.Interfaces;
using Aaru.DiscImages;
@@ -17,6 +18,7 @@ namespace Aaru.Tests.Issues;
// 20200311 CLAUNIA: Fixed in f4a1c28feabb50a43036944cf7f6c028eb6f8b93
// 20200621 CLAUNIA: Fixed in c80baa5efb4ea8a9e4347278086b2414469ae4c6
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _257 : OpticalImageConvertIssueTest
{
public override Dictionary<string, string> ParsedOptions => new();

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
namespace Aaru.Tests.Issues._263;
@@ -14,6 +15,7 @@ namespace Aaru.Tests.Issues._263;
*/
// 20200309 CLAUNIA: Fixed in 3b2bb0ebf0c6c615c5622aebff494ed34b51055d
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class AaruFormat : FsExtractIssueTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue263");

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
namespace Aaru.Tests.Issues._263;
@@ -14,6 +15,7 @@ namespace Aaru.Tests.Issues._263;
*/
// 20200309 CLAUNIA: Fixed in 3b2bb0ebf0c6c615c5622aebff494ed34b51055d
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class Raw : FsExtractIssueTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue263");

View File

@@ -1,6 +1,7 @@
// ReSharper disable StringLiteralTypo
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
namespace Aaru.Tests.Issues;
@@ -15,6 +16,7 @@ namespace Aaru.Tests.Issues;
*/
// 20200309 CLAUNIA: Fixed in 3b2bb0ebf0c6c615c5622aebff494ed34b51055d
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _266 : FsExtractHashIssueTest
{
protected override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue266");

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes.Interfaces;
using Aaru.DiscImages;
@@ -13,6 +14,7 @@ namespace Aaru.Tests.Issues;
// 20200309 CLAUNIA: Fixed in 21e81753cd106a52ee599281f0b977cda90484a7
// 20210307 CLAUNIA: Reopened.
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _286 : OpticalImageConvertIssueTest
{
public override Dictionary<string, string> ParsedOptions => new();

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes.Interfaces;
using Aaru.DiscImages;
@@ -11,6 +12,7 @@ namespace Aaru.Tests.Issues._288;
*/
// 20200309 CLAUNIA: Fixed in af0abca12d429276fc864e1de14a7a40f12bde26
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _18Wheeler : OpticalImageConvertIssueTest
{
public override Dictionary<string, string> ParsedOptions => new();

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes.Interfaces;
using Aaru.DiscImages;
@@ -11,6 +12,7 @@ namespace Aaru.Tests.Issues._288;
*/
// 20200309 CLAUNIA: Fixed in af0abca12d429276fc864e1de14a7a40f12bde26
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class ArcadeHits : OpticalImageConvertIssueTest
{
public override Dictionary<string, string> ParsedOptions => new();

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes.Interfaces;
using Aaru.DiscImages;
@@ -11,6 +12,7 @@ namespace Aaru.Tests.Issues._288;
*/
// 20200309 CLAUNIA: Fixed in af0abca12d429276fc864e1de14a7a40f12bde26
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class Roadsters : OpticalImageConvertIssueTest
{
public override Dictionary<string, string> ParsedOptions => new();

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes.Interfaces;
using Aaru.DiscImages;
@@ -11,6 +12,7 @@ namespace Aaru.Tests.Issues;
* http://dcevolution.sourceforge.net/index.php?id=house_of_terror can be converted to DICF.
*/
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _299 : OpticalImageConvertIssueTest
{
public override Dictionary<string, string> ParsedOptions => new();

View File

@@ -1,6 +1,7 @@
// ReSharper disable StringLiteralTypo
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
namespace Aaru.Tests.Issues;
@@ -19,6 +20,7 @@ namespace Aaru.Tests.Issues;
*/
// 20200309 CLAUNIA: Fixed in 48f067d79ff30cfd10e084085ff479bbb0939512
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _300 : FsExtractHashIssueTest
{
protected override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue300");

View File

@@ -1,6 +1,7 @@
// ReSharper disable StringLiteralTypo
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
namespace Aaru.Tests.Issues;
@@ -14,6 +15,7 @@ namespace Aaru.Tests.Issues;
*/
// 20200621 CLAUNIA: Fixed in 83a28237fab9e21b23bd43eb91b5b29f1bf9f220
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _358 : FsExtractHashIssueTest
{
protected override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue358");

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
namespace Aaru.Tests.Issues;
@@ -12,6 +13,7 @@ namespace Aaru.Tests.Issues;
// 20201107 CLAUNIA: Fixed in c45f1bff6d75a2e31b2b2d889455eefd3262b2cc
// 20210307 CLAUNIA: Reopened
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _360 : FsExtractIssueTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue360");

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes.Interfaces;
using Aaru.DiscImages;
@@ -15,6 +16,7 @@ namespace Aaru.Tests.Issues;
*/
// 20201103 CLAUNIA: Fixed in 532b2adddc900d8e4c61a6399d4da20a566d4876
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _379 : OpticalImageConvertIssueTest
{
public override Dictionary<string, string> ParsedOptions => new();

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes.Interfaces;
using Aaru.DiscImages;
@@ -14,6 +15,7 @@ namespace Aaru.Tests.Issues;
*/
// 20201104 CLAUNIA: Fixed in 7723fc2d0dbe0a6e6dc7b5cabc17f6798bb5eebb
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _398 : OpticalImageConvertIssueTest
{
public override Dictionary<string, string> ParsedOptions => new();

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
namespace Aaru.Tests.Issues;
@@ -19,6 +20,7 @@ namespace Aaru.Tests.Issues;
*/
// 20201106 CLAUNIA: Fixed in d30a6d18cd1f6d8b9075f096bd56e23fc5106dbf
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _410 : FsExtractIssueTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue410");

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
namespace Aaru.Tests.Issues;
@@ -19,6 +20,7 @@ namespace Aaru.Tests.Issues;
*/
// 20201106 CLAUNIA: Fixed in d30a6d18cd1f6d8b9075f096bd56e23fc5106dbf
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _411 : FsExtractIssueTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue411");

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
namespace Aaru.Tests.Issues;
@@ -11,6 +12,7 @@ namespace Aaru.Tests.Issues;
* "Error EINVAL reading file".
*/
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _441 : FsExtractIssueTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue441");

View File

@@ -1,3 +1,4 @@
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes;
using Aaru.CommonTypes.Interfaces;
@@ -6,6 +7,7 @@ using BlindWrite5 = Aaru.DiscImages.BlindWrite5;
namespace Aaru.Tests.Issues;
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _448 : OpticalMediaImageTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Pending", "issue448");

View File

@@ -1,3 +1,4 @@
using System.Diagnostics.CodeAnalysis;
using System.IO;
namespace Aaru.Tests.Issues;
@@ -7,6 +8,7 @@ namespace Aaru.Tests.Issues;
* Aaru doesn't support specific NRG (Version 1) image
*/
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _449 : OpticalImageReadIssueTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue449");

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes.Interfaces;
using Aaru.DiscImages;
@@ -10,6 +11,7 @@ namespace Aaru.Tests.Issues;
* Error converting NRG version 2 to other formats
*/
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _450 : OpticalImageConvertIssueTest
{
public override Dictionary<string, string> ParsedOptions => new();

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
namespace Aaru.Tests.Issues;
@@ -10,6 +11,7 @@ namespace Aaru.Tests.Issues;
* Trying to extract files from a CDTV image crashes with "Error reading file: Object reference not set to an instance of an object."
*/
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _495 : FsExtractIssueTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue495");

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
namespace Aaru.Tests.Issues;
@@ -11,6 +12,7 @@ namespace Aaru.Tests.Issues;
* "Error reading file: Object reference not set to an instance of an object.".
*/
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _531 : FsExtractIssueTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue531");

View File

@@ -1,6 +1,7 @@
// ReSharper disable StringLiteralTypo
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
namespace Aaru.Tests.Issues._542;
@@ -12,6 +13,7 @@ namespace Aaru.Tests.Issues._542;
* When extracting an image of a SafeDisc protected CD, most files aren't properly extracted.
*/
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class Sims : FsExtractHashIssueTest
{
protected override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue542", "sims");

View File

@@ -14,6 +14,7 @@ namespace Aaru.Tests.Issues._542;
*/
[SuppressMessage("ReSharper", "InconsistentNaming")]
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class SimsEP : FsExtractHashIssueTest
{
protected override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue542", "exp");

View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.IO;
namespace Aaru.Tests.Issues;
@@ -10,6 +11,7 @@ namespace Aaru.Tests.Issues;
* When performing file extraction, the following exception is raised
*/
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _584 : FsExtractIssueTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue584");

View File

@@ -14,6 +14,7 @@ namespace Aaru.Tests.Issues._590;
*/
[SuppressMessage("ReSharper", "InconsistentNaming")]
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class asus_driver_gpu_tweak_v1231_2014 : FsExtractHashIssueTest
{
protected override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue590",

View File

@@ -14,6 +14,7 @@ namespace Aaru.Tests.Issues._590;
*/
[SuppressMessage("ReSharper", "InconsistentNaming")]
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class m5a99fx : FsExtractHashIssueTest
{
protected override string DataFolder =>

View File

@@ -14,6 +14,7 @@ namespace Aaru.Tests.Issues._590;
*/
[SuppressMessage("ReSharper", "InconsistentNaming")]
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class win3 : FsExtractHashIssueTest
{
protected override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue590", "win3");

View File

@@ -1,3 +1,4 @@
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes;
using Aaru.CommonTypes.Interfaces;
@@ -6,6 +7,7 @@ using Aaru.Tests.WritableImages;
namespace Aaru.Tests.Issues;
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _623 : WritableOpticalMediaImageTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue623");

View File

@@ -1,3 +1,4 @@
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes;
using Aaru.CommonTypes.Interfaces;
@@ -6,6 +7,7 @@ using Aaru.Tests.WritableImages;
namespace Aaru.Tests.Issues;
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _624 : WritableOpticalMediaImageTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Pending", "issue624");

View File

@@ -1,3 +1,4 @@
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes;
using Aaru.CommonTypes.Interfaces;
@@ -6,6 +7,7 @@ using Aaru.Tests.WritableImages;
namespace Aaru.Tests.Issues;
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class _625 : WritableOpticalMediaImageTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Issues", "Fixed", "issue625");

View File

@@ -111,7 +111,6 @@ public class VolumeData
public class BlockPartitionVolumes
{
public ulong Length;
public ulong Start;
public VolumeData[] Volumes;
public ulong Length;
public ulong Start;
}

View File

@@ -1,9 +1,11 @@
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes;
using Aaru.CommonTypes.Interfaces;
namespace Aaru.Tests.WritableImages.AaruFormat.V1;
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class FromAaru : WritableOpticalMediaImageTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Media image formats", "AaruFormat", "V1");

View File

@@ -1,3 +1,4 @@
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes;
using Aaru.CommonTypes.Interfaces;
@@ -5,6 +6,7 @@ using Aaru.DiscImages;
namespace Aaru.Tests.WritableImages.Alcohol;
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class FromAaru : WritableOpticalMediaImageTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Media image formats", "AaruFormat", "V1");

View File

@@ -1,3 +1,4 @@
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes;
using Aaru.CommonTypes.Interfaces;
@@ -5,6 +6,7 @@ using Aaru.DiscImages;
namespace Aaru.Tests.WritableImages.CDRDAO;
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class FromAaru : WritableOpticalMediaImageTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Media image formats", "AaruFormat", "V1");

View File

@@ -1,3 +1,4 @@
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes;
using Aaru.CommonTypes.Interfaces;
@@ -5,6 +6,7 @@ using Aaru.DiscImages;
namespace Aaru.Tests.WritableImages.CDRWin;
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class FromAaru : WritableOpticalMediaImageTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Media image formats", "AaruFormat", "V1");

View File

@@ -1,3 +1,4 @@
using System.Diagnostics.CodeAnalysis;
using System.IO;
using Aaru.CommonTypes;
using Aaru.CommonTypes.Interfaces;
@@ -5,6 +6,7 @@ using Aaru.DiscImages;
namespace Aaru.Tests.WritableImages.CloneCD;
[SuppressMessage("ReSharper", "UnusedType.Global")]
public class FromAaru : WritableOpticalMediaImageTest
{
public override string DataFolder => Path.Combine(Consts.TestFilesRoot, "Media image formats", "AaruFormat", "V1");