aaru-dps/RedBookPlayer
1
0
Fork 0
mirror of https://github.com/aaru-dps/RedBookPlayer.git synced 2026-02-08 13:34:54 +00:00
Code Issues 41 Packages Projects Releases Wiki Activity

[PR #5] [MERGED] Broad organizational and bug-fix changes #54

New Issue
Open
opened 2026-01-30 21:23:12 +00:00 by claunia · 0 comments
claunia commented 2026-01-30 21:23:12 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/aaru-dps/RedBookPlayer/pull/5
Author: @mnadareski
Created: 6/7/2021
Status: ✅ Merged
Merged: 6/21/2021
Merged by: @claunia

Base: devel ← Head: sweeper

📝 Commits (10+)

  • 8316c69 Organize solution file into folders
  • e79b571 Add new settings
  • 13ba103 Add class comment for DeEmphasisFilter
  • f27f455 Comment and split HiResTimer
  • b30107a Comment MainWindow, make some code safer
  • 3e77067 Separate out PlayerSource (nw)
  • 30eab90 Separate out TrackTypeValue
  • edae3a7 Separate out PlayerViewModel (nw)
  • 3847160 Player additions and cleanup
  • 9ffabff Fix build on Windows

📊 Changes

13 files changed (+1139 additions, -564 deletions)

View changed files

📝 RedBookPlayer.sln (+100 -77)
📝 RedBookPlayer/DeEmphasisFilter.cs (+9 -6)
📝 RedBookPlayer/HiResTimer.cs (+15 -19)
➕ RedBookPlayer/HiResTimerElapsedEventArgs.cs (+11 -0)
📝 RedBookPlayer/MainWindow.xaml.cs (+13 -10)
📝 RedBookPlayer/Player.cs (+611 -229)
➕ RedBookPlayer/PlayerSource.cs (+44 -0)
📝 RedBookPlayer/PlayerView.xaml.cs (+209 -192)
➕ RedBookPlayer/PlayerViewModel.cs (+49 -0)
📝 RedBookPlayer/Program.cs (+4 -1)
📝 RedBookPlayer/Settings.cs (+50 -10)
📝 RedBookPlayer/SettingsWindow.xaml (+8 -0)
📝 RedBookPlayer/SettingsWindow.xaml.cs (+16 -20)

📄 Description

This PR encompasses multiple pieces that bring the code to a much more usable and stable state

  • The solution file includes folders for organization
  • Most classes and methods now have XML comments on them
  • Methods have been organized into regions, where appopriate
  • Classes all live in their own files
  • Two new settings added: 1) Play data tracks as audio, and 2) Generate TOC if one does not exist
  • General stability and usability improvements to the Player class

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aaru-dps/RedBookPlayer/pull/5 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 6/7/2021 **Status:** ✅ Merged **Merged:** 6/21/2021 **Merged by:** [@claunia](https://github.com/claunia) **Base:** `devel` ← **Head:** `sweeper` --- ### 📝 Commits (10+) - [`8316c69`](https://github.com/aaru-dps/RedBookPlayer/commit/8316c6982f1ccf28d79319f101fbcc8605c6879c) Organize solution file into folders - [`e79b571`](https://github.com/aaru-dps/RedBookPlayer/commit/e79b5719cab64ffd5cc514cdd4aec27be98f2b34) Add new settings - [`13ba103`](https://github.com/aaru-dps/RedBookPlayer/commit/13ba103a6442e4ed7f5427a2a77294c561804349) Add class comment for DeEmphasisFilter - [`f27f455`](https://github.com/aaru-dps/RedBookPlayer/commit/f27f455d85766d9a1bf2a64fa5c53e1ac3c85ae1) Comment and split HiResTimer - [`b30107a`](https://github.com/aaru-dps/RedBookPlayer/commit/b30107a9c5bb4056112c38f842513373ae68d906) Comment MainWindow, make some code safer - [`3e77067`](https://github.com/aaru-dps/RedBookPlayer/commit/3e770677ab66b2209c5ea0d3e973018cc0f266e8) Separate out PlayerSource (nw) - [`30eab90`](https://github.com/aaru-dps/RedBookPlayer/commit/30eab90dfb0616de1480a96f8841bb46739d2270) Separate out TrackTypeValue - [`edae3a7`](https://github.com/aaru-dps/RedBookPlayer/commit/edae3a7a58db29f5cf57e58bfecd6c5d6234b398) Separate out PlayerViewModel (nw) - [`3847160`](https://github.com/aaru-dps/RedBookPlayer/commit/384716090d59b199f720c4259ddae6d3e79b9da6) Player additions and cleanup - [`9ffabff`](https://github.com/aaru-dps/RedBookPlayer/commit/9ffabff7bde584b30a5db3dd2a6b85226c81cf66) Fix build on Windows ### 📊 Changes **13 files changed** (+1139 additions, -564 deletions) <details> <summary>View changed files</summary> 📝 `RedBookPlayer.sln` (+100 -77) 📝 `RedBookPlayer/DeEmphasisFilter.cs` (+9 -6) 📝 `RedBookPlayer/HiResTimer.cs` (+15 -19) ➕ `RedBookPlayer/HiResTimerElapsedEventArgs.cs` (+11 -0) 📝 `RedBookPlayer/MainWindow.xaml.cs` (+13 -10) 📝 `RedBookPlayer/Player.cs` (+611 -229) ➕ `RedBookPlayer/PlayerSource.cs` (+44 -0) 📝 `RedBookPlayer/PlayerView.xaml.cs` (+209 -192) ➕ `RedBookPlayer/PlayerViewModel.cs` (+49 -0) 📝 `RedBookPlayer/Program.cs` (+4 -1) 📝 `RedBookPlayer/Settings.cs` (+50 -10) 📝 `RedBookPlayer/SettingsWindow.xaml` (+8 -0) 📝 `RedBookPlayer/SettingsWindow.xaml.cs` (+16 -20) </details> ### 📄 Description This PR encompasses multiple pieces that bring the code to a much more usable and stable state - The solution file includes folders for organization - Most classes and methods now have XML comments on them - Methods have been organized into regions, where appopriate - Classes all live in their own files - Two new settings added: 1) Play data tracks as audio, and 2) Generate TOC if one does not exist - General stability and usability improvements to the Player class --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-30 21:23:12 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aaru-dps/RedBookPlayer#54
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?