aaru-dps/RedBookPlayer
1
0
Fork 0
mirror of https://github.com/aaru-dps/RedBookPlayer.git synced 2026-02-14 13:35:36 +00:00
Code Issues 41 Packages Projects Releases Wiki Activity

[PR #54] [MERGED] Add CD+G Framework #69

New Issue
Open
opened 2026-01-30 21:23:16 +00:00 by claunia · 0 comments
claunia commented 2026-01-30 21:23:16 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/aaru-dps/RedBookPlayer/pull/54
Author: @mnadareski
Created: 12/1/2021
Status: ✅ Merged
Merged: 9/7/2022
Merged by: @claunia

Base: devel ← Head: cdg-basis

📝 Commits (9)

  • 34d985d Subchannel interpretation code (nw)
  • 78ef6d8 Rework subchannel helper methods
  • 15b39e8 Add currently-unused karaoke display internally
  • 3e44c11 Start wiring up some CD+G instructions
  • 1880d49 Add most of scrolling logic; add notes
  • 52ecacb Implement color table loading
  • a72d79a Re-implement scrolling with offsets this time
  • 2ab1be8 Add debug print for KaraokeDisplay
  • 2efd0fa Address review comments

📊 Changes

9 files changed (+711 additions, -18 deletions)

View changed files

📝 RedBookPlayer.Models/Enums.cs (+73 -0)
➕ RedBookPlayer.Models/Hardware/Karaoke/BorderPreset.cs (+26 -0)
➕ RedBookPlayer.Models/Hardware/Karaoke/KaraokeDisplay.cs (+360 -0)
➕ RedBookPlayer.Models/Hardware/Karaoke/LoadCLUT.cs (+23 -0)
➕ RedBookPlayer.Models/Hardware/Karaoke/MemPreset.cs (+30 -0)
➕ RedBookPlayer.Models/Hardware/Karaoke/Scroll.cs (+42 -0)
➕ RedBookPlayer.Models/Hardware/Karaoke/TileBlock.cs (+38 -0)
📝 RedBookPlayer.Models/Hardware/Player.cs (+96 -16)
📝 RedBookPlayer.Models/Hardware/SubchannelPacket.cs (+23 -2)

📄 Description

This PR adds most of the core functionality that will be needed for proper CD+G support in the future. There are some known issues with this code, such as requiring every subchannel to exist for this to work.

None of the code here is hooked up to any of the existing UI or player functionality and should not cause any issues for normal users.

Related issue: #8

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aaru-dps/RedBookPlayer/pull/54 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 12/1/2021 **Status:** ✅ Merged **Merged:** 9/7/2022 **Merged by:** [@claunia](https://github.com/claunia) **Base:** `devel` ← **Head:** `cdg-basis` --- ### 📝 Commits (9) - [`34d985d`](https://github.com/aaru-dps/RedBookPlayer/commit/34d985d4819954fbb43560b7a5c00e0b2fde1632) Subchannel interpretation code (nw) - [`78ef6d8`](https://github.com/aaru-dps/RedBookPlayer/commit/78ef6d8511b9054b5d7a127c934e59b88548c8a3) Rework subchannel helper methods - [`15b39e8`](https://github.com/aaru-dps/RedBookPlayer/commit/15b39e8cfffd1402ae1eeca4152fcef92adb17d7) Add currently-unused karaoke display internally - [`3e44c11`](https://github.com/aaru-dps/RedBookPlayer/commit/3e44c115029f92ee8c566b88f0d5c1cfb2a54c4b) Start wiring up some CD+G instructions - [`1880d49`](https://github.com/aaru-dps/RedBookPlayer/commit/1880d49ee573fe906b1bc50195e47978690a0b8e) Add most of scrolling logic; add notes - [`52ecacb`](https://github.com/aaru-dps/RedBookPlayer/commit/52ecacba7c0e9cd8cbce8b8fcb273e181fe4c3c4) Implement color table loading - [`a72d79a`](https://github.com/aaru-dps/RedBookPlayer/commit/a72d79a438f1a432fffa211430540f8a21d5bb36) Re-implement scrolling with offsets this time - [`2ab1be8`](https://github.com/aaru-dps/RedBookPlayer/commit/2ab1be864da2e1b8021991f2186bc6268c78dc4d) Add debug print for KaraokeDisplay - [`2efd0fa`](https://github.com/aaru-dps/RedBookPlayer/commit/2efd0fa40c24136fdeb675dbb83606848ff19b30) Address review comments ### 📊 Changes **9 files changed** (+711 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `RedBookPlayer.Models/Enums.cs` (+73 -0) ➕ `RedBookPlayer.Models/Hardware/Karaoke/BorderPreset.cs` (+26 -0) ➕ `RedBookPlayer.Models/Hardware/Karaoke/KaraokeDisplay.cs` (+360 -0) ➕ `RedBookPlayer.Models/Hardware/Karaoke/LoadCLUT.cs` (+23 -0) ➕ `RedBookPlayer.Models/Hardware/Karaoke/MemPreset.cs` (+30 -0) ➕ `RedBookPlayer.Models/Hardware/Karaoke/Scroll.cs` (+42 -0) ➕ `RedBookPlayer.Models/Hardware/Karaoke/TileBlock.cs` (+38 -0) 📝 `RedBookPlayer.Models/Hardware/Player.cs` (+96 -16) 📝 `RedBookPlayer.Models/Hardware/SubchannelPacket.cs` (+23 -2) </details> ### 📄 Description This PR adds most of the core functionality that will be needed for proper CD+G support in the future. There are some known issues with this code, such as requiring every subchannel to exist for this to work. None of the code here is hooked up to any of the existing UI or player functionality and should not cause any issues for normal users. Related issue: #8 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-30 21:23:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aaru-dps/RedBookPlayer#69
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?