Merge pull request #5738 from Dizzy611/disable-updater-on-emubuildnum-0

Disable VM Manager updater on EMU_BUILD_NUM == 0 (local/GHA builds).

src/qt/qt_vmmanager_main.cpp

@@ -456,6 +456,7 @@ VMManagerMain::onPreferencesUpdated()
 void
 VMManagerMain::backgroundUpdateCheckStart() const
 {
+#if EMU_BUILD_NUM != 0
     auto updateChannel = UpdateCheck::UpdateChannel::CI;
 #ifdef RELEASE_BUILD
     updateChannel = UpdateCheck::UpdateChannel::Stable;
@@ -464,6 +465,7 @@ VMManagerMain::backgroundUpdateCheckStart() const
     connect(updateCheck, &UpdateCheck::updateCheckComplete, this, &VMManagerMain::backgroundUpdateCheckComplete);
     connect(updateCheck, &UpdateCheck::updateCheckError, this, &VMManagerMain::backgroundUpdateCheckError);
     updateCheck->checkForUpdates();
+#endif
 }
 
 void

src/qt/qt_vmmanager_mainwindow.cpp

@@ -48,8 +48,13 @@ VMManagerMainWindow(QWidget *parent)
     connect(ui->actionNew_Machine, &QAction::triggered, vmm, &VMManagerMain::newMachineWizard);
 
     // Set up menu actions
-    connect(ui->actionCheck_for_updates, &QAction::triggered, this, &VMManagerMainWindow::checkForUpdatesTriggered);
-
+    // (Disable this if the EMU_BUILD_NUM == 0)
+    #if EMU_BUILD_NUM == 0
+        ui->actionCheck_for_updates->setVisible(false);
+    #else
+        connect(ui->actionCheck_for_updates, &QAction::triggered, this, &VMManagerMainWindow::checkForUpdatesTriggered);
+    #endif
+    
     // TODO: Remove all of this (all the way to END REMOVE) once certain the search will no longer be in the toolbar.
     // BEGIN REMOVE
     // Everything is still setup here for it but it is all hidden. None of it will be