claunia/86Box
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qt: Get rid of most uses of QString::asprintf()

Browse Source 
Now that the Win32 UI is out of the way, we can rewrite the strings to use
QString::arg() instead and avoid even more QString ↔ C string conversions
This commit is contained in:
Alexander Babikov
2025-04-10 04:34:37 +05:00
parent cc01d7c3b8
commit 5ff206e493
27 changed files with 487 additions and 492 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/qt/qt_harddiskdialog.cpp
View File

@@ -77,8 +77,7 @@ HarddiskDialog::HarddiskDialog(bool existing, QWidget *parent)
for (int i = 0; i < 127; i++) {
uint64_t size = ((uint64_t) hdd_table[i][0]) * hdd_table[i][1] * hdd_table[i][2];
uint32_t size_mb = size >> 11LL;
// QString text = QString("%1 MiB (CHS: %2, %3, %4)").arg(size_mb).arg(hdd_table[i][0]).arg(hdd_table[i][1]).arg(hdd_table[i][2]);
QString text = QString::asprintf(tr("%u MB (CHS: %i, %i, %i)").toUtf8().constData(), size_mb, (hdd_table[i][0]), (hdd_table[i][1]), (hdd_table[i][2]));
QString text = tr("%1 MB (CHS: %2, %3, %4)").arg(size_mb).arg(hdd_table[i][0]).arg(hdd_table[i][1]).arg(hdd_table[i][2]);
Models::AddEntry(model, text, i);
}
Models::AddEntry(model, tr("Custom..."), 127);