mirror of
https://github.com/claunia/flac.git
synced 2025-12-16 18:54:26 +00:00
Fix pkg-config files to avoid overlinking
Libraries that are used internally by libFLAC(++) but are not part of their API should be listed in pkg-config "private" clauses. Otherwise executables that are linked dynamically against libFLAC(++) will have unneeded direct dependencies (overlinking). Based on a patch by Brad Smith from https://sourceforge.net/p/flac/bugs/397/ that I updated to only include ogg if libFLAC is actually built with ogg support. Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
This commit is contained in:
committed by
Erik de Castro Lopo
parent
805ffdb6eb
commit
5da86630be
@@ -308,9 +308,11 @@ fi
|
||||
AM_CONDITIONAL(FLaC__HAS_OGG, [test "x$have_ogg" = xyes])
|
||||
if test "x$have_ogg" = xyes ; then
|
||||
AC_DEFINE_UNQUOTED([FLAC__HAS_OGG],1,[define if you have the ogg library])
|
||||
OGG_PACKAGE="ogg"
|
||||
else
|
||||
AC_DEFINE_UNQUOTED([FLAC__HAS_OGG],0)
|
||||
fi
|
||||
AC_SUBST(OGG_PACKAGE)
|
||||
|
||||
dnl check for i18n(internationalization); these are from libiconv/gettext
|
||||
AM_ICONV
|
||||
|
||||
@@ -6,6 +6,6 @@ includedir=@includedir@
|
||||
Name: FLAC++
|
||||
Description: Free Lossless Audio Codec Library (C++ API)
|
||||
Version: @VERSION@
|
||||
Requires: flac
|
||||
Libs: -L${libdir} -lFLAC++ @OGG_LIBS@ -lm
|
||||
Requires.private: flac
|
||||
Libs: -L${libdir} -lFLAC++
|
||||
Cflags: -I${includedir}
|
||||
|
||||
@@ -6,5 +6,7 @@ includedir=@includedir@
|
||||
Name: FLAC
|
||||
Description: Free Lossless Audio Codec Library
|
||||
Version: @VERSION@
|
||||
Libs: -L${libdir} -lFLAC @OGG_LIBS@ -lm
|
||||
Requires.private: @OGG_PACKAGE@
|
||||
Libs: -L${libdir} -lFLAC
|
||||
Libs.private: -lm
|
||||
Cflags: -I${includedir}
|
||||
|
||||
Reference in New Issue
Block a user