claunia/libcdio-osx
Archived
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

The type of (option) opt needs to be int not char and this is

Browse Source 
noticable on ppc where char is unsigned by default.

Furthermore, poptGetNextOpt() returns an int, not a char.

Bug noticed and patch all thanks to Nicolas Boullis.
This commit is contained in:
rocky
2005-09-18 20:34:02 +00:00
parent 901ab06722
commit e8721c1e4e
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/cd-info.c
View File

@@ -1,5 +1,5 @@
/* /*
$Id: cd-info.c,v 1.143 2005/09/15 06:36:01 rocky Exp $ $Id: cd-info.c,v 1.144 2005/09/18 20:34:02 rocky Exp $
Copyright (C) 2003, 2004, 2005 Rocky Bernstein <rocky@panix.com> Copyright (C) 2003, 2004, 2005 Rocky Bernstein <rocky@panix.com>
Copyright (C) 1996, 1997, 1998 Gerd Knorr <kraxel@bytesex.org> Copyright (C) 1996, 1997, 1998 Gerd Knorr <kraxel@bytesex.org>
@@ -115,7 +115,7 @@ char *temp_str;
static bool static bool
parse_options (int argc, const char *argv[]) parse_options (int argc, const char *argv[])
{ {
char opt; /* used for argument parsing */ int opt; /* used for argument parsing */
char *psz_my_source; char *psz_my_source;
struct poptOption optionsTable[] = { struct poptOption optionsTable[] = {

4
src/cd-read.c
View File

@@ -1,5 +1,5 @@
/* /*
$Id: cd-read.c,v 1.24 2005/02/19 11:43:05 rocky Exp $ $Id: cd-read.c,v 1.25 2005/09/18 20:34:02 rocky Exp $
Copyright (C) 2003, 2004, 2005 Rocky Bernstein <rocky@panix.com> Copyright (C) 2003, 2004, 2005 Rocky Bernstein <rocky@panix.com>
@@ -178,7 +178,7 @@ static bool
parse_options (int argc, const char *argv[]) parse_options (int argc, const char *argv[])
{ {
char opt; int opt;
char *psz_my_source; char *psz_my_source;
char *opt_arg; char *opt_arg;