claunia/qemudb
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Pass $iTestingId into Version::display() instead of reading it from $_REQUEST. We don't want

Browse Source 
classes to depend on $_REQUEST if possible
This commit is contained in:
Chris Morgan
2006-07-08 22:10:56 +00:00
committed by WineHQ
parent 763ad58bcf
commit 07e2dab8f8
2 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
appview.php
View File

@@ -33,6 +33,7 @@ $aClean['iAppId'] = makeSafe($_REQUEST['iAppId']);
$aClean['iVersionId'] = makeSafe($_REQUEST['iVersionId']); $aClean['iVersionId'] = makeSafe($_REQUEST['iVersionId']);
$aClean['sSub'] = makeSafe($_REQUEST['sSub']); $aClean['sSub'] = makeSafe($_REQUEST['sSub']);
$aClean['iBuglinkId'] = makeSafe($_REQUEST['iBuglinkId']); $aClean['iBuglinkId'] = makeSafe($_REQUEST['iBuglinkId']);
$aClean['iTestingId'] = makeSafe($_REQUEST['iTestingId']);
$oApp = new Application($aClean['iAppId']); $oApp = new Application($aClean['iAppId']);
$oVersion = new Version($aClean['iVersionId']); $oVersion = new Version($aClean['iVersionId']);
@@ -157,7 +158,7 @@ if($aClean['iAppId'])
} else if($aClean['iVersionId']) // We want to see a particular version. } else if($aClean['iVersionId']) // We want to see a particular version.
{ {
$oVersion = new Version($aClean['iVersionId']); $oVersion = new Version($aClean['iVersionId']);
$oVersion->display(); $oVersion->display($aClean['iTestingId']);
} else } else
{ {
// Oops! Called with no params, bad llamah! // Oops! Called with no params, bad llamah!

8
include/version.php
View File

@@ -603,12 +603,8 @@ class Version {
$this->sTestedRelease = $aValues['sMaintainerRelease']; $this->sTestedRelease = $aValues['sMaintainerRelease'];
} }
function display() function display($iTestingId)
{ {
$aClean = array(); //array of filtered user input
$aClean['iTestingId'] = makeSafe($_REQUEST['iTestingId']);
/* is this user supposed to view this version? */ /* is this user supposed to view this version? */
if(!$_SESSION['current']->canViewVersion($this)) if(!$_SESSION['current']->canViewVersion($this))
util_show_error_page_and_exit("Something went wrong with the application or version id"); util_show_error_page_and_exit("Something went wrong with the application or version id");
@@ -786,7 +782,7 @@ class Version {
echo $this->sDescription; echo $this->sDescription;
// Show testing data // Show testing data
$oTest = new TestData($aClean['iTestingId']); $oTest = new TestData($iTestingId);
$iCurrentTest = $oTest->ShowTestResult($oTest->iTestingId, $this->iVersionId); $iCurrentTest = $oTest->ShowTestResult($oTest->iTestingId, $this->iVersionId);
if($iCurrentTest) if($iCurrentTest)
{ {