Confusion between sAction=view and sAction=display broke viewing/displaying items. Standardize on sAction=view until we can come up with a more robust way of ensuring the same issue doesn't happen again.

appview.php

@@ -22,7 +22,7 @@ if(isset($aClean['iAppId']) || isset($aClean['iVersionId'])) // Valid args
         $oObject = new Version($aClean['iVersionId']);
 
     // header
-    apidb_header($oObject->objectGetCustomTitle("display"));
+    apidb_header($oObject->objectGetCustomTitle("view"));
 
     if(isset($aClean['iVersionId']))
         $oObject->display($aClean);

include/application.php

@@ -670,7 +670,7 @@ class Application {
     {
         switch($sAction)
         {
-            case "display":
+            case "view":
                 return "Viewing App: ".$this->sName;
 
             default:

include/objectManager.php

@@ -794,7 +794,7 @@ class ObjectManager
 
         $oObject = new $this->sClass($this->iId);
 
-        $aVars = $this->get_custom_vars($aClean, "display");
+        $aVars = $this->get_custom_vars($aClean, "view");
 
         if(!$aVars)
             $oObject->display();

include/version.php

@@ -724,7 +724,7 @@ class version {
     {
         switch($sAction)
         {
-            case "display":
+            case "view":
                 return "Viewing App: ".version::fullName($this->iVersionId);
 
             default:
@@ -736,7 +736,7 @@ class version {
     {
         switch($sAction)
         {
-            case "display":
+            case "view":
                 /* Allow the user to select which test report is
                    shown in the version view */
                 return array("iTestingId");

objectManager.php

@@ -85,7 +85,7 @@ $sAction = $aClean['sAction'];
 if(!$sAction)
 {
     if($oObject->iId)
-        $sAction = "display";
+        $sAction = "view";
 }
 
 apidb_header($oObject->get_title($sAction));
@@ -111,7 +111,7 @@ if($oObject->iId && $sAction != "add")
         $oObject->delete_prompt();
         break;
 
-        case "display":
+        case "view":
         $oObject->view($_SERVER['REQUEST_URI'], $aClean);
         break;
     }