Commit Graph

142 Commits

Author SHA1 Message Date
Alexander Nicolaysen Sørnes
729df377f9 application: Fix ordering of entries by id 2007-10-24 21:18:17 -04:00
Alexander Nicolaysen Sørnes
fcd40be8a4 add objectManager::error_exit() and use it in application::display() 2007-10-24 21:17:10 -04:00
Alexander Nicolaysen Sørnes
fb13cd7c13 Support previewing applications 2007-10-23 19:29:21 -04:00
Alexander Nicolaysen Sørnes
fe56884a98 Prevent ids from disappearing during form processing 2007-10-22 19:28:03 -04:00
Alexander Nicolaysen Sørnes
bbe286a16f application: Fix permissions 2007-09-27 09:21:49 -04:00
Chris Morgan
09466f59a1 Minor code formatting changes for clarity. 2007-09-24 22:08:22 -04:00
Chris Morgan
a6f76eb892 Confusion between sAction=view and sAction=display broke viewing/displaying items. Standardize on sAction=view until we can come up with a more robust way of ensuring the same issue doesn't happen again. 2007-09-24 21:35:35 -04:00
Chris Morgan
fafcbce1bd Add more php5 scope keywords to class methods. 2007-09-24 21:11:49 -04:00
Alexander Nicolaysen Sørnes
e5d1bc1bf0 Use objectManager to submit super maintainer requests 2007-09-20 21:29:57 -04:00
Alexander Nicolaysen Sørnes
af87e89535 Use objectManager to display applications 2007-09-19 20:38:34 -04:00
Chris Morgan
607b130577 Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Show the versions for an app if they have the same queue status.

Instead of checking whether the version is un-queued, check if it has the same
status as the application.  This is needed to allow users to edit a queued
application they have submitted.
Modify the function name to reflect the change.
2007-09-14 23:45:51 -04:00
Chris Morgan
def14310d5 Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Improve vendor help in the application editor. Fix the help to reflect the vendor/application state.
2007-09-14 23:42:51 -04:00
Chris Morgan
e963bbdfda Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Remove the vendor from keywords hack. There are no longer any entries with this data in the application queues.
2007-09-14 23:41:02 -04:00
Chris Morgan
2827e0654e Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Let objectManager handle deletion and delete notification.
2007-09-14 23:02:12 -04:00
Alexander Nicolaysen Sørnes
d2a53b510c Allow marking versions as obsolete 2007-09-08 22:52:00 +00:00
Alexander Nicolaysen Sørnes
4d65a32e17 Only show the 'add entry' link if the class has enabled it. The link is only useful for classes
that have no parent objects. The objectShowAddEntry() method is not required because it only
affects the user interface.
2007-09-08 22:42:34 +00:00
Alexander Nicolaysen Sørnes
5a4cbf49a3 Add and use objectGetChildren() method. Add support for initializing comment class from SQL
result.
2007-09-08 22:38:20 +00:00
Chris Morgan
eef14ea6cc application::create() should return false upon failure 2007-08-04 02:02:04 +00:00
Chris Morgan
6119246b51 Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Chris Morgan
b94a2a392b Convert from timestamp to datetime. Datetime is consistent between mysql 4.0x and newer
versions and is faster for date/time computations. Modify object creation methods to specify
any time fields that were previously updated with timestamp properties.
2007-07-31 23:48:22 +00:00
Chris Morgan
0e3472e1bf objectGetHeader() should return a TableRow instance as this is closer to what the information
represents and is a much more useful form.
2007-07-31 01:51:40 +00:00
Alexander Nicolaysen Sørnes
09107d7142 Use multipage controls for application lists 2007-07-28 20:08:50 +00:00
Chris Morgan
19f6cbc156 Unit test cleanups. Fixes tests so they don't leave left over entries in the database. Add a
check to ensure that row counts in most tables are unchanged from the start and end of the
tests. Refactor some code.
2007-07-26 03:47:34 +00:00
Edwin Smulders
023ece493b Eliminate some php notices caused by use of uninitialized variables 2007-07-24 01:45:19 +00:00
Chris Morgan
2652e68d01 Programmatic table support. Enhances several tables with highlightable and clickable rows and
cleans up the existing table row highlight and click code.
2007-07-23 19:56:43 +00:00
Chris Morgan
62bfb16016 Make objectGetTableRow() return a TableRow class instance. Added accessors to set the
appropriate parameters in the TableRow class. Removed some unused parameters from the TableRow
class.
2007-07-02 00:35:17 +00:00
Chris Morgan
a41b65c25e Remove duplicate and unused sDate variables from application and version classes 2007-06-16 04:55:34 +00:00
Alexander Nicolaysen Sørnes
ca8e4f56df Fix admin response in submitter notifications. Some code was in the wrong place inside of a
switch statement
2007-06-14 00:52:57 +00:00
Alexander Nicolaysen Sørnes
cd198f44d7 Replace objectOutputTableRow() with objectGetTableRow(). Redesign the table output mechanism so
that we fetch a table row from a class instead of letting the class display it. Move adding of
edit/delete links from the classes to the objectManager. Fix a hole in the distribution class
where an uninitialized variable could have been used in the constructor.
2007-06-14 00:50:35 +00:00
Chris Morgan
0838b838a3 Prepend "http://" in front of urls that lack "://". Most urls tend to be websites and adding
http:// where it is missing fixes a bunch of urls in the database
2007-06-10 23:58:11 +00:00
Alexander Nicolaysen Sørnes
f7b24fab9a Object constructors shouldn't require an id if passed a $oRow object. Gets rid of
objectGetInstanceFromRow() since we can pass the row into the constructor instead.
2007-06-10 18:51:33 +00:00
Ben Hodgetts (Enverex)
8a030a2806 Add more specifics about what is required on the application submission page. Changes the
wording so hopefully people won't keep adding comments about how well the application works in
the application or vrsion submission. Also adds comments about proper grammar and punctuation.
2007-06-10 01:30:28 +00:00
Alexander Nicolaysen Sørnes
b71bf8bd01 Sort applications by id 2007-06-10 00:27:54 +00:00
Chris Morgan
25edd78c73 Layout improvements. Change default inner padding for html_frame_start() from 5 to 0, this
lets us eliminate the white spacing between frames and their contents. Add in a
div.default_container class that has a 5px padding to replace the now not present default
spacing.
2007-05-02 01:08:22 +00:00
Alexander Nicolaysen Sørnes
11ecfa230b Add allowAnonymousSubmissions(). objectManager checks the return value of this new function and
exists with an error during certain actions if the user is not logged in and the function returns
false
2007-04-29 23:00:01 +00:00
Alexander Nicolaysen Sørnes
b11cce6711 Use objectManager to submit and process applications. Remove now unused appsubmit.php
admin/adminAppQueue.php
2007-04-24 23:48:14 +00:00
Chris Morgan
886cdeafa3 Clean up the layout of the version and application pages and add some css classes to define
the formatting
2007-04-23 02:33:19 +00:00
Alexander Nicolaysen Sørnes
3dc453112a Use objectManager to list a user's rejected apps 2007-04-22 00:02:30 +00:00
Alexander Nicolaysen Sørnes
1107fb938b Add and use application::mustBeQueued() 2007-04-21 17:51:42 +00:00
Alexander Nicolaysen Sørnes
c43563eca6 Fix testData::create() permissions. Separate the cases where a user has edit rights from
when he has the right to unqueue items
2007-04-19 23:45:15 +00:00
Alexander Nicolaysen Sørnes
a309317347 Fix url::canEdit() to not call undefined functions 2007-04-16 22:59:48 +00:00
Alexander Nicolaysen Sørnes
20ebe74913 Use absolute path in application::objectMakeUrl(), otherwise mail links won't work 2007-04-09 01:24:34 +00:00
Alexander Nicolaysen Sørnes
89535dbe01 Use objectMakeLink()/Url() in more places 2007-04-03 02:08:44 +00:00
Alexander Nicolaysen Sørnes
2d9f73340d Add and use application::objectGetEntriesCount() 2007-04-03 00:00:48 +00:00
Alexander Nicolaysen Sørnes
6194da096e Use objectMakeLink() to list maintainers 2007-03-31 17:25:12 +00:00
Alexander Nicolaysen Sørnes
fa3872b256 Add user::objectMakeLink(), used by appData and testData objectOutputTableRow() 2007-03-25 16:03:35 +00:00
Alexander Nicolaysen Sørnes
f3eb9ffa01 Add more links in application::objectOutputTableRow(), now vendors and users are clickable 2007-03-25 03:51:20 +00:00
Alexander Nicolaysen Sørnes
c545581571 objectManager, add rejection support. Add support in objectManager for handling rejected
data.
2007-03-24 18:30:16 +00:00
Alexander Nicolaysen Sørnes
7d6772b5b1 Test more classes with objectManager 2007-03-24 02:04:16 +00:00
Alexander Nicolaysen Sørnes
f4c5077094 Let objectManager show the application queue 2007-03-17 23:45:54 +00:00