Commit Graph

1106 Commits

Author SHA1 Message Date
Alexander Nicolaysen Sørnes
982dc97756 Always read input first in downloadurl::outputEditorSingle(). Makes sure changes aren't lost
when reloading the form due to input errors
2007-04-24 23:38:41 +00:00
Alexander Nicolaysen Sørnes
74425f0b5a Fix TableVE::make_option_list's where handling to prevent sql injection 2007-04-24 23:36:10 +00:00
Alexander Nicolaysen Sørnes
d6bf700f00 Remove testResults.php, the file is unused 2007-04-24 00:37:36 +00:00
Alexander Nicolaysen Sørnes
f688be7c4d Support silent input checking. checkOutputEditorInput() can now return TRUE instead of a
list of errors
2007-04-24 00:35:51 +00:00
Alexander Nicolaysen Sørnes
d03359ed2e Warn user when pressing the vote button without selecting a slot 2007-04-24 00:22:36 +00:00
Alexander Nicolaysen Sørnes
43fa6617d4 Prevent display of \n in version view that was caused by a typo 2007-04-23 23:40:41 +00:00
Alexander Nicolaysen Sørnes
6bf507d6aa Fix a case where the admins would see the wrong help text when submitting new testData. Add
borders around the distribution form to match the rest of the editor
2007-04-23 23:39:44 +00:00
Alexander Nicolaysen Sørnes
42ecaf6eef Fix typo in testData::update() causing the new release info to be absent from the mail sent 2007-04-23 23:38:30 +00:00
Alexander Nicolaysen Sørnes
9b4bb81aec Fix bug link creation email. We only need to fetch the link id so remove the other code that
was resulting in missing values.
2007-04-23 23:37:30 +00:00
Alexander Nicolaysen Sørnes
fa050164f7 Add debug option to output e-mail on screen. Useful for testing that mails look correct. 2007-04-23 23:36:32 +00:00
Alexander Nicolaysen Sørnes
b18a91cca7 Fix typo in monitor creation preventing the userid value from being saved 2007-04-23 23:33:47 +00:00
Alexander Nicolaysen Sørnes
a5492e199a Add vendor->sQueued class variable. Not currently used but adding it keeps the vendor class
consistent with other classes.
2007-04-23 23:32:30 +00:00
Alexander Nicolaysen Sørnes
cf81d542ee Add a moveChildren method to the objectManager and implement objectMoveChildren for version
and version_queue. Use this to move versions.
2007-04-23 23:31:24 +00:00
Chris Morgan
886cdeafa3 Clean up the layout of the version and application pages and add some css classes to define
the formatting
2007-04-23 02:33:19 +00:00
Alexander Nicolaysen Sørnes
6b265f46fe State what was changed in the e-mail when testData is updated 2007-04-22 19:38:48 +00:00
Alexander Nicolaysen Sørnes
a84d8899de Fix appData::mustBeQueued() 2007-04-22 16:17:36 +00:00
Alexander Nicolaysen Sørnes
fb4db22141 Fix testData/version::mustBeQueued() 2007-04-22 16:15:12 +00:00
Chris Morgan
00aacdeadd Fix some inconsistent braces and add a comment to the objectManager code 2007-04-22 15:52:06 +00:00
Chris Morgan
af465791f7 Work around bug where submitting versions resulted in testData not being properly queued 2007-04-22 05:21:12 +00:00
Chris Morgan
e83b9b2d58 Fix test result issue with incorrect name causing an error when 'Limit to 5 tests' was
selected
2007-04-22 04:23:57 +00:00
Alexander Nicolaysen Sørnes
2a7d8e8c3f Support vendor queuing 2007-04-22 00:57:41 +00:00
Alexander Nicolaysen Sørnes
8cf53f1679 Use mustBeQueued() to determine unqueueing in objectManager 2007-04-22 00:39:53 +00:00
Alexander Nicolaysen Sørnes
3dc453112a Use objectManager to list a user's rejected apps 2007-04-22 00:02:30 +00:00
Alexander Nicolaysen Sørnes
b292a84bcf Use version::mustBeQueued() instead of user function 2007-04-21 19:50:52 +00:00
Alexander Nicolaysen Sørnes
995076af3b Fix warnings in downloadurl::processForm(). Calling this method with inappropriate $aClean[]
data is perfectly valid but in tht case the function should return silently
2007-04-21 19:46:17 +00:00
Alexander Nicolaysen Sørnes
8093a81da2 Display user manager link in the contact form 2007-04-21 19:45:12 +00:00
Alexander Nicolaysen Sørnes
2af11e7333 Remove user::deleteAppData() and replace it with an appData function 2007-04-21 19:44:10 +00:00
Alexander Nicolaysen Sørnes
59d97b676d Display user name in the maintainer approval form 2007-04-21 18:23:11 +00:00
Alexander Nicolaysen Sørnes
19d1393fe5 Fix testData_queue's distribution handling. Only update the distribution if the name is set
and avoid a misguiding message by not doing unQueue() on already unqueued distributions.
2007-04-21 18:22:14 +00:00
Alexander Nicolaysen Sørnes
33ee8c4458 Repalce '"' with '&quot;' in the distribution form. Otherwise we end up with broken <input>
fields
2007-04-21 18:09:13 +00:00
Alexander Nicolaysen Sørnes
be52279bfa Fix comment creation. addcomment.php was passing a filled-in object to comment::create()
which still expected values as parameters. Load data from the object instead
2007-04-21 18:05:32 +00:00
Alexander Nicolaysen Sørnes
bea4e89c56 Only display move test table for existing versions, not queued ones 2007-04-21 18:03:25 +00:00
Alexander Nicolaysen Sørnes
8358a09a13 Use objectManager to display a user's rejected versions 2007-04-21 18:00:46 +00:00
Alexander Nicolaysen Sørnes
2e0831cd22 Redirect to version-queue after moving tests. admin/adminAppQueue.php should redirect to
'version_queue' instead of 'version'
2007-04-21 17:55:33 +00:00
Alexander Nicolaysen Sørnes
1107fb938b Add and use application::mustBeQueued() 2007-04-21 17:51:42 +00:00
Alexander Nicolaysen Sørnes
208033d788 Add and use distribution::mustBeQueued() 2007-04-21 17:50:44 +00:00
Alexander Nicolaysen Sørnes
3ab921cf0d Add appData/screenshot::mustBeQueued() 2007-04-21 17:49:43 +00:00
Alexander Nicolaysen Sørnes
a6127c1b07 Rename user::count() to objectGetEntriesCount() for consistency with the other generic
object methods
2007-04-21 17:06:50 +00:00
Alexander Nicolaysen Sørnes
27e0589a77 Remove unused appData functions from the user class 2007-04-21 17:05:54 +00:00
Alexander Nicolaysen Sørnes
171a8c01c4 Include <a> links for menu items. This is necessary for browsers without JavaScript and it
makes it possible to see the url the link is pointing to
2007-04-21 16:54:17 +00:00
Chris Morgan
cf9cba4093 Objects should set class variables and call create() instead of passing the parameters into the
create() function.
2007-04-21 02:30:22 +00:00
Alexander Nicolaysen Sørnes
96bfe05734 Display move test results table when processing a version 2007-04-21 01:20:43 +00:00
Chris Morgan
434de30b9c Correct a few undefined variable errors brought out by the unit tests 2007-04-21 01:17:38 +00:00
Alexander Nicolaysen Sørnes
d5aabe4d17 More fixes and uses for objectManager's version/testData queues 2007-04-21 01:02:10 +00:00
Alexander Nicolaysen Sørnes
dad5de17b1 Test version/testData queues. Test version_queue and testData_queue with the objectManager
tests
2007-04-21 00:58:08 +00:00
Alexander Nicolaysen Sørnes
a8a4da643b Make testData's objectGetEntries more consistent for rejected testData. Don't allow
maintainers to view rejected entries for the versions they maintain, but show them their own
rejected entries instead
2007-04-20 00:02:20 +00:00
Alexander Nicolaysen Sørnes
67f61bbda5 Delete admin/resubmitRejectedApps.php, this file is no longer used 2007-04-19 23:53:28 +00:00
Alexander Nicolaysen Sørnes
4adcb4ad85 Highlight maintained apps/versions in the menu 2007-04-19 23:51:23 +00:00
Alexander Nicolaysen Sørnes
e176c0a9c7 Only show un-queued distributions in the testData list 2007-04-19 23:48:23 +00:00
Alexander Nicolaysen Sørnes
c43563eca6 Fix testData::create() permissions. Separate the cases where a user has edit rights from
when he has the right to unqueue items
2007-04-19 23:45:15 +00:00