Alexander Nicolaysen Sørnes
aa08dad894
Various language fixes for the front page, and make the language more
...
consistent.
2006-12-02 05:12:43 +00:00
Alexander Nicolaysen Sørnes
72a8cd48c1
Add some missing quotes to input tags, to prevent the variables from being
...
assigned garbage values. Also conform the affected tags to newer HTML standards.
2006-12-02 05:10:11 +00:00
Alexander Nicolaysen Sørnes
83e83e504f
Change the maintainer button from 'be a maintainer for this app' to 'be a
...
maintainer for this version', and change 'monitor version' to 'monitor
changes'. Add a 'title' entry to the <input> to provide mouseover help to the user.
2006-12-02 05:05:54 +00:00
Alexander Nicolaysen Sørnes
79582b050a
Quote output parameters used in <input> tags, otherwise empty variables will end up incorrectly pulling in the / from the end
...
of a <input /> tag
2006-12-01 02:55:09 +00:00
Chris Morgan
74c9f1d22b
Add help documentation on what 'maintainers' are and why they are important to the appdb.
2006-11-29 22:07:06 +00:00
Alexander Nicolaysen Sørnes
11e0bf2da7
Fix the newest apps list so it displays the correct date when the application was submitted, plus some small fixes
2006-11-28 01:10:26 +00:00
Alexander Nicolaysen Sørnes
79a5e062dd
Add the page and sidebar entry for a 'Browse newest applications' page
2006-11-27 03:14:57 +00:00
Alexander Nicolaysen Sørnes
4586465b09
Add basic rating logic checking to testData::CheckOutputEditorInput() to prevent people from saying a running application is
...
garbage and an application that won't install is platinum.
2006-11-27 02:32:22 +00:00
Alexander Nicolaysen Sørnes
ddcb2691a7
Add a FAQ entry about the term 'vendor'.
2006-11-26 18:17:29 +00:00
Alexander Nicolaysen Sørnes
26e5e8c193
Fix a typo on the main page.
2006-11-26 18:16:20 +00:00
Alexander Nicolaysen Sørnes
beed29012e
Fix moving versions by having the move version form update the internal version variable and then call the
...
Version::update() method to perform the update.
2006-11-26 17:15:38 +00:00
WineHQ
b858e2ba53
Unit tests should run with E_ALL so we can detect all errors. Fix dozens of errors that popped up after enabling all errors.
2006-11-25 17:24:44 +00:00
WineHQ
e1333dd7fc
Include the real name of the user deleting, rejecting and accepting applications and versions
2006-11-22 01:41:36 +00:00
EA Durbin
7532d9091e
Application::countWithRating() and getWithRating() should avoid queued applications. Add unit test
...
to ensure that we don't include queued applications
2006-09-30 01:31:04 +00:00
Chris Morgan
74fb6b5bd8
Flush the error log before performing the error log test, otherwise pending errors can throw the tests error count off
...
and cause it to improperly fail
2006-09-27 02:47:52 +00:00
EA Durbin
d8fe952bb1
Add the ability to browse applications by rating and a unit test for the added Application::getWithRating()
2006-09-27 02:44:16 +00:00
Chris Morgan
1a5f9b3b0f
query_error() can infinitely recurse as errors are inserted into the database and if the database doesn't exist
...
then the db insertion will fail and result in a call to query_error(). Once we've entered query_error() once if we enter it
again we should simply return
2006-09-26 02:10:57 +00:00
Chris Morgan
57b05023ed
Version::aBuglinkIds doesn't exist anymore, retrieve buglink ids with Version::get_buglink_ids() and use the returned ids
...
in Version::delete() in place of the class variable that no longer exists
2006-09-26 02:09:26 +00:00
WineHQ
47e7ad72af
Authors: "EA Durbin" <ead1234@hotmail.com>, Chris Morgan <cmorgan@alum.wpi.edu>
...
Application::delete() should retrieve the applications versions immediately prior to deleting to ensure that
an application object created prior to its child versions doesn't leave orphaned versions. Add unit test for
Application::delete() to test for the offending behavior.
2006-09-26 02:05:55 +00:00
EA Durbin
d526a2a504
Standardize the case of Bug class constructors
2006-09-06 01:43:30 +00:00
EA Durbin
e303923dea
Standardize all Image constructors to match the case defined in the Image class
2006-09-06 01:42:25 +00:00
EA Durbin
49c29264d9
Standardize the case of all User constructors to match the case defined in
...
the class.
2006-09-01 02:28:38 +00:00
EA Durbin
683a064cee
Add user.php to includes as comment.php creates a new user.
2006-09-01 02:27:31 +00:00
EA Durbin
c2a21ce08a
Add version.php to includes as notes.php calls a new Version constructor.
2006-09-01 02:25:18 +00:00
EA Durbin
369639c1f1
Require user.php as the user class is called from within maintainer.php
2006-09-01 02:23:24 +00:00
EA Durbin
d1c037e0ae
Make the case of 'Version' match the case used in the constructor
2006-08-31 02:39:09 +00:00
EA Durbin
988be2f138
Fix a misnamed variable in image::resize_image_border() and add a unit test to make sure we call this function to test it
2006-08-31 02:23:01 +00:00
EA Durbin
320b8c0d82
Make the case of 'Application' class match the case used to define the class. Php doesn't care but its a nice touch.
2006-08-30 22:27:07 +00:00
EA Durbin
f338b98845
Add missing include of category.php into application.php
2006-08-30 22:24:05 +00:00
EA Durbin
ced455be5b
Include 'version.php' and 'application.php' in maintainer.php as we new version and application objects in this class.
...
Fixes bug 5981.
2006-08-21 18:57:44 +00:00
Alexander Nicolaysen Sørnes
d5a00e576f
Create distributions table in create_tables script
2006-07-30 02:53:35 +00:00
Alexander Nicolaysen Sørnes
2351a6ff8c
Create table statement has a semi-colon where it should have a comma
2006-07-30 02:52:46 +00:00
Alexander Nicolaysen Sørnes
98f1ff0453
Fix some text in the test results form
2006-07-29 04:08:14 +00:00
Chris Morgan
8248346630
Simplify maintainer::getMaintainersForAppIdVersionId() query to be the same as the query used prior to the maintainer
...
changes. Fixes display of loads of maintainers due to permutations in a join that wasn't properly defined
2006-07-27 16:38:59 +00:00
Chris Morgan
61d338abbd
Comment::grab_comments() should use $iParentId when != NULL, not just !$iParentId as this prevents the use of
...
$iParentId in cases where the value is 0. Fixes duplicate display of every comment for an application version reported by
Nick Law.
2006-07-26 19:30:11 +00:00
Chris Morgan
cef2aec209
Start to move maintainer related functions into maintainer class and separate maintainer related queries and logic from
...
display code. Also move maintainer related code from the user class. Fix up unit tests to work with the new maintainer class.
2006-07-24 16:20:40 +00:00
Chris Morgan
25cf0a827f
Darken up the top X highlighting to make it more visible
2006-07-24 15:55:56 +00:00
Chris Morgan
4b380d37b3
Add a subtle highlight when mouse is over top X rows to provide better feedback to users that they may click anywhere
...
in the row to visit the application version. Add underlining to the text in the test results table to provide similar
feedback.
2006-07-21 19:18:10 +00:00
Chris Morgan
c726511204
Make table rows clickable using javascript. Use this functionality in the top X lists and in the test results table
2006-07-21 04:34:58 +00:00
Chris Morgan
f73d9c0283
Shift magnifying glass icon 10px left to put it near the corner of the thumbnail it is overlaying
2006-07-21 04:27:01 +00:00
Chris Morgan
240a241a54
Use require() instead of include() because we can't operate properly if we can't find all listed include files
2006-07-21 04:24:59 +00:00
Chris Morgan
9364f5bc5a
Rename include/distributions.php to include/distribution.php so the name of the file matches exactly the name
...
of the distribution class
2006-07-21 04:21:04 +00:00
Chris Morgan
1bdc44a003
Add a magnifying glass image overlay on top of screenshot thumbnails to make it more obvious to users that clicking on the
...
image will allow them to see a larger version of the thumbnail
2006-07-21 04:18:28 +00:00
Chris Morgan
3f1bfd3685
Attempt to capture the source of erroneous input to grab_comments() using error_log::logBackTrace()
2006-07-20 03:52:02 +00:00
Chris Morgan
34594b6eb4
Add logBackTrace() call to error_log class so we can determine code flow during error logging
2006-07-20 03:50:47 +00:00
Chris Morgan
f7763bdbfa
Clean up variable naming in grab_comments() , use null instead of -1 for parent ID
2006-07-20 03:19:23 +00:00
Chris Morgan
311081fda5
Handle mysql transaction deadlocks more gracefully by making multiple attempts when they occur
2006-07-19 19:20:16 +00:00
Chris Morgan
55065a254c
Add mysql_errno() output to error logging
2006-07-19 17:34:59 +00:00
Chris Morgan
3697e8b9c4
Swap error logging and addmsg() calls as addmsg() performs a database transaction and will clear out any error that
...
we wanted to report when error logging and calling mysql_error()
2006-07-19 17:18:16 +00:00
Chris Morgan
a651a3cdf3
Modify query_error() to log errors to a database table instead of displaying them on the screen. This should
...
let us more easily debug difficult or intermittent issues that users may not report. Add a cron to report logged
errors to appdb admins every night. Implement some basic unit tests for the new error logging code
2006-07-19 16:37:54 +00:00