Commit Graph

171 Commits

Author SHA1 Message Date
Tony Lambregts
b074048c57 Show if an Application has a Super Maintainer 2007-10-20 14:31:37 -04:00
Alexander Nicolaysen Sørnes
835d82e49b Add new voting system 2007-10-09 21:59:54 -04:00
Chris Morgan
b96e936ff8 Switch version::makeLicenseList() back to public since we call it from browse_downloadable.php 2007-09-26 21:56:16 -04:00
Chris Morgan
e07e0f5f11 Fix 'Using $this when not in object context error' by using the same method used in Application::canEdit() and Appliction::objectGetEntries() 2007-09-24 22:09:01 -04:00
Chris Morgan
a6f76eb892 Confusion between sAction=view and sAction=display broke viewing/displaying items. Standardize on sAction=view until we can come up with a more robust way of ensuring the same issue doesn't happen again. 2007-09-24 21:35:35 -04:00
Chris Morgan
fafcbce1bd Add more php5 scope keywords to class methods. 2007-09-24 21:11:49 -04:00
Alexander Nicolaysen Sørnes
4b453e1e5a version: Improve the submit test button for not-logged-in users 2007-09-20 21:30:26 -04:00
Alexander Nicolaysen Sørnes
3ab41b6fca Use objectManager to submit maintainer requests 2007-09-20 21:29:00 -04:00
Alexander Nicolaysen Sørnes
fdfe3eb2d3 Fix objectGetCustomVars 2007-09-20 21:16:14 -04:00
Alexander Nicolaysen Sørnes
72a250b2b0 Use objectManager to add and edit notes 2007-09-19 20:38:17 -04:00
Alexander Nicolaysen Sørnes
a6a62a2299 Use objectManager to display versions 2007-09-19 20:37:21 -04:00
Alexander Nicolaysen Sørnes
69b14f58c7 version: urlencode the sReturnTo value when submitting test results 2007-09-19 20:36:38 -04:00
Alexander Nicolaysen Sørnes
93d71f630a Prepare for viewing versions using objectManager 2007-09-18 20:38:28 -04:00
Alexander Nicolaysen Srnes
0f21daba18 Return user to the version view after submitting test data 2007-09-17 21:23:43 -04:00
Chris Morgan
607b130577 Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Show the versions for an app if they have the same queue status.

Instead of checking whether the version is un-queued, check if it has the same
status as the application.  This is needed to allow users to edit a queued
application they have submitted.
Modify the function name to reflect the change.
2007-09-14 23:45:51 -04:00
Chris Morgan
b2cc871f09 Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Use objectManager to create monitors.
2007-09-14 23:31:20 -04:00
Chris Morgan
d5cf2375dd Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Use objectManager to delete monitors.
2007-09-14 23:27:36 -04:00
Chris Morgan
2827e0654e Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Let objectManager handle deletion and delete notification.
2007-09-14 23:02:12 -04:00
Alexander Nicolaysen Sørnes
e8e68bf76f Fix obsolete notice in setup emails 2007-09-09 00:32:29 +00:00
Alexander Nicolaysen Sørnes
d2a53b510c Allow marking versions as obsolete 2007-09-08 22:52:00 +00:00
Alexander Nicolaysen Sørnes
5a4cbf49a3 Add and use objectGetChildren() method. Add support for initializing comment class from SQL
result.
2007-09-08 22:38:20 +00:00
Alexander Nicolaysen Sørnes
f07272f089 Add a missing Table::AddRow() call and clean up some whitespace 2007-09-08 01:41:23 +00:00
Chris Morgan
43a7ea8f1d Add object manager support to the bug class. Add menu entries for displaying the bug queue and
list of bugs and remove the existing link to admin/adminBugs.php. Remove now unused
admin/adminBugs.php. Remove now unused getNumberOfQueuedBugLinks() and getNumberOfBugLinks()
from util.php. Add object manager unit test support for the bug class.
2007-08-27 03:48:44 +00:00
Chris Morgan
156312f16f Fix $bSilent parameter for comment::delete() to be 'true', which makes the deletion silent.
Fixes previous commit.
2007-08-24 02:54:07 +00:00
Chris Morgan
9e05efb1b6 Fix comment::delete() to take $bSilent as an input parameter and use
comment::SendNotificationEmail(). Update version::delete() to pass false into comment::delete()
so we don't send an email for each comment we are deleting for a given version. Fixes bug 8473.
2007-08-24 02:52:34 +00:00
Chris Morgan
1f8d1690af Fix odd table formatting when editing versions 2007-08-04 16:56:27 +00:00
Chris Morgan
6119246b51 Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Chris Morgan
b94a2a392b Convert from timestamp to datetime. Datetime is consistent between mysql 4.0x and newer
versions and is faster for date/time computations. Modify object creation methods to specify
any time fields that were previously updated with timestamp properties.
2007-07-31 23:48:22 +00:00
Chris Morgan
0e3472e1bf objectGetHeader() should return a TableRow instance as this is closer to what the information
represents and is a much more useful form.
2007-07-31 01:51:40 +00:00
Chris Morgan
a923d0ff2f Add objectManager support to the note class 2007-07-30 00:27:37 +00:00
Alexander Nicolaysen Sørnes
1567fa2a32 Use multipage controls for version lists 2007-07-28 20:10:54 +00:00
Alexander Nicolaysen Sørnes
0e7e7a0f2b Fix version list to display missing tested release field 2007-07-24 01:50:19 +00:00
Chris Morgan
54ebcc2af8 Create a new TableRow() so we aren't adding entries to a previously used TableRow 2007-07-23 22:03:02 +00:00
Chris Morgan
5c42860972 Add check for empty tested ratings to the conditions upon which we will skip trying to color
using the tested rating. Remove two unused variables.
2007-07-23 20:39:49 +00:00
Chris Morgan
2652e68d01 Programmatic table support. Enhances several tables with highlightable and clickable rows and
cleans up the existing table row highlight and click code.
2007-07-23 19:56:43 +00:00
Chris Morgan
7c76ba42eb Color versions when displaying the version table on the application page. Add dynamic
highlighting and the ability to click on the row in the version table.
2007-07-12 23:58:00 +00:00
Chris Morgan
9831c1f762 Application view should list the number of test results for each version, this lets the appdb
user see which versions have the most feedback
2007-07-11 02:38:09 +00:00
Chris Morgan
62bfb16016 Make objectGetTableRow() return a TableRow class instance. Added accessors to set the
appropriate parameters in the TableRow class. Removed some unused parameters from the TableRow
class.
2007-07-02 00:35:17 +00:00
Alexander Nicolaysen Sørnes
051a1e5d0c Cleanup objectManager tests so all objects created during the test are deleted 2007-06-19 00:26:21 +00:00
Chris Morgan
a41b65c25e Remove duplicate and unused sDate variables from application and version classes 2007-06-16 04:55:34 +00:00
Alexander Nicolaysen Sørnes
cd198f44d7 Replace objectOutputTableRow() with objectGetTableRow(). Redesign the table output mechanism so
that we fetch a table row from a class instead of letting the class display it. Move adding of
edit/delete links from the classes to the objectManager. Fix a hole in the distribution class
where an uninitialized variable could have been used in the constructor.
2007-06-14 00:50:35 +00:00
Chris Morgan
7e4a084fd3 Version::Version() was using $this->iVersionId before the value was set 2007-06-10 22:15:35 +00:00
Alexander Nicolaysen Sørnes
f7b24fab9a Object constructors shouldn't require an id if passed a $oRow object. Gets rid of
objectGetInstanceFromRow() since we can pass the row into the constructor instead.
2007-06-10 18:51:33 +00:00
Alexander Nicolaysen Sørnes
cc57367fe3 Order versions by id 2007-06-10 00:28:52 +00:00
Chris Morgan
25edd78c73 Layout improvements. Change default inner padding for html_frame_start() from 5 to 0, this
lets us eliminate the white spacing between frames and their contents. Add in a
div.default_container class that has a 5px padding to replace the now not present default
spacing.
2007-05-02 01:08:22 +00:00
Alexander Nicolaysen Sørnes
11ecfa230b Add allowAnonymousSubmissions(). objectManager checks the return value of this new function and
exists with an error during certain actions if the user is not logged in and the function returns
false
2007-04-29 23:00:01 +00:00
Alexander Nicolaysen Sørnes
518def1855 Return from version::delete() if there isn't a valid version id 2007-04-27 00:06:07 +00:00
Alexander Nicolaysen Sørnes
b11cce6711 Use objectManager to submit and process applications. Remove now unused appsubmit.php
admin/adminAppQueue.php
2007-04-24 23:48:14 +00:00
Alexander Nicolaysen Sørnes
3a3aa89f4e Fix empty mail upon version acceptance. version::unQueue() was passing the wrong argument to
mailSubmitter()
2007-04-24 23:41:22 +00:00
Alexander Nicolaysen Sørnes
43fa6617d4 Prevent display of \n in version view that was caused by a typo 2007-04-23 23:40:41 +00:00