Commit Graph

1066 Commits

Author SHA1 Message Date
Chris Morgan
cf9cba4093 Objects should set class variables and call create() instead of passing the parameters into the
create() function.
2007-04-21 02:30:22 +00:00
Alexander Nicolaysen Sørnes
96bfe05734 Display move test results table when processing a version 2007-04-21 01:20:43 +00:00
Chris Morgan
434de30b9c Correct a few undefined variable errors brought out by the unit tests 2007-04-21 01:17:38 +00:00
Alexander Nicolaysen Sørnes
d5aabe4d17 More fixes and uses for objectManager's version/testData queues 2007-04-21 01:02:10 +00:00
Alexander Nicolaysen Sørnes
dad5de17b1 Test version/testData queues. Test version_queue and testData_queue with the objectManager
tests
2007-04-21 00:58:08 +00:00
Alexander Nicolaysen Sørnes
a8a4da643b Make testData's objectGetEntries more consistent for rejected testData. Don't allow
maintainers to view rejected entries for the versions they maintain, but show them their own
rejected entries instead
2007-04-20 00:02:20 +00:00
Alexander Nicolaysen Sørnes
67f61bbda5 Delete admin/resubmitRejectedApps.php, this file is no longer used 2007-04-19 23:53:28 +00:00
Alexander Nicolaysen Sørnes
4adcb4ad85 Highlight maintained apps/versions in the menu 2007-04-19 23:51:23 +00:00
Alexander Nicolaysen Sørnes
e176c0a9c7 Only show un-queued distributions in the testData list 2007-04-19 23:48:23 +00:00
Alexander Nicolaysen Sørnes
c43563eca6 Fix testData::create() permissions. Separate the cases where a user has edit rights from
when he has the right to unqueue items
2007-04-19 23:45:15 +00:00
Alexander Nicolaysen Sørnes
2a58cf59af Conform testData_queue to OM standards 2007-04-19 23:19:24 +00:00
Chris Morgan
b534f6d898 Use html_tr_hightlight_clickable() in menu.php add() to make linkable rows of menus
clickable. Provides visual feedback of which entry is active and enables users to click
anywhere in the menu row, not just on the url.
2007-04-19 01:20:55 +00:00
Alexander Nicolaysen Sørnes
cab71714cc Include testData_queue.php in objectManager. Document usage at the top of objectManager.php.
----------------------------------------------------------------------
2007-04-18 23:18:45 +00:00
Alexander Nicolaysen Sørnes
74c8fe502f Show more register links. Make registration easier by showing a register link together with
the log in link on the front page and on the user menu.
2007-04-17 23:30:51 +00:00
Alexander Nicolaysen Sørnes
fbb784c2f5 Fix mails for updated test results. Pass the correct 'edit' parameter to
sendNotificationMail() and only send mail if the test data has been changed.
2007-04-17 23:28:10 +00:00
Alexander Nicolaysen Sørnes
82ab0c467f Allow setting admin privileges in the user mananger 2007-04-17 23:21:34 +00:00
Alexander Nicolaysen Sørnes
efae38f6bf Use html_tr() function in distribution::outputEditor() 2007-04-17 23:19:48 +00:00
Alexander Nicolaysen Sørnes
b584fe1df7 Fix maintainer listing for versions. getMaintainersForAppIdVersionId() did not check that
additional entries had a superMaintainer = 1 so a maintainer of one version would be listed
as the maintainer for all versions of the application. Correct that issue and update the
unit test.
2007-04-16 23:19:44 +00:00
Alexander Nicolaysen Sørnes
46df59f063 Use objectManager for new test results 2007-04-16 23:10:08 +00:00
Alexander Nicolaysen Sørnes
a309317347 Fix url::canEdit() to not call undefined functions 2007-04-16 22:59:48 +00:00
Alexander Nicolaysen Sørnes
20ebe74913 Use absolute path in application::objectMakeUrl(), otherwise mail links won't work 2007-04-09 01:24:34 +00:00
Alexander Nicolaysen Sørnes
7825da1dc5 addcomment.php, use version::objectMakeUrl() 2007-04-09 01:23:11 +00:00
Alexander Nicolaysen Sørnes
ba3f966da4 test maintainer::getMaintainersForAppIdVersionId() 2007-04-08 23:06:27 +00:00
Alexander Nicolaysen Sørnes
169d7ca493 Use objectMakeUrl()/Link() in more places 2007-04-08 23:04:31 +00:00
Alexander Nicolaysen Sørnes
9de4e9b63b Test version class in objectManager tests 2007-04-08 23:01:22 +00:00
Alexander Nicolaysen Sørnes
ff476b1b13 Use objectmanager to list queued/rejected versions 2007-04-07 20:42:08 +00:00
Alexander Nicolaysen Sørnes
ec0cb3dbbb make version::objectGetEntriesCount() more consistent for rejected versions by not allowing
maintainers to see rejected versions for applications they maintain
2007-04-05 02:29:22 +00:00
Alexander Nicolaysen Sørnes
6c55180786 Use objectGetEntriesCount() in more places 2007-04-05 02:27:31 +00:00
Alexander Nicolaysen Sørnes
9a953f7ce8 Add return value to objectManager::displayErrors(). Return true if errors were found 2007-04-04 00:32:43 +00:00
Alexander Nicolaysen Sørnes
d76c297a41 fix display of top-voted application, one of the variables was prefixed with an 's' instead
of an 'sh'
2007-04-04 00:31:57 +00:00
Alexander Nicolaysen Sørnes
970cbca7f3 Add and use version::objectGetEntriesCount(). Only display the user menu's 'view rejected
apps' link for non-admins
2007-04-04 00:30:42 +00:00
Alexander Nicolaysen Sørnes
89535dbe01 Use objectMakeLink()/Url() in more places 2007-04-03 02:08:44 +00:00
Alexander Nicolaysen Sørnes
eeaf2c3642 Add test for testData::getNewestTestIdFromVersionId() 2007-04-03 00:05:35 +00:00
Alexander Nicolaysen Sørnes
2d9f73340d Add and use application::objectGetEntriesCount() 2007-04-03 00:00:48 +00:00
Chris Morgan
4402ac64b1 Rename testData::get_test_for_versionid() to testData::getNewestTestIdFromVersionId() so the
name of the method better describes the value the method is returning
2007-04-01 22:34:33 +00:00
Alexander Nicolaysen Sørnes
fa442e0c8e Fix testData::unQueue() emails by passing 'add' to ::mailSubmitter(). Previously 'unQueue'
was passed but testData::mailSubmitter() doesn't recognize this so likely the response email
had an empty subject
2007-04-01 16:49:28 +00:00
Alexander Nicolaysen Sørnes
cecc4bf6c0 Use objectMakeLink() in more places 2007-04-01 01:21:58 +00:00
Alexander Nicolaysen Sørnes
434ef17426 category: use objectMakeLink() 2007-04-01 00:09:05 +00:00
Alexander Nicolaysen Sørnes
6b9abce52c Avoid overlapping maintainer entries. When a user becomes a super maintainer of an
application remove all of their maintainer entries for the application versions. Update unit
tests to test maintainter overlapping.
2007-04-01 00:08:12 +00:00
Alexander Nicolaysen Sørnes
6194da096e Use objectMakeLink() to list maintainers 2007-03-31 17:25:12 +00:00
Chris Morgan
e2b15c0566 Keep track of global success or failure and print out a summary success or failure when the
tests are complete. Makes it less likely that a test failure will be missed.
2007-03-31 17:12:55 +00:00
Alexander Nicolaysen Sørnes
c494af3eb5 Fix display of latest testData to exclude queued entries 2007-03-28 00:09:12 +00:00
Chris Morgan
2de363c2d7 Add 'testing reports' count to appdb stats page 2007-03-26 00:39:53 +00:00
Chris Morgan
5913b9b43f Implement Alexander's suggestion and use version::fullName() to reduce code duplication 2007-03-25 21:04:33 +00:00
Alexander Nicolaysen Sørnes
a93bcb6ffe maintainer::deleteMaintainersForVersion() should properly return $hResult 2007-03-25 20:29:58 +00:00
Chris Morgan
08afa4283e testData should display the application name and version in outputEditor() 2007-03-25 19:58:34 +00:00
Alexander Nicolaysen Sørnes
d6e58f9676 Only show checked test results in version display 2007-03-25 18:58:13 +00:00
Alexander Nicolaysen Sørnes
ac978bfad7 objectManager: check editor values 2007-03-25 18:52:19 +00:00
Alexander Nicolaysen Sørnes
f11a4cf77f Add and use testData::objectDisplayAddItemHelp() 2007-03-25 16:10:15 +00:00
Alexander Nicolaysen Sørnes
a1ab25e58b Reorganize admin sidebar. Place the most used items higher and the least used items lower 2007-03-25 16:05:37 +00:00