Commit Graph

29 Commits

Author SHA1 Message Date
Chris Morgan
a1a41d6b87 Fix and enable input filtering through include/filter.php 2007-01-04 02:35:01 +00:00
Chris Morgan
9adf7e5592 Clean up appimage code removing a bunch of redundant code and removing a query for each image that is actually output
to the browser
2006-07-11 03:48:40 +00:00
Chris Morgan
5f4998194a Screenshot class optimization. Defer creation of thumbnail and screenshot images until values are necessary.
This greatly speeds up the loading of the main page as we create screenshot objects to check their other internal
parameters and not output their images.
2006-07-10 15:18:08 +00:00
Chris Morgan
d06cba3977 appimage should use the image sUrl instead of the iId when trying to stat() the file. We can't always be sure
that the iId will be the name of the file
2006-07-09 00:39:43 +00:00
Chris Morgan
854df987c6 Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Jonathan Ernst
a77cb05911 Enable filtering in appimage.php 2006-07-07 16:26:59 +00:00
Jonathan Ernst
3096e63828 Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
a34058b924 Update the comments in some files 2006-07-06 18:37:34 +00:00
Jonathan Ernst
54c484de8c Remove unnecessary exit calls after redirect() and util_show_error_page() calls 2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Jonathan Ernst
6d019b918a Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php 2006-06-29 16:13:35 +00:00
Chris Morgan
e3f9e5371a Use query_parameters() in SQL select, update and delete statements to protect against
sql injection attacks
2006-06-27 19:16:27 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
Chris Morgan
639dd77d15 Let maintainers and super maintainers process the application versions and images submitted for applications they maintain 2005-08-05 22:07:41 +00:00
Chris Morgan
16e28b37a3 Really use the url field as the local filesystem filename 2005-07-31 04:35:18 +00:00
Chris Morgan
5dcc4e3ae7 Use the url field from appData and not the id as the name of the file in the filesystem. It is only lately that the filenames of images are equal to the id of the row in the appData table 2005-07-31 04:23:06 +00:00
Chris Morgan
abdb3ef22b Report last modified header information for application images. This should reduce the bandwidth used when refreshing the main page multiple times. Patch based on David Lamberts patch 2005-07-31 03:35:44 +00:00
Chris Morgan
08cf792962 Restore appimage.php until the last-modified changes are verified working 2005-07-10 04:14:23 +00:00
Chris Morgan
9df7154d04 Fix some php bugs in the last modified patch that are breaking screenshots 2005-07-10 02:55:03 +00:00
David Lee Lambert
4ddd5dc8c0 Send last modified information for images so the browser can use the cached version instead of re-downloading images each page refresh. 2005-07-10 02:22:21 +00:00
Jonathan Ernst
2083bf521b - OO version of user class
- no more duplicated functions
- improved performances (much less duplicated mysql queries)
- less code and better error handling
2005-01-30 23:12:48 +00:00
Jonathan Ernst
d5a50ecec4 * new screenshot and image classes 2005-01-27 15:42:53 +00:00
Jonathan Ernst
e0da13cc44 imagedestroy() is called only if the ressource still exists
----------------------------------------------------------------------
2005-01-14 05:37:07 +00:00
Jonathan Ernst
d3ad0dba41 - replaced mysql_query() with query_appdb()
- removed opendb()
- removed query_userdb()
- removed error handling from the code as it is done with query_appdb()
2005-01-12 16:22:55 +00:00
Jonathan Ernst
dfec5cb9b0 Replaced mysql_query() with query_appdb() 2005-01-10 22:24:15 +00:00
Jonathan Ernst
d3d9e853d9 - replaced tons of tabs with spaces
- replaced <? with <?php for compatibility sake (see TODO and CODING_STANDARD to know more)
- improved overall code lisibility
2004-12-12 03:51:51 +00:00
Paul van Schayck
764ce13533 Check $width $height input. Display full image if no $width $height given 2004-03-25 16:23:42 +00:00
Paul van Schayck
5953434a6f Get imagetype from getimagesize(). Switched to $_GET. Clearing memory. 2004-03-24 15:49:39 +00:00
Jeremy Newman
8f28ae10c4 Initial revision 2004-03-15 16:22:00 +00:00