mirror of
https://github.com/genesi/linux-legacy.git
synced 2026-09-22 06:34:25 +00:00
NFSv4: Fix two unbalanced put_rpccred() issues.
commit 141aeb9f26f9f12f1584c128ce8697cdffb046e7 upstream. Commits29fba38b(nfs41: lease renewal) andfc01cea9(nfs41: sequence operation) introduce a couple of put_rpccred() calls on credentials for which there is no corresponding get_rpccred(). See http://bugzilla.kernel.org/show_bug.cgi?id=14249 Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
4886f07330
commit
85c60e5dfa
@@ -3038,9 +3038,6 @@ static void nfs4_renew_done(struct rpc_task *task, void *data)
|
||||
if (time_before(clp->cl_last_renewal,timestamp))
|
||||
clp->cl_last_renewal = timestamp;
|
||||
spin_unlock(&clp->cl_lock);
|
||||
dprintk("%s calling put_rpccred on rpc_cred %p\n", __func__,
|
||||
task->tk_msg.rpc_cred);
|
||||
put_rpccred(task->tk_msg.rpc_cred);
|
||||
}
|
||||
|
||||
static const struct rpc_call_ops nfs4_renew_ops = {
|
||||
@@ -4855,7 +4852,6 @@ void nfs41_sequence_call_done(struct rpc_task *task, void *data)
|
||||
nfs41_sequence_free_slot(clp, task->tk_msg.rpc_resp);
|
||||
dprintk("%s rpc_cred %p\n", __func__, task->tk_msg.rpc_cred);
|
||||
|
||||
put_rpccred(task->tk_msg.rpc_cred);
|
||||
kfree(task->tk_msg.rpc_argp);
|
||||
kfree(task->tk_msg.rpc_resp);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user