Anton Vorontsov 8e982ef543
phylib: Move workqueue initialization to a proper place ...
commit 541cd3ee00a4fe975b22fac6a3bc846bacef37f7 ("phylib: Fix deadlock
on resume") caused TI DaVinci EMAC ethernet driver to oops upon resume:
PM: resume of devices complete after 237.098 msecs
Restarting tasks ... done.
kernel BUG at kernel/workqueue.c:354!
Unable to handle kernel NULL pointer dereference at virtual address 00000000
[...]
Backtrace:
[<c002c598>] (__bug+0x0/0x2c) from [<c0052a54>] (queue_delayed_work_on+0x74/0xf8)
[<c00529e0>] (queue_delayed_work_on+0x0/0xf8) from [<c0052b30>] (queue_delayed_work+0x2c/0x30)
The oops pops up because TI DaVinci EMAC driver detaches PHY on
suspend and attaches it back on resume. Attaching makes phylib call
phy_start_machine() that initializes a workqueue. On the other hand,
PHY's resume routine will call phy_start_machine() again, and that
will cause the oops since we just destroyed the already scheduled
workqueue.
This patch fixes the issue by moving workqueue initialization to
phy_device_create().
p.s. We don't see this oops with ucc_geth and gianfar drivers because
they perform a fine-grained suspend, i.e. they just stop the PHYs
without detaching.
Reported-by: Sekhar Nori <nsekhar@ti.com >
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com >
Tested-by: Sekhar Nori <nsekhar@ti.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2010-08-10 11:50:22 -05:00
2009-06-19 16:46:03 -07:00
2009-01-06 18:10:26 -08:00
2009-06-01 02:53:35 -07:00
2009-08-07 10:39:56 -07:00
2009-03-26 18:14:15 +01:00
2009-06-20 10:17:02 -07:00
2009-08-05 22:20:14 -07:00
2009-06-08 00:45:50 -07:00
2009-06-17 18:02:10 -07:00
2010-08-10 11:44:41 -05:00
2009-06-05 10:36:24 -07:00
2009-06-16 19:14:16 -03:00
2010-08-10 11:45:36 -05:00
2009-06-29 14:31:46 +02:00
2009-06-22 12:55:50 -07:00
2009-06-18 08:46:47 +10:00
2010-08-10 11:45:17 -05:00
2008-09-03 15:41:57 -07:00
2009-06-30 18:56:00 -07:00
2009-07-12 12:22:34 -07:00
2010-08-10 11:48:51 -05:00
2009-06-11 03:30:20 -07:00
Merge branches 'acerhdf', 'acpi-pci-bind', 'bjorn-pci-root', 'bugzilla-12904', 'bugzilla-13121', 'bugzilla-13396', 'bugzilla-13533', 'bugzilla-13612', 'c3_lock', 'hid-cleanups', 'misc-2.6.31', 'pdc-leak-fix', 'pnpacpi', 'power_nocheck', 'thinkpad_acpi', 'video' and 'wmi' into release
2009-06-24 01:19:50 -04:00
2009-06-17 00:36:36 -04:00
2009-06-19 10:21:42 +10:00
2009-06-30 18:55:58 -07:00
2009-06-15 18:52:52 +02:00
2008-12-03 22:12:38 -08:00
2009-06-24 00:00:52 -04:00
2009-06-01 06:21:13 +00:00
2009-07-11 11:22:26 -07:00
2010-04-01 15:55:56 -07:00
2009-07-01 10:56:25 +02:00
2009-08-21 09:26:15 -07:00
2009-08-01 10:24:35 +02:00
2009-06-10 11:55:06 +02:00
2009-04-16 07:47:49 -07:00
2009-06-16 19:47:48 -07:00
2009-06-15 15:49:34 +02:00
2009-07-31 12:28:46 +02:00
2009-06-11 21:36:09 -04:00
2009-07-29 19:10:35 -07:00
2009-06-04 17:45:43 +01:00
2009-07-10 17:32:55 +02:00
2009-07-31 14:12:36 +02:00
2009-06-18 13:03:57 -07:00
2009-06-12 21:46:57 +09:30
2008-08-26 10:26:54 +02:00
2010-04-01 15:55:30 -07:00
2009-07-16 09:19:16 -07:00
2008-06-04 14:56:12 +01:00
2009-06-22 21:18:12 -07:00
2009-08-21 09:26:15 -07:00
2009-06-16 19:47:31 -07:00
2009-06-11 21:36:10 -04:00
2009-07-12 12:22:34 -07:00
2009-05-29 08:40:01 -07:00
2010-08-10 11:44:23 -05:00
2009-06-11 08:50:57 -07:00
2009-06-11 21:36:06 -04:00
2009-03-23 16:25:46 +01:00
2009-09-04 20:40:25 +01:00
2009-07-12 13:02:10 -07:00
2009-05-07 10:14:26 -05:00
2009-06-22 10:12:30 +01:00
2009-09-04 20:40:34 +01:00
2009-05-18 14:46:26 +01:00
2009-06-19 16:46:08 -07:00
2009-05-12 14:41:47 -07:00
2007-02-09 17:39:36 -05:00
2009-06-23 22:09:17 +01:00
2009-06-11 14:57:53 -04:00
2009-06-17 09:33:49 -07:00
2009-06-15 21:30:26 -07:00
2009-05-11 09:52:18 +02:00
2009-07-08 09:18:05 -07:00
2010-04-01 15:55:39 -07:00
2008-02-07 08:42:25 -08:00
2009-05-05 12:26:24 -07:00
2009-06-09 05:25:36 -07:00
2009-06-30 18:55:58 -07:00
2009-06-24 08:17:04 -04:00
2009-07-15 21:30:46 +02:00
2009-06-24 08:15:27 -04:00
2009-06-30 18:56:00 -07:00
2010-08-10 11:50:16 -05:00
2009-06-25 19:42:36 +02:00
2009-06-16 19:47:28 -07:00
2009-06-15 21:30:25 -07:00
2009-08-26 20:06:52 -07:00
2009-03-31 23:00:26 -04:00
2010-01-06 14:26:51 -08:00
2010-08-10 11:48:53 -05:00
2009-07-21 15:26:27 -04:00
2009-06-11 14:57:54 -04:00
2009-08-09 12:53:48 +02:00
2009-10-12 12:40:09 -07:00
2009-06-30 20:12:24 +02:00
2009-05-09 16:10:18 -07:00
2009-06-18 13:04:05 -07:00
2009-08-17 21:33:49 -07:00
2006-10-02 07:57:12 -07:00
2009-06-15 21:30:25 -07:00
2006-09-30 01:47:55 +02:00
2009-06-18 13:12:57 -07:00
2010-08-10 11:49:55 -05:00
2009-07-12 12:22:34 -07:00
2007-02-05 10:00:38 +01:00
2009-05-20 15:48:35 +02:00
2009-06-16 19:47:41 -07:00
2009-12-18 13:43:23 -08:00
2009-08-24 12:53:01 -07:00
2009-06-13 10:39:28 +01:00
2009-06-19 16:58:21 +02:00
2009-05-28 20:52:40 -04:00
2009-06-23 04:31:07 -07:00
2009-06-29 19:20:42 -07:00
2009-06-03 14:05:10 -04:00
2009-06-09 05:25:30 -07:00
2009-07-02 13:16:58 -07:00
2009-05-21 15:13:39 -07:00
2009-05-19 16:02:02 -07:00
2009-05-18 22:19:19 -07:00
2009-06-29 08:59:10 +10:00
2010-08-10 11:44:41 -05:00
2009-06-02 00:45:24 -07:00
2009-07-27 18:39:45 -07:00
2009-06-27 00:06:42 +02:00
2009-06-18 13:03:57 -07:00
2009-06-19 22:55:17 -07:00
2009-05-18 14:46:26 +01:00
2009-07-22 10:12:18 -07:00
2009-07-31 08:55:48 +02:00
2009-06-11 12:04:06 -07:00
2007-04-25 22:25:31 -07:00
2009-06-18 13:03:56 -07:00
2010-08-10 11:47:00 -05:00
2009-06-01 03:07:33 -07:00
2010-08-10 11:46:51 -05:00
2009-06-20 11:30:01 -07:00
2009-12-18 13:43:54 -08:00
2009-06-17 11:47:48 -04:00
2010-08-10 11:50:19 -05:00
2007-07-31 15:39:40 -07:00
2009-06-18 13:03:40 -07:00
2009-06-25 22:06:11 +02:00
2008-04-18 22:16:54 -04:00
2009-06-14 13:50:36 -07:00
2009-06-15 15:49:23 +02:00
2009-07-08 14:25:14 +01:00
2008-04-30 08:29:54 -07:00
2009-08-05 14:03:43 +03:00
2009-09-24 08:44:07 -07:00
2009-06-10 11:48:27 +03:00
2009-12-18 13:43:24 -08:00
2010-08-10 11:50:18 -05:00
2009-06-23 20:21:38 +01:00
2009-06-23 20:21:39 +01:00
2009-07-30 16:03:45 +09:30
2009-07-30 16:03:46 +09:30
2009-07-28 21:07:09 -04:00
2009-06-26 23:58:39 +02:00
2009-06-16 19:47:57 -07:00
2009-06-16 19:47:57 -07:00
2009-06-13 12:28:57 +02:00
2009-08-31 17:30:14 -10:00
2009-06-22 14:34:22 -07:00
2009-06-11 21:36:10 -04:00
2010-08-10 11:44:41 -05:00
2009-06-09 00:53:21 +04:00
2008-04-15 19:35:41 -07:00
2009-06-11 02:47:10 -07:00
2009-06-18 13:03:47 -07:00
2009-06-16 08:40:20 +02:00
2009-06-15 21:30:25 -07:00
2009-05-25 00:55:30 -07:00
2009-06-11 19:05:32 +02:00
2009-05-25 00:55:45 -07:00
2009-08-18 16:31:13 -07:00
2010-04-01 15:55:50 -07:00
2009-06-16 19:47:42 -07:00
2009-07-08 09:31:56 -07:00
2009-03-24 16:38:24 -07:00
2009-06-18 13:03:57 -07:00
2009-11-09 16:22:17 -08:00
2009-06-11 21:36:02 -04:00
2008-06-06 11:29:12 -07:00
2008-04-07 12:15:39 -05:00
2008-02-13 16:21:18 -08:00
2010-08-10 11:44:41 -05:00
2010-08-10 11:44:41 -05:00
2010-08-10 11:44:41 -05:00
2010-08-10 11:45:52 -05:00
2010-08-10 11:44:41 -05:00
2010-08-10 11:44:41 -05:00
2010-08-10 11:44:41 -05:00
2010-08-10 11:50:19 -05:00
2010-08-10 11:44:41 -05:00
2010-08-10 11:50:18 -05:00
2009-06-11 21:36:01 -04:00
2009-06-15 03:02:23 -07:00
2009-06-18 00:29:08 -07:00
2009-06-17 18:02:11 -07:00
2009-06-17 18:02:11 -07:00
2009-06-17 12:24:34 -07:00
2009-06-17 14:11:42 -07:00
2009-08-12 08:21:39 -07:00
2009-06-17 12:24:34 -07:00
2009-06-17 18:02:11 -07:00
2009-05-13 15:44:39 -04:00
2009-06-09 05:25:33 -07:00
2009-06-15 21:44:43 -07:00
2009-08-07 10:39:55 -07:00
2009-06-03 14:05:12 -04:00
2009-07-22 09:27:18 -07:00
2009-06-12 11:00:54 +03:00
2009-06-17 08:30:15 +03:00
2009-06-16 19:47:42 -07:00
2009-06-02 09:53:22 -07:00
2008-02-14 21:13:33 -08:00
Merge branches 'acerhdf', 'acpi-pci-bind', 'bjorn-pci-root', 'bugzilla-12904', 'bugzilla-13121', 'bugzilla-13396', 'bugzilla-13533', 'bugzilla-13612', 'c3_lock', 'hid-cleanups', 'misc-2.6.31', 'pdc-leak-fix', 'pnpacpi', 'power_nocheck', 'thinkpad_acpi', 'video' and 'wmi' into release
2009-06-24 01:19:50 -04:00
2009-11-09 16:23:15 -08:00
2009-06-22 21:38:22 -07:00
2009-06-16 14:29:30 -07:00
2009-06-29 12:14:51 -07:00
2009-06-30 18:55:59 -07:00
2009-06-11 17:04:18 +01:00
2009-08-13 12:58:04 +02:00
2009-07-12 12:21:33 -07:00
2010-08-10 11:50:22 -05:00
2009-05-11 14:13:10 +02:00
2009-06-15 21:30:24 -07:00
2009-06-12 21:32:31 +02:00
2010-08-10 11:44:41 -05:00
2010-08-10 11:44:41 -05:00
2010-08-10 11:44:41 -05:00
2010-08-10 11:44:41 -05:00
2010-08-10 11:44:41 -05:00
2010-08-10 11:44:41 -05:00
2009-06-05 14:37:41 +00:00
2009-06-16 19:47:48 -07:00
2009-06-24 16:58:48 -04:00
2009-06-18 13:04:04 -07:00
2009-07-29 19:10:36 -07:00
2007-10-19 20:35:04 +02:00
2009-06-11 21:36:01 -04:00
2009-06-18 13:03:51 -07:00
2009-06-11 21:36:12 -04:00
2008-09-02 19:21:38 -07:00
2010-01-06 14:26:52 -08:00
2009-07-12 12:22:34 -07:00
2009-06-16 19:47:30 -07:00
2009-01-31 00:05:59 +05:30
2009-06-11 08:51:08 -07:00
2009-06-24 08:17:06 -04:00
2009-06-24 08:17:06 -04:00
2009-06-11 21:35:58 -04:00
2009-06-18 13:03:46 -07:00
2009-05-17 11:45:45 -07:00
2009-06-18 13:03:48 -07:00
2009-07-21 12:07:43 -04:00
2009-06-15 15:49:37 +02:00
2009-06-23 12:50:05 -07:00
2009-05-09 10:49:41 -04:00
2009-07-31 12:28:45 +02:00
2010-04-01 15:55:56 -07:00
2009-06-03 09:14:45 -04:00
2008-11-14 10:39:18 +11:00
2009-08-17 15:09:27 +10:00
2007-10-16 09:43:17 -07:00
2009-06-18 13:03:57 -07:00
2009-06-22 11:32:25 -07:00
2009-06-22 11:32:24 -07:00
2009-05-08 23:22:26 +09:00
2009-06-11 08:50:58 -07:00
2009-05-09 16:10:18 -07:00
2009-06-24 08:17:06 -04:00
2009-12-08 10:22:01 -08:00
2009-06-13 08:58:43 +02:00
2009-06-15 15:50:49 +02:00
2009-06-12 18:53:33 +03:00
2009-07-08 14:25:14 +01:00
2009-06-16 19:47:48 -07:00
2009-06-09 05:25:30 -07:00
2010-08-10 11:44:41 -05:00
2009-06-10 11:48:14 +02:00
2009-07-09 17:06:58 -07:00
2009-05-12 11:11:48 +02:00
2009-06-12 23:04:12 +02:00
2008-10-03 11:46:14 -05:00
2009-06-12 21:32:33 +02:00
2009-06-23 12:50:05 -07:00
2005-04-16 15:20:36 -07:00
2009-07-07 10:51:39 +02:00
2009-07-06 13:57:03 -07:00
2008-12-30 09:05:12 +10:30
2009-06-13 12:00:26 +02:00
2009-06-24 11:15:09 +02:00
2009-02-18 15:37:53 -08:00
2009-06-16 19:47:27 -07:00
2009-06-15 11:37:09 -04:00
2009-06-18 13:03:49 -07:00
2009-06-15 21:30:28 -07:00
2009-06-11 08:50:59 -07:00
2009-08-04 13:46:30 -07:00
2009-10-05 09:32:34 -07:00
2009-06-19 08:08:50 +02:00
2009-08-21 00:53:12 -07:00
2009-07-29 19:10:39 -07:00
2009-06-12 18:01:45 +02:00
2009-12-18 13:43:35 -08:00
2009-07-12 15:16:39 -07:00
2009-06-16 19:47:47 -07:00
2009-07-24 14:03:30 -03:00
2009-07-30 16:03:46 +09:30
2009-07-30 16:03:46 +09:30
2009-07-30 16:03:46 +09:30
2009-06-12 22:16:37 +09:30
2009-07-30 16:03:46 +09:30
2009-06-12 22:16:36 +09:30
2009-06-16 19:47:52 -07:00
2009-06-16 19:47:46 -07:00
2006-04-26 12:56:16 +01:00
2009-06-18 13:03:58 -07:00
2009-08-10 14:43:09 +02:00
2009-05-28 18:02:32 -07:00
2009-09-05 11:30:42 -07:00
2009-06-11 21:36:03 -04:00
8e982ef543