mirror of
https://github.com/TheAlgorithms/C.git
synced 2026-02-16 05:55:12 +00:00
[OTHER] Inconsistent coding style with .clang-format
#163
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @yaoyhu on GitHub (Jun 12, 2023).
What would you like to share?
What is the actual coding style for Algorithms/C?
The online documentation suggests that this should be consistent with the CMU Style, which has been followed with
CONTRIBUTION GUIDELINES.However, it appears that the use of parentheses in all code within the repository does not conform to this CMU coding style.
Additional information
I wasted 30 min on this: I thought that there was an issue with my VS Code settings or with Clang-Format, but I later realized that the problem was with the inconsistency between the .clang-format file and the coding standards.
@Panquesito7 commented on GitHub (Jun 12, 2023):
Those coding guidelines are very old now (5+ years).
We probably should either remove it or update them.
@yaoyhu commented on GitHub (Jun 12, 2023):
I think the coding style of CMU is very good, and LLVM and Google both use this type of formatting for their parentheses. Therefore, I think it's better to reformat the code in the repository.
@Panquesito7 commented on GitHub (Jun 12, 2023):
Sounds good to me. 👍
We should wait for the input of other maintainers, though.
@github-actions[bot] commented on GitHub (Jul 13, 2023):
This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@github-actions[bot] commented on GitHub (Jul 21, 2023):
Please ping one of the maintainers once you add more information and updates here. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!
@realstealthninja commented on GitHub (Jul 21, 2023):
CMU sounds good
@github-actions[bot] commented on GitHub (Aug 21, 2023):
This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@yaoyhu commented on GitHub (Aug 21, 2023):
I've modified the `.clang-format' within my PR #1283, which satisfies the CMU coding standard.
@github-actions[bot] commented on GitHub (Sep 21, 2023):
This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@github-actions[bot] commented on GitHub (Sep 28, 2023):
Please ping one of the maintainers once you add more information and updates here. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!