fix build issues

This commit is contained in:
Robert Muehsig
2019-10-03 23:07:17 +02:00
parent e25b89ff6a
commit b3bb3ceb97
2 changed files with 6 additions and 5 deletions

View File

@@ -108,16 +108,16 @@ namespace ElectronNET.CLI.Commands
Console.WriteLine("Start npm install electron-builder...");
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
// Works proper on Windows...
ProcessHelper.CmdExecute("npm install electron-builder --global", tempPath);
}
else
{
// ToDo: find another solution or document it proper
// GH Issue https://github.com/electron-userland/electron-prebuilt/issues/48
Console.WriteLine("Electron Builder - make sure you invoke 'sudo npm install electron-builder --global' at " + tempPath + " manually. Sry.");
Console.WriteLine("Electron Builder - make sure you invoke 'sudo npm install electron-builder --global' & 'sudo npm install typescript --global' at " + tempPath + " manually. Sry.");
}
Console.WriteLine("ElectronHostHook handling started...");
@@ -130,6 +130,7 @@ namespace ElectronNET.CLI.Commands
DirectoryCopy.Do(electronhosthookDir, hosthookDir, true, new List<string>() { "node_modules" });
Console.WriteLine("Start npm install for hosthooks...");
ProcessHelper.CmdExecute("npm install typescript --global", tempPath);
ProcessHelper.CmdExecute("npm install --production", hosthookDir);
// ToDo: Global TypeScript installation is needed for ElectronHostHook

View File

@@ -22,7 +22,7 @@ dotnet tool uninstall ElectronNET.CLI -g
dotnet tool install ElectronNET.CLI -g
echo "/target xxx (dev-build)"
electronize build /target custom win7-x86;win32 /dotnet-configuration Debug /electron-arch ia32 /electron-params "--prune=true "
electronize build /target custom win7-x86;win /dotnet-configuration Debug /electron-arch ia32 /electron-params " "
echo "/target win (dev-build)"
electronize build /target win
@@ -30,8 +30,8 @@ electronize build /target win
echo "/target linux (dev-build)"
electronize build /target linux
echo "/target custom win7-x86;win32 (dev-build)"
electronize build /target custom win7-x86;win32
echo "/target custom win7-x86;win (dev-build)"
electronize build /target custom win7-x86;win
:: Be aware, that for non-electronnet-dev environments the correct