Added support for Electron 42+

Improved argument forwarding
Merge pull request #1068 from ElectronNET/dependabot/npm_and_yarn/src/ElectronNET.Host/ElectronHostHook/multi-8c9a216550
2026-07-09 02:07:47 +00:00 · 2026-06-07 13:22:25 +02:00 · 2026-06-06 21:10:19 +02:00 · 2026-05-25 22:22:22 +02:00 · 2026-05-25 20:11:16 +00:00
6 changed files with 91 additions and 18 deletions
--- a/Changelog.md
+++ b/Changelog.md
@@ -1,4 +1,11 @@
-## 0.5.0
+# 0.5.1
+
+## ElectronNET.Core
+
+- Fixed slicing of arguments for packaged applications (#1072)
+- Added support for Electron 42+ (#1073)
+
+# 0.5.0

 ## ElectronNET.Core

--- a/src/ElectronNET.Host/ElectronHostHook/package-lock.json
+++ b/src/ElectronNET.Host/ElectronHostHook/package-lock.json
@@ -39,6 +39,15 @@
        "undici-types": "~7.14.0"
      }
    },
+    "node_modules/@types/ws": {
+      "version": "8.18.1",
+      "resolved": "https://registry.npmjs.org/@types/ws/-/ws-8.18.1.tgz",
+      "integrity": "sha512-ThVF6DCVhA8kUGy+aazFQ4kXQ7E1Ty7A3ypFOe0IcJV8O/M511G99AW24irKrW56Wt44yG9+ij8FaqoBGkuBXg==",
+      "license": "MIT",
+      "dependencies": {
+        "@types/node": "*"
+      }
+    },
    "node_modules/accepts": {
      "version": "1.3.8",
      "resolved": "https://registry.npmjs.org/accepts/-/accepts-1.3.8.tgz",
@@ -101,20 +110,21 @@
      }
    },
    "node_modules/engine.io": {
-      "version": "6.6.4",
-      "resolved": "https://registry.npmjs.org/engine.io/-/engine.io-6.6.4.tgz",
-      "integrity": "sha512-ZCkIjSYNDyGn0R6ewHDtXgns/Zre/NT6Agvq1/WobF7JXgFff4SeDroKiCO3fNJreU9YG429Sc81o4w5ok/W5g==",
+      "version": "6.6.8",
+      "resolved": "https://registry.npmjs.org/engine.io/-/engine.io-6.6.8.tgz",
+      "integrity": "sha512-2agL3ueZhqxoVrfmntO8yuVj+uNSlIOnhykYHk3Cq0ShYPdUjjUiSJrQvXjq01I9jAuI0Zl2YO8Evv5Mqytm5g==",
      "license": "MIT",
      "dependencies": {
        "@types/cors": "^2.8.12",
        "@types/node": ">=10.0.0",
+        "@types/ws": "^8.5.12",
        "accepts": "~1.3.4",
        "base64id": "2.0.0",
        "cookie": "~0.7.2",
        "cors": "~2.8.5",
-        "debug": "~4.3.1",
+        "debug": "~4.4.1",
        "engine.io-parser": "~5.2.1",
-        "ws": "~8.17.1"
+        "ws": "~8.20.1"
      },
      "engines": {
        "node": ">=10.2.0"
@@ -129,6 +139,23 @@
        "node": ">=10.0.0"
      }
    },
+    "node_modules/engine.io/node_modules/debug": {
+      "version": "4.4.3",
+      "resolved": "https://registry.npmjs.org/debug/-/debug-4.4.3.tgz",
+      "integrity": "sha512-RGwwWnwQvkVfavKVt22FGLw+xYSdzARwm0ru6DhTVA3umU5hZc28V3kO4stgYryrTlLpuvgI9GiijltAjNbcqA==",
+      "license": "MIT",
+      "dependencies": {
+        "ms": "^2.1.3"
+      },
+      "engines": {
+        "node": ">=6.0"
+      },
+      "peerDependenciesMeta": {
+        "supports-color": {
+          "optional": true
+        }
+      }
+    },
    "node_modules/mime-db": {
      "version": "1.52.0",
      "resolved": "https://registry.npmjs.org/mime-db/-/mime-db-1.52.0.tgz",
@@ -193,13 +220,30 @@
      }
    },
    "node_modules/socket.io-adapter": {
-      "version": "2.5.5",
-      "resolved": "https://registry.npmjs.org/socket.io-adapter/-/socket.io-adapter-2.5.5.tgz",
-      "integrity": "sha512-eLDQas5dzPgOWCk9GuuJC2lBqItuhKI4uxGgo9aIV7MYbk2h9Q6uULEh8WBzThoI7l+qU9Ast9fVUmkqPP9wYg==",
+      "version": "2.5.7",
+      "resolved": "https://registry.npmjs.org/socket.io-adapter/-/socket.io-adapter-2.5.7.tgz",
+      "integrity": "sha512-e0LyK91f3cUxTmv95/KzoLg47+zF+s/sbxRGDNsyG4dmIP8ZSX8ax6byOxfJXeNNtS/8AZlfD+uP7gBeR7DLlg==",
      "license": "MIT",
      "dependencies": {
-        "debug": "~4.3.4",
-        "ws": "~8.17.1"
+        "debug": "~4.4.1",
+        "ws": "~8.20.1"
+      }
+    },
+    "node_modules/socket.io-adapter/node_modules/debug": {
+      "version": "4.4.3",
+      "resolved": "https://registry.npmjs.org/debug/-/debug-4.4.3.tgz",
+      "integrity": "sha512-RGwwWnwQvkVfavKVt22FGLw+xYSdzARwm0ru6DhTVA3umU5hZc28V3kO4stgYryrTlLpuvgI9GiijltAjNbcqA==",
+      "license": "MIT",
+      "dependencies": {
+        "ms": "^2.1.3"
+      },
+      "engines": {
+        "node": ">=6.0"
+      },
+      "peerDependenciesMeta": {
+        "supports-color": {
+          "optional": true
+        }
      }
    },
    "node_modules/socket.io-parser": {
@@ -262,9 +306,9 @@
      }
    },
    "node_modules/ws": {
-      "version": "8.17.1",
-      "resolved": "https://registry.npmjs.org/ws/-/ws-8.17.1.tgz",
-      "integrity": "sha512-6XQFvXTkbfUOZOKKILFG1PDK2NDQs4azKQl26T0YS5CxqWLgXajbPZ+h4gZekJyRqFU8pvnbAbbs/3TgRPy+GQ==",
+      "version": "8.20.1",
+      "resolved": "https://registry.npmjs.org/ws/-/ws-8.20.1.tgz",
+      "integrity": "sha512-It4dO0K5v//JtTXuPkfEOaI3uUN87iYPnqo/ZzqCoG3g8uhA66QUMs/SrM0YK7/NAu+r4LMh/9dq2A7k+rHs+w==",
      "license": "MIT",
      "engines": {
        "node": ">=10.0.0"
--- a/src/ElectronNET.Host/main.js
+++ b/src/ElectronNET.Host/main.js
@@ -133,7 +133,8 @@ if (manifestJsonFile.singleInstance) {
 // Collect user supplied command line args (excluding those handled by Electron host itself)
 function getForwardedArgs() {
    const skipSwitches = new Set(['unpackedelectron', 'unpackeddotnet', 'dotnetpacked']);
-    return process.argv.slice(2).filter(arg => {
+    const sliceIndex = app.isPackaged ? 1 : 2;
+    return process.argv.slice(sliceIndex).filter(arg => {
        if (!arg) return false;
        // Node/Electron internal or we already process them
        if (arg.startsWith('--manifest')) return false;
--- a/src/ElectronNET/build/ElectronNET.LateImport.targets
+++ b/src/ElectronNET/build/ElectronNET.LateImport.targets
@@ -46,6 +46,7 @@
    <ElectronDirName>.electron</ElectronDirName>
    <ElectronSplashScreenFileName Condition="'$(ElectronSplashScreen)' != ''">$([System.IO.Path]::GetFileName($(ElectronSplashScreen)))</ElectronSplashScreenFileName>
    <ElectronIconFileName Condition="'$(ElectronIcon)' != ''">$([System.IO.Path]::GetFileName($(ElectronIcon)))</ElectronIconFileName>
+    <ElectronMajor>$([System.String]::Copy('$(ElectronVersion)').Split('.')[0])</ElectronMajor>
  </PropertyGroup>


@@ -363,6 +364,7 @@
    <PropertyGroup>
      <ElectronOutputPath>$([System.IO.Path]::GetFullPath('$(ElectronOutDir)'))</ElectronOutputPath>
      <_NpmCmd>npm install --no-bin-links</_NpmCmd>
+      <_NpmCmd Condition="$(ElectronMajor) &gt;= 42">npx install-electron</_NpmCmd>
      <!-- Add cross-platform parameters when there's a platform mismatch (for remote debugging preparation) -->
      <_NpmCmd Condition="'$(_IsPlatformMismatch)' == 'true'">$(_NpmCmd) --os=$(NpmOs) --cpu=$(NpmCpu) --arch=$(NpmCpu) --platform=$(NpmOs)</_NpmCmd>
      <_NpmCmd Condition="'$(IsLinuxWsl)' == 'true'">wsl bash -ic '$(_NpmCmd)'</_NpmCmd>
@@ -376,10 +378,23 @@
      <Output TaskParameter="ExitCode" PropertyName="ExecExitCode"/>
    </Exec>

-    <!--<Exec Command="powershell -Command &quot;Start-Sleep -Seconds 10&quot;" />-->
-
    <Message Importance="High" Text="Electron setup failed!" Condition="'$(ExecExitCode)' != '0'" />

+    <PropertyGroup>
+      <_NpmCmd>npx install-electron</_NpmCmd>
+      <!-- Add cross-platform parameters when there's a platform mismatch (for remote debugging preparation) -->
+      <_NpmCmd Condition="'$(_IsPlatformMismatch)' == 'true'">$(_NpmCmd) --os=$(NpmOs) --cpu=$(NpmCpu) --arch=$(NpmCpu) --platform=$(NpmOs)</_NpmCmd>
+      <_NpmCmd Condition="'$(IsLinuxWsl)' == 'true'">wsl bash -ic '$(_NpmCmd)'</_NpmCmd>
+    </PropertyGroup>
+
+    <Message Importance="High" Text="Running command: $(_NpmCmd) in folder:  $(ElectronOutputPath)" Condition="$(ElectronMajor) &gt;= 42 AND @(_CopiedFiles->Count()) > 0" />
+
+    <Exec Command="$(_NpmCmd)" WorkingDirectory="$(ElectronOutputPath)" Timeout="600000" StandardOutputImportance="High" StandardErrorImportance="High" ContinueOnError="false" Condition="$(ElectronMajor) &gt;= 42 AND @(_CopiedFiles->Count()) > 0">
+      <Output TaskParameter="ExitCode" PropertyName="ExecExitCode"/>
+    </Exec>
+
+    <Message Importance="High" Text="Electron installation failed!" Condition="'$(ExecExitCode)' != '0'" />
+
    <!-- Fix up incorrect symlinks created by npm on Windows when targeting macOS -->
    <PropertyGroup>
      <_ElectronFrameworksDir>$(ElectronOutDir)node_modules\electron\dist\Electron.app\Contents\Frameworks</_ElectronFrameworksDir>
--- a/src/ElectronNET/build/ElectronNETRules.Project.xaml
+++ b/src/ElectronNET/build/ElectronNETRules.Project.xaml
@@ -436,6 +436,7 @@
    <EnumValue Name="40.9.3" DisplayName="40.9.3" />
    <EnumValue Name="40.10.0" DisplayName="40.10.0" />
    <EnumValue Name="40.10.1" DisplayName="40.10.1" />
+    <EnumValue Name="40.10.2" DisplayName="40.10.2" />
    <EnumValue Name="41.0.0" DisplayName="41.0.0" />
    <EnumValue Name="41.0.1" DisplayName="41.0.1" />
    <EnumValue Name="41.0.2" DisplayName="41.0.2" />
@@ -454,10 +455,15 @@
    <EnumValue Name="41.6.0" DisplayName="41.6.0" />
    <EnumValue Name="41.6.1" DisplayName="41.6.1" />
    <EnumValue Name="41.7.0" DisplayName="41.7.0" />
+    <EnumValue Name="41.7.1" DisplayName="41.7.1" />
    <EnumValue Name="42.0.0" DisplayName="42.0.0" />
    <EnumValue Name="42.0.1" DisplayName="42.0.1" />
    <EnumValue Name="42.1.0" DisplayName="42.1.0" />
    <EnumValue Name="42.2.0" DisplayName="42.2.0" />
+    <EnumValue Name="42.3.0" DisplayName="42.3.0" />
+    <EnumValue Name="42.3.1" DisplayName="42.3.1" />
+    <EnumValue Name="42.3.2" DisplayName="42.3.2" />
+    <EnumValue Name="42.3.3" DisplayName="42.3.3" />
  </EnumProperty>

  <EnumProperty Name="ElectronBuilderVersion"
--- a/src/common.props
+++ b/src/common.props
@@ -1,6 +1,6 @@
 <Project>
  <PropertyGroup>
-    <Version>0.5.0</Version>
+    <Version>0.5.1</Version>
    <PackageNamePrefix>ElectronNET.Core</PackageNamePrefix>
    <Authors>Gregor Biswanger, Florian Rappl, softworkz</Authors>
    <Product>Electron.NET</Product>
Author	SHA1	Message	Date
Florian Rappl	b5858a697a	Added support for Electron 42+	2026-06-07 13:22:25 +02:00
Florian Rappl	58b9ad0125	Improved argument forwarding	2026-06-06 21:10:19 +02:00
Florian Rappl	d9f3da87a8	Merge pull request #1068 from ElectronNET/dependabot/npm_and_yarn/src/ElectronNET.Host/ElectronHostHook/multi-8c9a216550 Bump ws, engine.io and socket.io-adapter in /src/ElectronNET.Host/ElectronHostHook	2026-05-25 22:22:22 +02:00
dependabot[bot]	a33d76ae2f	Bump ws, engine.io and socket.io-adapter Bumps [ws](https://github.com/websockets/ws), [engine.io](https://github.com/socketio/socket.io) and [socket.io-adapter](https://github.com/socketio/socket.io). These dependencies needed to be updated together. Updates `ws` from 8.17.1 to 8.20.1 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/compare/8.17.1...8.20.1) Updates `engine.io` from 6.6.4 to 6.6.8 - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io/compare/engine.io@6.6.4...engine.io@6.6.8) Updates `socket.io-adapter` from 2.5.5 to 2.5.7 - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io/compare/socket.io-adapter@2.5.5...socket.io-adapter@2.5.7) --- updated-dependencies: - dependency-name: ws dependency-version: 8.20.1 dependency-type: indirect - dependency-name: engine.io dependency-version: 6.6.8 dependency-type: indirect - dependency-name: socket.io-adapter dependency-version: 2.5.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>	2026-05-25 20:11:16 +00:00